summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2015-12-30 15:53:52 +0100
committerYorick Peterse <yorickpeterse@gmail.com>2015-12-31 11:26:04 +0100
commitc936e4e3c8282df17f2dc89b305233b7608003ca (patch)
tree17385c4e1e3e51ddef554c2aa46d42b40d8f0021
parent7945cf4163e069c5535968812d259541ec2fd4e8 (diff)
downloadgitlab-ce-reduce-influxdb-tags.tar.gz
Removed various default metrics tagsreduce-influxdb-tags
While it's useful to keep track of the different versions (Ruby, GitLab, etc) doing so for every point wastes disk space and possibly also RAM (which InfluxDB is all to eager to gobble up). If we want to see the performance differences between different GitLab versions simply looking at the performance since the last release date should suffice.
-rw-r--r--lib/gitlab/metrics/metric.rb7
-rw-r--r--spec/lib/gitlab/metrics/metric_spec.rb3
2 files changed, 2 insertions, 8 deletions
diff --git a/lib/gitlab/metrics/metric.rb b/lib/gitlab/metrics/metric.rb
index 79241f56874..753008df99a 100644
--- a/lib/gitlab/metrics/metric.rb
+++ b/lib/gitlab/metrics/metric.rb
@@ -19,11 +19,8 @@ module Gitlab
{
series: @series,
tags: @tags.merge(
- hostname: Metrics.hostname,
- ruby_engine: RUBY_ENGINE,
- ruby_version: RUBY_VERSION,
- gitlab_version: Gitlab::VERSION,
- process_type: Sidekiq.server? ? 'sidekiq' : 'rails'
+ hostname: Metrics.hostname,
+ process_type: Sidekiq.server? ? 'sidekiq' : 'rails'
),
values: @values,
timestamp: @created_at.to_i * 1_000_000_000
diff --git a/spec/lib/gitlab/metrics/metric_spec.rb b/spec/lib/gitlab/metrics/metric_spec.rb
index ec39bc9cce8..aa76315c79c 100644
--- a/spec/lib/gitlab/metrics/metric_spec.rb
+++ b/spec/lib/gitlab/metrics/metric_spec.rb
@@ -39,9 +39,6 @@ describe Gitlab::Metrics::Metric do
expect(hash[:tags]).to be_an_instance_of(Hash)
expect(hash[:tags][:hostname]).to be_an_instance_of(String)
- expect(hash[:tags][:ruby_engine]).to be_an_instance_of(String)
- expect(hash[:tags][:ruby_version]).to be_an_instance_of(String)
- expect(hash[:tags][:gitlab_version]).to be_an_instance_of(String)
expect(hash[:tags][:process_type]).to be_an_instance_of(String)
end