diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-11-21 17:32:12 +0100 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-11-21 17:40:29 +0100 |
| commit | 54f1e406f40a31c6d790bdeabc55556a268990e1 (patch) | |
| tree | 50ce60e6931cc2da6a96bfa712bf699b1273b030 | |
| parent | 9024875e1f81a3aab3c0879d33a4cea912ce833d (diff) | |
| download | gitlab-ce-reduce-queries-for-artifacts-button.tar.gz | |
Use arrays in Pipeline#latest_builds_with_artifactsreduce-queries-for-artifacts-button
This changes Ci::Pipeline#latest_builds_with_artifacts so it returns an
Array instead of a relation. Whenever we use this data we do so in two
steps:
1. Count the number of rows
2. If this number is greater than 0, iterate over the rows
By returning an Array instead we only execute 1 query of which the total
time/work is less than running either just a COUNT(*) or both queries
(in the worst case).
On GitLab.com this change should save us a few milliseconds per request
to ProjectsController#show.
| -rw-r--r-- | app/models/ci/pipeline.rb | 5 | ||||
| -rw-r--r-- | changelogs/unreleased/reduce-queries-for-artifacts-button.yml | 5 | ||||
| -rw-r--r-- | spec/models/ci/pipeline_spec.rb | 4 |
3 files changed, 13 insertions, 1 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index 3ded675bec0..ebbefc51a4f 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -507,7 +507,10 @@ module Ci end def latest_builds_with_artifacts - @latest_builds_with_artifacts ||= builds.latest.with_artifacts + # We purposely cast the builds to an Array here. Because we always use the + # rows if there are more than 0 this prevents us from having to run two + # queries: one to get the count and one to get the rows. + @latest_builds_with_artifacts ||= builds.latest.with_artifacts.to_a end private diff --git a/changelogs/unreleased/reduce-queries-for-artifacts-button.yml b/changelogs/unreleased/reduce-queries-for-artifacts-button.yml new file mode 100644 index 00000000000..f2d469b5a80 --- /dev/null +++ b/changelogs/unreleased/reduce-queries-for-artifacts-button.yml @@ -0,0 +1,5 @@ +--- +title: Use arrays in Pipeline#latest_builds_with_artifacts +merge_request: +author: +type: performance diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb index b89b0e555d9..3a19a0753e2 100644 --- a/spec/models/ci/pipeline_spec.rb +++ b/spec/models/ci/pipeline_spec.rb @@ -1502,6 +1502,10 @@ describe Ci::Pipeline, :mailer do create(:ci_build, :success, :artifacts, pipeline: pipeline) end + it 'returns an Array' do + expect(pipeline.latest_builds_with_artifacts).to be_an_instance_of(Array) + end + it 'returns the latest builds' do expect(pipeline.latest_builds_with_artifacts).to eq([build]) end |