diff options
| author | Clement Ho <ClemMakesApps@gmail.com> | 2017-07-17 15:40:08 -0500 |
|---|---|---|
| committer | Clement Ho <ClemMakesApps@gmail.com> | 2017-07-17 15:40:08 -0500 |
| commit | 8f511d596843ca5b7a919ee8ccc29d1e7f6fb0d9 (patch) | |
| tree | 347c86013c5dddbede303d41f23e98e7da855d86 | |
| parent | b885d0291086fb0101d6f66d30ca5c4228d6f45c (diff) | |
| download | gitlab-ce-refactor-dropdown-parameters-ce.tar.gz | |
Resolve code review improvementsrefactor-dropdown-parameters-ce
| -rw-r--r-- | app/assets/javascripts/filtered_search/filtered_search_dropdown.js | 4 | ||||
| -rw-r--r-- | app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/app/assets/javascripts/filtered_search/filtered_search_dropdown.js b/app/assets/javascripts/filtered_search/filtered_search_dropdown.js index 68d1ee7003b..9e9a9ef74be 100644 --- a/app/assets/javascripts/filtered_search/filtered_search_dropdown.js +++ b/app/assets/javascripts/filtered_search/filtered_search_dropdown.js @@ -1,9 +1,7 @@ const DATA_DROPDOWN_TRIGGER = 'data-dropdown-trigger'; class FilteredSearchDropdown { - constructor(options = {}) { - const { droplab, dropdown, input, filter } = options; - + constructor({ droplab, dropdown, input, filter }) { this.droplab = droplab; this.hookId = input && input.id; this.input = input; diff --git a/app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js b/app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js index 27d497bd090..61cef435209 100644 --- a/app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js +++ b/app/assets/javascripts/filtered_search/filtered_search_dropdown_manager.js @@ -111,7 +111,7 @@ class FilteredSearchDropdownManager { filter: key, }; const extraArguments = mappingKey.extraArguments || {}; - const glArguments = Object.assign(defaultArguments, extraArguments); + const glArguments = Object.assign({}, defaultArguments, extraArguments); // Passing glArguments to `new gl[glClass](<arguments>)` mappingKey.reference = |