diff options
| author | Luke Duncalfe <lduncalfe@eml.cc> | 2019-01-30 07:17:00 +1300 |
|---|---|---|
| committer | Luke Duncalfe <lduncalfe@eml.cc> | 2019-01-30 07:17:00 +1300 |
| commit | 4cd90cc99758d4fc60a7fb6570afe80c53a9cf4d (patch) | |
| tree | f999216dcb367bc8f7a53221baf26285d63262cf | |
| parent | 2d24dca485f57f3f7ecf0da0cbf07a566d90a98c (diff) | |
| download | gitlab-ce-remove-merge-request-title-length-danger-check.tar.gz | |
Revert "Warn when MR titles are too long"remove-merge-request-title-length-danger-check
This reverts commit edd3e107c65edda75ec83398ff6fe031fbe1b4a6.
This commit is being reverted as squash commit messages are no longer
taken from the MR title, and are instead now taken from the longest
commit message in the merge.
Issue
https://gitlab.com/gitlab-org/gitlab-ce/issues/47149
| -rw-r--r-- | danger/metadata/Dangerfile | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/danger/metadata/Dangerfile b/danger/metadata/Dangerfile index 1adca152736..51fc9e6bfca 100644 --- a/danger/metadata/Dangerfile +++ b/danger/metadata/Dangerfile @@ -23,10 +23,3 @@ has_pick_into_stable_label = gitlab.mr_labels.find { |label| label.start_with?(' if gitlab.branch_for_base != "master" && !has_pick_into_stable_label warn "Most of the time, merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label." end - -if gitlab.mr_json['title'].length > 72 - warn 'The title of this merge request is longer than 72 characters and ' \ - 'would violate our commit message rules when using the Squash on Merge ' \ - 'feature. Please consider adjusting the title, or rebase the ' \ - "commits manually and don't use Squash on Merge." -end |