diff options
| author | Douwe Maan <douwe@gitlab.com> | 2018-10-02 15:13:24 +0000 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2018-10-02 15:13:24 +0000 |
| commit | 008da5317608fb2ff3113bdebfc6627b9ddf1881 (patch) | |
| tree | c9775babeffe6bcc8adf547083728f18fd40162f | |
| parent | d5184e0d8b48bc221e1ea401b9171db07959b50c (diff) | |
| download | gitlab-ce-revert-5ad87599.tar.gz | |
Revert "Merge branch 'code_review-assign-maintainers-different-team' into 'master'"revert-5ad87599
This reverts merge request !21644
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index edf0b6f46df..e50e6370c80 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -27,9 +27,8 @@ There are a few rules to get your merge request accepted: ask or assign any [reviewers][projects] for a first review. 1. If you need some guidance (e.g. it's your first merge request), feel free to ask one of the [Merge request coaches][team]. - 1. It is recommended that you assign a maintainer that is from a different team than your own. - This ensures that all code across GitLab is consistent and can be easily understood by all contributors. - + 1. The reviewer will assign the merge request to a maintainer once the + reviewer is satisfied with the state of the merge request. 1. Keep in mind that maintainers are also going to perform a final code review. The ideal scenario is that the reviewer has already addressed any concerns the maintainer would have found, and the maintainer only has to perform the |