summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2016-09-14 17:26:48 -0400
committerRobert Speicher <rspeicher@gmail.com>2016-09-15 13:45:11 -0400
commit2dbcd0eb97562a60480d8dd86b10af580cc52ef5 (patch)
tree11e2afcc00fcd6c6b343cb8e9d8978fd264de7ca
parentdfc7f50ce5569bacdb4167e39b1c37fc02430313 (diff)
downloadgitlab-ce-rs-update-rubocop-rspec.tar.gz
Update `.rubocop.yml` for rubocop-rspec 1.7.0rs-update-rubocop-rspec
-rw-r--r--.rubocop.yml77
1 files changed, 67 insertions, 10 deletions
diff --git a/.rubocop.yml b/.rubocop.yml
index 5bd31ccf329..b054675d677 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -767,26 +767,33 @@ Rails/ScopeArgs:
RSpec/AnyInstance:
Enabled: false
-# Check that the first argument to the top level describe is the tested class or
-# module.
+# Check for expectations where `be(...)` can replace `eql(...)`.
+RSpec/BeEql:
+ Enabled: false
+
+# Check that the first argument to the top level describe is a constant.
RSpec/DescribeClass:
Enabled: false
-# Use `described_class` for tested class / module.
+# Checks that tests use `described_class`.
+RSpec/DescribedClass:
+ Enabled: false
+
+# Checks that the second argument to `describe` specifies a method.
RSpec/DescribeMethod:
Enabled: false
-# Checks that the second argument to top level describe is the tested method
-# name.
-RSpec/DescribedClass:
+# Checks if an example group does not include any tests.
+RSpec/EmptyExampleGroup:
Enabled: false
+ CustomIncludeMethods: []
-# Checks for long example.
+# Checks for long examples.
RSpec/ExampleLength:
Enabled: false
Max: 5
-# Do not use should when describing your tests.
+# Checks that example descriptions do not start with "should".
RSpec/ExampleWording:
Enabled: false
CustomTransform:
@@ -795,6 +802,10 @@ RSpec/ExampleWording:
not: does not
IgnoredWords: []
+# Checks for `expect(...)` calls containing literal values.
+RSpec/ExpectActual:
+ Enabled: false
+
# Checks the file and folder naming of the spec file.
RSpec/FilePath:
Enabled: false
@@ -806,19 +817,65 @@ RSpec/FilePath:
RSpec/Focus:
Enabled: true
+# Checks the arguments passed to `before`, `around`, and `after`.
+RSpec/HookArgument:
+ Enabled: false
+ EnforcedStyle: implicit
+
+# Check that a consistent implict expectation style is used.
+# TODO (rspeicher): Available in rubocop-rspec 1.8.0
+# RSpec/ImplicitExpect:
+# Enabled: true
+# EnforcedStyle: is_expected
+
# Checks for the usage of instance variables.
RSpec/InstanceVariable:
Enabled: false
-# Checks for multiple top-level describes.
+# Checks for `subject` definitions that come after `let` definitions.
+RSpec/LeadingSubject:
+ Enabled: false
+
+# Checks unreferenced `let!` calls being used for test setup.
+RSpec/LetSetup:
+ Enabled: false
+
+# Check that chains of messages are not being stubbed.
+RSpec/MessageChain:
+ Enabled: false
+
+# Checks for consistent message expectation style.
+RSpec/MessageExpectation:
+ Enabled: false
+ EnforcedStyle: allow
+
+# Checks for multiple top level describes.
RSpec/MultipleDescribes:
Enabled: false
-# Enforces the usage of the same method on all negative message expectations.
+# Checks if examples contain too many `expect` calls.
+RSpec/MultipleExpectations:
+ Enabled: false
+ Max: 1
+
+# Checks for explicitly referenced test subjects.
+RSpec/NamedSubject:
+ Enabled: false
+
+# Checks for nested example groups.
+RSpec/NestedGroups:
+ Enabled: false
+ MaxNesting: 2
+
+# Checks for consistent method usage for negating expectations.
RSpec/NotToNot:
EnforcedStyle: not_to
Enabled: true
+# Checks for stubbed test subjects.
+RSpec/SubjectStub:
+ Enabled: false
+
# Prefer using verifying doubles over normal doubles.
RSpec/VerifiedDoubles:
Enabled: false