diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-04-18 20:00:35 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-04-19 06:45:01 -0700 |
| commit | 3f0054a88c84ef5631ee82c1cc9bc985c2eea58b (patch) | |
| tree | 0464eb8ec25de8420f23d3669c66ddfdeb3260e1 | |
| parent | a9da37434af6d44c5f851affd4bd69b370760e8e (diff) | |
| download | gitlab-ce-sh-add-index-to-system-note-metadata.tar.gz | |
Add unique index for note_id to system note metadata tablesh-add-index-to-system-note-metadata
In issue 1, the sequential scan was taking 250+ ms.
| -rw-r--r-- | changelogs/unreleased/sh-add-index-to-system-note-metadata.yml | 4 | ||||
| -rw-r--r-- | db/migrate/20170419001229_add_index_to_system_note_metadata.rb | 17 | ||||
| -rw-r--r-- | db/schema.rb | 4 |
3 files changed, 24 insertions, 1 deletions
diff --git a/changelogs/unreleased/sh-add-index-to-system-note-metadata.yml b/changelogs/unreleased/sh-add-index-to-system-note-metadata.yml new file mode 100644 index 00000000000..6b226c53f30 --- /dev/null +++ b/changelogs/unreleased/sh-add-index-to-system-note-metadata.yml @@ -0,0 +1,4 @@ +--- +title: Add unique index for notes_id to system note metadata table +merge_request: +author: diff --git a/db/migrate/20170419001229_add_index_to_system_note_metadata.rb b/db/migrate/20170419001229_add_index_to_system_note_metadata.rb new file mode 100644 index 00000000000..c68fd920fff --- /dev/null +++ b/db/migrate/20170419001229_add_index_to_system_note_metadata.rb @@ -0,0 +1,17 @@ +class AddIndexToSystemNoteMetadata < ActiveRecord::Migration + include Gitlab::Database::MigrationHelpers + + # Set this constant to true if this migration requires downtime. + DOWNTIME = false + + disable_ddl_transaction! + + def up + # MySQL automatically creates an index on a foreign-key constraint; PostgreSQL does not + add_concurrent_index :system_note_metadata, :note_id, unique: true if Gitlab::Database.postgresql? + end + + def down + remove_concurrent_index :system_note_metadata, :note_id, unique: true if Gitlab::Database.postgresql? + end +end diff --git a/db/schema.rb b/db/schema.rb index 26ec6367bd0..e84fd90a4cd 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -11,7 +11,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20170418103908) do +ActiveRecord::Schema.define(version: 20170419001229) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -1140,6 +1140,8 @@ ActiveRecord::Schema.define(version: 20170418103908) do t.datetime "updated_at", null: false end + add_index "system_note_metadata", ["note_id"], name: "index_system_note_metadata_on_note_id", unique: true, using: :btree + create_table "taggings", force: :cascade do |t| t.integer "tag_id" t.integer "taggable_id" |