diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-05-03 23:15:47 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2018-05-03 23:18:42 -0700 |
| commit | ca9c2f142428171c610f486b56d7d78ea8c73d04 (patch) | |
| tree | 156a515c8fa65ddfcc09cb633406cba176f16bb8 | |
| parent | 31fa96960f7d224a1da4ca1cf1520a657558567d (diff) | |
| download | gitlab-ce-sh-fix-ldap-base-options.tar.gz | |
Fix LDAP authentication on systems not using a base of dc=comsh-fix-ldap-base-options
By default, the Net::LDAP library uses an LDAP base of `dc=com` if no value
is provided. Systems that used a different base would have LDAP searches fail
since the base was not passed along properly.
Closes #43926
| -rw-r--r-- | changelogs/unreleased/sh-fix-ldap-base-options.yml | 5 | ||||
| -rw-r--r-- | lib/gitlab/auth/ldap/config.rb | 1 | ||||
| -rw-r--r-- | spec/lib/gitlab/auth/ldap/config_spec.rb | 2 |
3 files changed, 8 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-fix-ldap-base-options.yml b/changelogs/unreleased/sh-fix-ldap-base-options.yml new file mode 100644 index 00000000000..f0cb2e49944 --- /dev/null +++ b/changelogs/unreleased/sh-fix-ldap-base-options.yml @@ -0,0 +1,5 @@ +--- +title: Fix LDAP authentication on systems not using a base of dc=com +merge_request: +author: +type: fixed diff --git a/lib/gitlab/auth/ldap/config.rb b/lib/gitlab/auth/ldap/config.rb index 77185f52ced..3cf1e4f3451 100644 --- a/lib/gitlab/auth/ldap/config.rb +++ b/lib/gitlab/auth/ldap/config.rb @@ -53,6 +53,7 @@ module Gitlab def adapter_options opts = base_options.merge( + base: base, encryption: encryption_options ) diff --git a/spec/lib/gitlab/auth/ldap/config_spec.rb b/spec/lib/gitlab/auth/ldap/config_spec.rb index 82587e2ba55..649e34a7cd0 100644 --- a/spec/lib/gitlab/auth/ldap/config_spec.rb +++ b/spec/lib/gitlab/auth/ldap/config_spec.rb @@ -31,6 +31,7 @@ describe Gitlab::Auth::LDAP::Config do it 'constructs basic options' do stub_ldap_config( options: { + 'base' => 'dc=example,dc=com', 'host' => 'ldap.example.com', 'port' => 386, 'encryption' => 'plain' @@ -38,6 +39,7 @@ describe Gitlab::Auth::LDAP::Config do ) expect(config.adapter_options).to eq( + base: 'dc=example,dc=com', host: 'ldap.example.com', port: 386, encryption: nil |