diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-08-01 16:07:50 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-08-01 16:08:48 -0700 |
| commit | 65f188887bdac150616050ca023bc694de9f3ed2 (patch) | |
| tree | 967e74fe8de82044969e103b2c31b1e210b48df5 | |
| parent | 52b857f119debb5a03c216c4199eb21a49d815b6 (diff) | |
| download | gitlab-ce-sh-fix-performance-bar-warnings.tar.gz | |
Fix performance bar warnings when Rugged is disabledsh-fix-performance-bar-warnings
`detailed_metric.vue` was attempting to read the `duration` field even
when the metric did not exist in the JSON payload. We now check for the
existence of the metrics before attempting to display the value.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65491
| -rw-r--r-- | app/assets/javascripts/performance_bar/components/detailed_metric.vue | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/assets/javascripts/performance_bar/components/detailed_metric.vue b/app/assets/javascripts/performance_bar/components/detailed_metric.vue index 5bc1d5e0533..73524827c5d 100644 --- a/app/assets/javascripts/performance_bar/components/detailed_metric.vue +++ b/app/assets/javascripts/performance_bar/components/detailed_metric.vue @@ -44,7 +44,7 @@ export default { </script> <template> <div - v-if="currentRequest.details" + v-if="currentRequest.details && metricDetails" :id="`peek-view-${metric}`" class="view qa-performance-bar-detailed-metric" > |