summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-03-11 07:06:06 -0700
committerStan Hu <stanhu@gmail.com>2018-03-11 07:06:06 -0700
commit3b2674c92b48a2b1fe98aa92a82f2f76e1703fdf (patch)
tree0a36b359275bb6dabfcb60ce3daac421b526ddff
parentafd2d381119c3778140c3dd63c7ef24ecdb4c62e (diff)
downloadgitlab-ce-sh-optimize-destroy-service.tar.gz
Prefer find_each to each in Users::DestroyServicesh-optimize-destroy-service
-rw-r--r--app/services/users/destroy_service.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/services/users/destroy_service.rb b/app/services/users/destroy_service.rb
index 06b604dad4d..c725af1a976 100644
--- a/app/services/users/destroy_service.rb
+++ b/app/services/users/destroy_service.rb
@@ -36,14 +36,14 @@ module Users
# is done by a foreign_key. Otherwise they won't be called
user.members.find_each { |member| member.run_callbacks(:destroy) }
- user.solo_owned_groups.each do |group|
+ user.solo_owned_groups.find_each do |group|
Groups::DestroyService.new(group, current_user).execute
end
namespace = user.namespace
namespace.prepare_for_destroy
- user.personal_projects.each do |project|
+ user.personal_projects.find_each do |project|
# Skip repository removal because we remove directory with namespace
# that contain all this repositories
::Projects::DestroyService.new(project, current_user, skip_repo: project.legacy_storage?).execute