diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-10-31 14:34:57 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2018-10-31 14:34:57 -0700 |
| commit | f0bef249c73ea4352a937fe8a48bac013398e640 (patch) | |
| tree | 0e57e5e5fac9083c421af039f554bcd27db812a8 | |
| parent | 98a504ecbb45907517ae465018906af7ef4573de (diff) | |
| download | gitlab-ce-sh-pluck-merge-request-diff-commit-shas.tar.gz | |
Use pluck instead of map for loading commit SHAssh-pluck-merge-request-diff-commit-shas
This saves some ActiveRecord overhead and memory.
| -rw-r--r-- | app/models/merge_request_diff.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/merge_request_diff.rb b/app/models/merge_request_diff.rb index 02c6b650f33..d1a8e1d2fd2 100644 --- a/app/models/merge_request_diff.rb +++ b/app/models/merge_request_diff.rb @@ -137,7 +137,7 @@ class MergeRequestDiff < ActiveRecord::Base end def commit_shas - merge_request_diff_commits.map(&:sha) + merge_request_diff_commits.pluck(&:sha) end def diff_refs=(new_diff_refs) |