summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2016-09-21 01:03:47 +0800
committerLin Jen-Shin <godfat@godfat.org>2016-09-21 01:03:47 +0800
commit93ab5856e4de9a13e730cf9d200e4f0934f4bece (patch)
treedc623dd429e0c9684725b6df14fa795342aa8f39
parenta14d6a9e4ba755cd35f911d58e5c64ad56a81093 (diff)
downloadgitlab-ce-show-all-pipelines-from-all-diffs.tar.gz
Use factory instead of using new directly. Feedback:show-all-pipelines-from-all-diffs
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6414#note_15765156
-rw-r--r--spec/models/merge_request_spec.rb11
1 files changed, 2 insertions, 9 deletions
diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb
index fce236bcb5d..38c2a28d3e1 100644
--- a/spec/models/merge_request_spec.rb
+++ b/spec/models/merge_request_spec.rb
@@ -524,18 +524,11 @@ describe MergeRequest, models: true do
end
context 'with unsaved merge request' do
- let(:project) { create(:project) }
-
- subject do
- MergeRequest.new(source_project: project,
- target_project: project,
- source_branch: 'master',
- target_branch: 'feature')
- end
+ subject { build(:merge_request) }
let!(:pipeline) do
create(:ci_empty_pipeline,
- project: project,
+ project: subject.project,
sha: subject.diff_head_sha,
ref: subject.source_branch)
end