summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-10-01 15:51:28 +0200
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-10-01 15:51:28 +0200
commite2576d588fef876e743f55b0b5b0620da43ab1c1 (patch)
treea22b3f5cd82855c4572ee407d6b15719379e64be
parent0d967bce574c3750429bf2aed7f8c4ddc6ce1971 (diff)
downloadgitlab-ce-show-diff-stats-for-mr.tar.gz
Avoid unnecessary usage of local varsshow-diff-stats-for-mr
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-rw-r--r--app/views/projects/diffs/_diffs.html.haml5
-rw-r--r--app/views/projects/diffs/_stats.html.haml4
2 files changed, 3 insertions, 6 deletions
diff --git a/app/views/projects/diffs/_diffs.html.haml b/app/views/projects/diffs/_diffs.html.haml
index ac2461b3b24..4f1965bfb39 100644
--- a/app/views/projects/diffs/_diffs.html.haml
+++ b/app/views/projects/diffs/_diffs.html.haml
@@ -8,10 +8,7 @@
.btn-group
= inline_diff_btn
= parallel_diff_btn
- - additions = diff_files.sum(&:added_lines)
- - deletions = diff_files.sum(&:removed_lines)
- = render 'projects/diffs/stats', diff_files: diff_files,
- additions: additions, deletions: deletions
+ = render 'projects/diffs/stats', diff_files: diff_files
- if diff_files.count < diffs.size
= render 'projects/diffs/warning', diffs: diffs, shown_files_count: diff_files.count
diff --git a/app/views/projects/diffs/_stats.html.haml b/app/views/projects/diffs/_stats.html.haml
index 9e49716f7a7..ea2a3e01277 100644
--- a/app/views/projects/diffs/_stats.html.haml
+++ b/app/views/projects/diffs/_stats.html.haml
@@ -4,9 +4,9 @@
= link_to '#', class: 'js-toggle-button' do
%strong #{pluralize(diff_files.count, "changed file")}
with
- %strong.cgreen #{additions} additions
+ %strong.cgreen #{diff_files.sum(&:added_lines)} additions
and
- %strong.cred #{deletions} deletions
+ %strong.cred #{diff_files.sum(&:removed_lines)} deletions
.file-stats.js-toggle-content.hide
%ul
- diff_files.each_with_index do |diff_file, i|