summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2016-07-18 20:04:16 +0300
committerJacob Schatz <jschatz1@gmail.com>2016-07-20 09:36:56 -0400
commit3e24a102976586a4417820694580eb9b72defb3d (patch)
tree242e46515d850f0fa80e69597dbe8028a9b25f36
parent12c4fb1b0f5620fdda7f358280c3feeb3ea7d47f (diff)
downloadgitlab-ce-sidebar-clipboard-toggle.tar.gz
Prevent toggling sidebar when clipboard icon clicked.sidebar-clipboard-toggle
-rw-r--r--CHANGELOG1
-rw-r--r--app/assets/javascripts/right_sidebar.js.coffee3
-rw-r--r--app/views/shared/issuable/_sidebar.html.haml2
3 files changed, 5 insertions, 1 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 63fb78c8b02..19a9fa633a9 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -131,6 +131,7 @@ v 8.10.0 (unreleased)
- Fix issues importing projects from EE to CE
- Fix creating group with space in group path
- Improve cron_jobs loading error messages !5318 / !5360
+ - Prevent toggling sidebar when clipboard icon clicked
- Create Todos for Issue author when assign or mention himself (Katarzyna Kobierska)
- Limit the number of retries on error to 3 for exporting projects
- Allow empty repositories on project import/export
diff --git a/app/assets/javascripts/right_sidebar.js.coffee b/app/assets/javascripts/right_sidebar.js.coffee
index 12340bbce54..0c95301e380 100644
--- a/app/assets/javascripts/right_sidebar.js.coffee
+++ b/app/assets/javascripts/right_sidebar.js.coffee
@@ -120,6 +120,9 @@ class @Sidebar
i.show()
sidebarCollapseClicked: (e) ->
+
+ return if $(e.currentTarget).hasClass('dont-change-state')
+
sidebar = e.data
e.preventDefault()
$block = $(@).closest('.block')
diff --git a/app/views/shared/issuable/_sidebar.html.haml b/app/views/shared/issuable/_sidebar.html.haml
index e020a7d4d00..8e2fcbdfab8 100644
--- a/app/views/shared/issuable/_sidebar.html.haml
+++ b/app/views/shared/issuable/_sidebar.html.haml
@@ -156,7 +156,7 @@
- project_ref = cross_project_reference(@project, issuable)
.block.project-reference
- .sidebar-collapsed-icon
+ .sidebar-collapsed-icon.dont-change-state
= clipboard_button(clipboard_text: project_ref)
.cross-project-reference.hide-collapsed
%span