Forbid Sidekiq scheduling in transactionssidekiq-transaction

Scheduling jobs in transactions can lead to race conditions where a job
runs before a transaction has been committed. The added initializer
ensures the various Sidekiq scheduling methods raise an error when
called inside a transaction.

Fixes #27233

1 files changed, 15 insertions, 0 deletions

diff --git a/config/initializers/forbid_sidekiq_in_transactions.rb b/config/initializers/forbid_sidekiq_in_transactions.rb
new file mode 100644
index 00000000000..0086dfe43a7
--- /dev/null
+++ b/config/initializers/forbid_sidekiq_in_transactions.rb
@@ -0,0 +1,15 @@
+mod = Module.new do
+  NESTING = ::Rails.env.test? ? 1 : 0
+
+  [:perform_async, :perform_at, :perform_in].each do |name|
+    define_method(name) do |*args|
+      if ActiveRecord::Base.connection.open_transactions > NESTING
+        raise "#{self}.#{name} can not be called in a transaction as this can lead to race conditions"
+      end
+
+      super(*args)
+    end
+  end
+end
+
+Sidekiq::Worker::ClassMethods.prepend(mod)