diff options
| author | Toon Claes <toon@gitlab.com> | 2019-08-27 09:48:16 +0200 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2019-08-27 13:45:53 +0200 |
| commit | 7e0960f6e220c2ae54abb457508c9b20fa132a9f (patch) | |
| tree | 75cb183d13e41e0adb1c576dd60bd21b2967af79 | |
| parent | 78283f8b00d79fa0e9f316c46538a9dee5b01d58 (diff) | |
| download | gitlab-ce-tc-cleanup-issue-created-text-mail.tar.gz | |
Bring text mail for new issue & MR more in linetc-cleanup-issue-created-text-mail
Make these templates for mail notifications for a new issue and a new
merge request more similar.
Also remove some leading whitespace in text mails.
| -rw-r--r-- | app/views/notify/new_issue_email.text.erb | 10 | ||||
| -rw-r--r-- | app/views/notify/new_merge_request_email.text.erb | 4 | ||||
| -rw-r--r-- | changelogs/unreleased/tc-cleanup-issue-created-text-mail.yml | 5 |
3 files changed, 10 insertions, 9 deletions
diff --git a/app/views/notify/new_issue_email.text.erb b/app/views/notify/new_issue_email.text.erb index b93d95ef02f..bd61db3ee76 100644 --- a/app/views/notify/new_issue_email.text.erb +++ b/app/views/notify/new_issue_email.text.erb @@ -1,9 +1,5 @@ -<%= sanitize_name(@issue.author_name) %> <%= 'created an issue:' %> +<%= sanitize_name(@issue.author_name) %> <%= 'created an issue:' %> <%= url_for(project_issue_url(@issue.project, @issue)) %> -<% if @issue.assignees.any? -%> - <%= assignees_label(@issue) %> -<% end %> +<%= assignees_label(@issue) if @issue.assignees.any? %> -<% if @issue.description -%> - <%= @issue.description %> -<% end %> +<%= @issue.description %> diff --git a/app/views/notify/new_merge_request_email.text.erb b/app/views/notify/new_merge_request_email.text.erb index 6c0d7b1e60b..f4b0ed0f886 100644 --- a/app/views/notify/new_merge_request_email.text.erb +++ b/app/views/notify/new_merge_request_email.text.erb @@ -1,8 +1,8 @@ -<%= @merge_request.author_name %> <%= 'created a merge request:' %> <%= url_for(project_merge_request_url(@merge_request.target_project, @merge_request)) %> +<%= sanitize_name(@merge_request.author_name) %> <%= 'created a merge request:' %> <%= url_for(project_merge_request_url(@merge_request.target_project, @merge_request)) %> <%= merge_path_description(@merge_request, 'to') %> <%= 'Author:' %> <%= @merge_request.author_name %> -<%= assignees_label(@merge_request) %> +<%= assignees_label(@merge_request) if @merge_request.assignees.any? %> <%= render_if_exists 'notify/merge_request_approvers', presenter: @mr_presenter %> <%= @merge_request.description %> diff --git a/changelogs/unreleased/tc-cleanup-issue-created-text-mail.yml b/changelogs/unreleased/tc-cleanup-issue-created-text-mail.yml new file mode 100644 index 00000000000..cc590ee38eb --- /dev/null +++ b/changelogs/unreleased/tc-cleanup-issue-created-text-mail.yml @@ -0,0 +1,5 @@ +--- +title: Bring text mail for new issue & MR more in line +merge_request: 32254 +author: +type: changed |