diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-12-10 21:06:26 +0100 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-12-10 21:06:26 +0100 |
commit | 258faa8549167910311d7d6df689bd3dfb954ef1 (patch) | |
tree | d63f8bd52d62fb6db8ad1bc18a331589bde4130a | |
parent | 621d08d308f6f2a74188149590536dcd23f1c0cf (diff) | |
download | gitlab-ce-ui-right-sidebar.tar.gz |
Fix tests for new issuable sidebarui-right-sidebar
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-rw-r--r-- | app/views/shared/issuable/_sidebar.html.haml | 17 | ||||
-rw-r--r-- | spec/features/issues_spec.rb | 27 |
2 files changed, 30 insertions, 14 deletions
diff --git a/app/views/shared/issuable/_sidebar.html.haml b/app/views/shared/issuable/_sidebar.html.haml index 10f1aaf8c31..cbd01c7d4fd 100644 --- a/app/views/shared/issuable/_sidebar.html.haml +++ b/app/views/shared/issuable/_sidebar.html.haml @@ -8,7 +8,7 @@ = cross_project_reference(@project, issuable) = clipboard_button(clipboard_target: 'span#cross-project-reference') - .block + .block.assignee .title %label Assignee: @@ -19,12 +19,12 @@ - if issuable.assignee %strong= link_to_member(@project, issuable.assignee, size: 24) - else - none + None .selectbox = users_select_tag("#{issuable.class.table_name.singularize}[assignee_id]", placeholder: 'Select assignee', class: 'custom-form-control js-select2 js-assignee', selected: issuable.assignee_id, project: @target_project, null_user: true, current_user: true, first_user: true) - .block + .block.milestone .title %label Milestone: @@ -39,13 +39,13 @@ = icon('clock-o') = issuable.milestone.title - else - none + None .selectbox = f.select(:milestone_id, milestone_options(issuable), { include_blank: true }, { class: 'select2 select2-compact js-select2 js-milestone', data: { placeholder: 'Select milestone' }}) = hidden_field_tag :issuable_context = f.submit class: 'btn hide' - - if issuable.labels.any? + - if issuable.project.labels.any? .block .title %label Labels @@ -53,8 +53,11 @@ .pull-right = link_to 'Edit', '#', class: 'edit-link' .value.issuable-show-labels - - issuable.labels.each do |label| - = link_to_label(label) + - if issuable.labels.any? + - issuable.labels.each do |label| + = link_to_label(label) + - else + None .selectbox = f.collection_select :label_ids, issuable.project.labels.all, :id, :name, { selected: issuable.label_ids }, multiple: true, class: 'select2 js-select2', data: { placeholder: "Select labels" } diff --git a/spec/features/issues_spec.rb b/spec/features/issues_spec.rb index 3d6d87e764a..0cad8c78ad2 100644 --- a/spec/features/issues_spec.rb +++ b/spec/features/issues_spec.rb @@ -69,7 +69,10 @@ describe 'Issues', feature: true do click_button 'Save changes' - expect(page).to have_content 'Assignee: none' + page.within('.assignee') do + expect(page).to have_content 'None' + end + expect(issue.reload.assignee).to be_nil end end @@ -202,7 +205,7 @@ describe 'Issues', feature: true do it 'with dropdown menu' do visit namespace_project_issue_path(project.namespace, project, issue) - find('.context #issue_assignee_id'). + find('.issuable-sidebar #issue_assignee_id'). set project.team.members.first.id click_button 'Update Issue' @@ -241,12 +244,16 @@ describe 'Issues', feature: true do it 'with dropdown menu' do visit namespace_project_issue_path(project.namespace, project, issue) - find('.context'). + find('.issuable-sidebar'). select(milestone.title, from: 'issue_milestone_id') click_button 'Update Issue' expect(page).to have_content "Milestone changed to #{milestone.title}" - expect(page).to have_content "Milestone: #{milestone.title}" + + page.within('.milestone') do + expect(page).to have_content milestone.title + end + has_select?('issue_assignee_id', selected: milestone.title) end end @@ -279,13 +286,19 @@ describe 'Issues', feature: true do it 'allows user to remove assignee', js: true do visit namespace_project_issue_path(project.namespace, project, issue) - expect(page).to have_content "Assignee: #{user2.name}" - first('#s2id_issue_assignee_id').click + page.within('.assignee') do + expect(page).to have_content user2.name + end + + find('.assignee .edit-link').click sleep 2 # wait for ajax stuff to complete first('.user-result').click - expect(page).to have_content 'Assignee: none' + page.within('.assignee') do + expect(page).to have_content 'None' + end + sleep 2 # wait for ajax stuff to complete expect(issue.reload.assignee).to be_nil end |