diff options
author | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-06-27 12:38:45 +1000 |
---|---|---|
committer | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-06-27 13:10:27 +1000 |
commit | f9bc4d27f4ac7fc0a8283e0d6ad6e5a3ceb5d813 (patch) | |
tree | 4f6f193e4faaa2bef947aa07017d9798b7cf5fe3 | |
parent | 89d0917a451d35448deeeccb9bed6cd410e9507f (diff) | |
download | gitlab-ce-vue-i18n-js-boards-directory.tar.gz |
Minor review fixesvue-i18n-js-boards-directory
Use single quotes only
Added missed translations
6 files changed, 36 insertions, 28 deletions
diff --git a/app/assets/javascripts/boards/components/board_blank_state.vue b/app/assets/javascripts/boards/components/board_blank_state.vue index 571d7dbe4ae..f58149c9f7b 100644 --- a/app/assets/javascripts/boards/components/board_blank_state.vue +++ b/app/assets/javascripts/boards/components/board_blank_state.vue @@ -59,7 +59,11 @@ export default { <template> <div class="board-blank-state p-3"> - <p>{{ __('Add the following default lists to your Issue Board with one click:') }}</p> + <p> + {{ + __('BoardBlankState|Add the following default lists to your Issue Board with one click:') + }} + </p> <ul class="list-unstyled board-blank-state-list"> <li v-for="(label, index) in predefinedLabels" :key="index"> <span @@ -73,7 +77,7 @@ export default { <p> {{ __( - 'Starting out with the default set of lists will get you right on the way to making the most of your board.', + 'BoardBlankState|Starting out with the default set of lists will get you right on the way to making the most of your board.', ) }} </p> @@ -82,10 +86,10 @@ export default { type="button" @click.stop="addDefaultLists" > - {{ __('Add default lists') }} + {{ __('BoardBlankState|Add default lists') }} </button> <button class="btn btn-default btn-block" type="button" @click.stop="clearBlankState"> - {{ __("Nevermind, I'll use my own") }} + {{ __("BoardBlankState|Nevermind, I'll use my own") }} </button> </div> </template> diff --git a/app/assets/javascripts/boards/components/board_list.vue b/app/assets/javascripts/boards/components/board_list.vue index a0a7d523535..787ff110bf8 100644 --- a/app/assets/javascripts/boards/components/board_list.vue +++ b/app/assets/javascripts/boards/components/board_list.vue @@ -227,7 +227,7 @@ export default { :class="{ 'd-none': !list.isExpanded, 'd-flex flex-column': list.isExpanded }" class="board-list-component position-relative h-100" > - <div v-if="loading" class="board-list-loading text-center" :aria-label="__(`Loading issues`)"> + <div v-if="loading" class="board-list-loading text-center" :aria-label="__('Loading issues')"> <gl-loading-icon /> </div> <board-new-issue diff --git a/app/assets/javascripts/boards/components/modal/empty_state.vue b/app/assets/javascripts/boards/components/modal/empty_state.vue index 920d2e60d9b..66f59009714 100644 --- a/app/assets/javascripts/boards/components/modal/empty_state.vue +++ b/app/assets/javascripts/boards/components/modal/empty_state.vue @@ -1,5 +1,5 @@ <script> -import { __ } from '~/locale'; +import { __, sprintf } from '~/locale'; import ModalStore from '../../stores/modal_store'; import modalMixin from '../../mixins/modal_mixins'; @@ -22,18 +22,19 @@ export default { contents() { const obj = { title: __("You haven't added any issues to your project yet"), - content: __(` - An issue can be a bug, a todo or a feature request that needs to be - discussed in a project. Besides, issues are searchable and filterable. - `), + content: __( + 'An issue can be a bug, a todo or a feature request that needs to be discussed in a project. Besides, issues are searchable and filterable.', + ), }; if (this.activeTab === 'selected') { obj.title = __("You haven't selected any issues yet"); - obj.content = ` - Go back to <strong>Open issues</strong> and select some issues - to add to your board. - `; + obj.content = sprintf( + __( + 'Go back to %{startTag}Open issues%{endTag} and select some issues to add to your board.', + ), + { startTag: '<strong>', endTag: '</strong>' }, + ); } return obj; diff --git a/app/assets/javascripts/boards/components/modal/header.vue b/app/assets/javascripts/boards/components/modal/header.vue index 2c6f5d19092..7a696035dc8 100644 --- a/app/assets/javascripts/boards/components/modal/header.vue +++ b/app/assets/javascripts/boards/components/modal/header.vue @@ -58,7 +58,7 @@ export default { type="button" class="close" data-dismiss="modal" - :aria-label="__(`Close`)" + :aria-label="__('Close')" @click="toggleModal(false)" > <span aria-hidden="true">×</span> diff --git a/app/assets/javascripts/boards/components/project_select.vue b/app/assets/javascripts/boards/components/project_select.vue index aa641689bf4..a1cf1866faf 100644 --- a/app/assets/javascripts/boards/components/project_select.vue +++ b/app/assets/javascripts/boards/components/project_select.vue @@ -95,7 +95,7 @@ export default { <div class="dropdown-menu dropdown-menu-selectable dropdown-menu-full-width"> <div class="dropdown-title">{{ __('Projects') }}</div> <div class="dropdown-input"> - <input class="dropdown-input-field" type="search" :placeholder="__(`Search projects`)" /> + <input class="dropdown-input-field" type="search" :placeholder="__('Search projects')" /> <icon name="search" class="dropdown-input-search" data-hidden="true" /> </div> <div class="dropdown-content"></div> diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 62772f7730c..9af8ed3c3b2 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -635,9 +635,6 @@ msgstr "" msgid "Add comment now" msgstr "" -msgid "Add default lists" -msgstr "" - msgid "Add email address" msgstr "" @@ -674,9 +671,6 @@ msgstr "" msgid "Add reaction" msgstr "" -msgid "Add the following default lists to your Issue Board with one click:" -msgstr "" - msgid "Add to project" msgstr "" @@ -1597,6 +1591,18 @@ msgstr "" msgid "Blog" msgstr "" +msgid "BoardBlankState|Add default lists" +msgstr "" + +msgid "BoardBlankState|Add the following default lists to your Issue Board with one click:" +msgstr "" + +msgid "BoardBlankState|Nevermind, I'll use my own" +msgstr "" + +msgid "BoardBlankState|Starting out with the default set of lists will get you right on the way to making the most of your board." +msgstr "" + msgid "Boards" msgstr "" @@ -4855,6 +4861,9 @@ msgstr "" msgid "Go back" msgstr "" +msgid "Go back to %{startTag}Open issues%{endTag} and select some issues to add to your board." +msgstr "" + msgid "Go full screen" msgstr "" @@ -6553,9 +6562,6 @@ msgstr "" msgid "Never" msgstr "" -msgid "Nevermind, I'll use my own" -msgstr "" - msgid "New" msgstr "" @@ -9758,9 +9764,6 @@ msgstr "" msgid "Started asynchronous removal of all repository check states." msgstr "" -msgid "Starting out with the default set of lists will get you right on the way to making the most of your board." -msgstr "" - msgid "Starts %{startsIn}" msgstr "" |