diff options
author | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-07-01 14:42:24 +1000 |
---|---|---|
committer | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-07-01 15:25:32 +1000 |
commit | 88b4aa5e6aaa7d34040a9470296e56d32b04d007 (patch) | |
tree | 1578b48dfa10e60bd49a92b9ebe9d36ab105a32d | |
parent | d8e62bf1bd0bb202b877a2cab34134a945ba790d (diff) | |
download | gitlab-ce-vue-i18n-various-js-directories.tar.gz |
Remove todo notesvue-i18n-various-js-directories
3 files changed, 0 insertions, 15 deletions
diff --git a/app/assets/javascripts/badges/components/badge.vue b/app/assets/javascripts/badges/components/badge.vue index d4a475b2c53..ae2916e3a3b 100644 --- a/app/assets/javascripts/badges/components/badge.vue +++ b/app/assets/javascripts/badges/components/badge.vue @@ -3,9 +3,6 @@ import Icon from '~/vue_shared/components/icon.vue'; import { GlLoadingIcon, GlTooltipDirective } from '@gitlab/ui'; export default { - // TODO: when the vue i18n rules are merged need to disable @gitlab/i18n/no-non-i18n-strings - // name: 'Badge' is a false positive: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/25 - // Vue i18n ESLint rules issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/63560 name: 'Badge', components: { Icon, diff --git a/app/assets/javascripts/error_tracking_settings/components/error_tracking_form.vue b/app/assets/javascripts/error_tracking_settings/components/error_tracking_form.vue index 66f9cbcc4cd..ef1d1e49320 100644 --- a/app/assets/javascripts/error_tracking_settings/components/error_tracking_form.vue +++ b/app/assets/javascripts/error_tracking_settings/components/error_tracking_form.vue @@ -36,18 +36,12 @@ export default { <label class="label-bold" for="error-tracking-api-host">{{ __('Sentry API URL') }}</label> <div class="row"> <div class="col-8 col-md-9 gl-pr-0"> - <!-- - TODO: when the vue i18n rules are merged need to eslint-disable vue-i18n/no-bare-attribute-strings - We do not want to translate 'placeholder="https://mysentryserver.com"' - Vue i18n ESLint rules issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/63560 - --> <gl-form-input id="error-tracking-api-host" :value="apiHost" placeholder="https://mysentryserver.com" @input="$emit('update-api-host', $event)" /> - <!-- TODO: we can re-enable with eslint-enable vue-i18n/no-bare-attribute-strings --> </div> </div> <p class="form-text text-muted"> diff --git a/app/assets/javascripts/repository/components/table/row.vue b/app/assets/javascripts/repository/components/table/row.vue index 1e369295289..3e060e9ecb6 100644 --- a/app/assets/javascripts/repository/components/table/row.vue +++ b/app/assets/javascripts/repository/components/table/row.vue @@ -110,13 +110,7 @@ export default { <component :is="linkComponent" :to="routerLinkTo" :href="url" class="str-truncated"> {{ fullPath }} </component> - <!-- - TODO: when the vue i18n rules are merged need to disable vue-i18n/no-bare-strings - We do not want to translate 'LFS' - Vue i18n ESLint rules issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/63560 - --> <gl-badge v-if="lfsOid" variant="default" class="label-lfs ml-1">LFS</gl-badge> - <!-- TODO: we can use eslint-enable vue-i18n/no-bare-strings to reenable the rule --> <template v-if="isSubmodule"> @ <gl-link href="#" class="commit-sha">{{ shortSha }}</gl-link> </template> |