summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlauraMon <lmontemayor@gitlab.com>2019-09-05 13:13:22 -0400
committerlauraMon <lmontemayor@gitlab.com>2019-09-05 15:11:19 -0400
commite39b45badd3f69a345cd5fc5d7379c94b42d5902 (patch)
treeff0d752d50c5d129310aeea160236cbfdf2c3d9e
parent696d716b8271225f745c1e5c2d35dd0c6949067a (diff)
downloadgitlab-ce-winh-fix-flaky-dashboard_spec.tar.gz
Removes unnecessary test and adds disable rulewinh-fix-flaky-dashboard_spec
-rw-r--r--spec/frontend/monitoring/components/dashboard_spec.js26
1 files changed, 4 insertions, 22 deletions
diff --git a/spec/frontend/monitoring/components/dashboard_spec.js b/spec/frontend/monitoring/components/dashboard_spec.js
index 70c8a84f75d..2a8e0240bf9 100644
--- a/spec/frontend/monitoring/components/dashboard_spec.js
+++ b/spec/frontend/monitoring/components/dashboard_spec.js
@@ -5,7 +5,7 @@ import MockAdapter from 'axios-mock-adapter';
import Dashboard from '~/monitoring/components/dashboard.vue';
import GraphGroup from '~/monitoring/components/graph_group.vue';
import EmptyState from '~/monitoring/components/empty_state.vue';
-import { timeWindows, timeWindowsKeyNames } from '~/monitoring/constants';
+import { timeWindows } from '~/monitoring/constants';
import * as types from '~/monitoring/stores/mutation_types';
import { createStore } from '~/monitoring/stores';
import axios from '~/lib/utils/axios_utils';
@@ -20,6 +20,9 @@ import MonitoringMock, {
dashboardGitResponse,
} from '../../../../spec/javascripts/monitoring/mock_data';
+/* eslint-disable no-unused-vars */
+/* eslint-disable no-undef */
+// see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32571#note_211860465
function setupComponentStore(component) {
component.$store.commit(
`monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`,
@@ -367,27 +370,6 @@ describe('Dashboard', () => {
done();
});
});
-
- it('defaults to the eight hours time window for non valid url parameters', () => {
- urlUtility.getParameterValues.mockReturnValue(['<script>alert("XSS")</script>']);
- spyOn(store, 'dispatch').and.returnValue(Promise.resolve());
-
- const wrapper = shallowMount(DashboardComponent, {
- propsData: {
- ...propsData,
- hasMetrics: true,
- showPanels: false,
- },
- store,
- sync: false,
- localVue,
- });
-
- expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/fetchData', {
- end: '<script>alert("XSS")</script>',
- start: '<script>alert("XSS")</script>',
- });
- });
});
describe('link to chart', () => {