diff options
| author | Winnie Hellmann <winnie@gitlab.com> | 2018-07-24 14:27:59 +0200 |
|---|---|---|
| committer | Winnie Hellmann <winnie@gitlab.com> | 2018-07-24 14:27:59 +0200 |
| commit | 7a870e4045c9a6228c58fe05c6348c5aef924d71 (patch) | |
| tree | 88ec97a4c252663f35b00b059a9ffad81dd6a001 | |
| parent | f6d13ef53aa50541ec0c751156424d7c49bf3322 (diff) | |
| download | gitlab-ce-winh-lint-console-tests.tar.gz | |
Enable no-console ESLint rule for testswinh-lint-console-tests
| -rw-r--r-- | spec/javascripts/.eslintrc.yml | 1 | ||||
| -rw-r--r-- | spec/javascripts/datetime_utility_spec.js | 1 | ||||
| -rw-r--r-- | spec/javascripts/pdf/page_spec.js | 2 | ||||
| -rw-r--r-- | spec/javascripts/test_bundle.js | 4 |
4 files changed, 4 insertions, 4 deletions
diff --git a/spec/javascripts/.eslintrc.yml b/spec/javascripts/.eslintrc.yml index 78e2f3b521f..5525c9f5bd0 100644 --- a/spec/javascripts/.eslintrc.yml +++ b/spec/javascripts/.eslintrc.yml @@ -30,7 +30,6 @@ rules: jasmine/no-spec-dupes: - warn - branch - no-console: off prefer-arrow-callback: off import/no-unresolved: - error diff --git a/spec/javascripts/datetime_utility_spec.js b/spec/javascripts/datetime_utility_spec.js index e224ed46d18..492171684dc 100644 --- a/spec/javascripts/datetime_utility_spec.js +++ b/spec/javascripts/datetime_utility_spec.js @@ -162,7 +162,6 @@ describe('getTimeframeWindowFrom', () => { const timeframe = datetimeUtility.getTimeframeWindowFrom(startDate, 5); expect(timeframe.length).toBe(5); timeframe.forEach((timeframeItem, index) => { - console.log(timeframeItem); expect(timeframeItem.getFullYear() === mockTimeframe[index].getFullYear()).toBe(true); expect(timeframeItem.getMonth() === mockTimeframe[index].getMonth()).toBe(true); expect(timeframeItem.getDate() === mockTimeframe[index].getDate()).toBeTruthy(); diff --git a/spec/javascripts/pdf/page_spec.js b/spec/javascripts/pdf/page_spec.js index 9c686748c10..ff1bfd7f650 100644 --- a/spec/javascripts/pdf/page_spec.js +++ b/spec/javascripts/pdf/page_spec.js @@ -30,7 +30,7 @@ describe('Page component', () => { done(); }) .catch((error) => { - console.error(error); + done.fail(error); }); }); diff --git a/spec/javascripts/test_bundle.js b/spec/javascripts/test_bundle.js index bc00fdfd73c..aaff8bcb6ad 100644 --- a/spec/javascripts/test_bundle.js +++ b/spec/javascripts/test_bundle.js @@ -1,4 +1,6 @@ -/* eslint-disable jasmine/no-global-setup, jasmine/no-unsafe-spy, no-underscore-dangle */ +/* eslint-disable + jasmine/no-global-setup, jasmine/no-unsafe-spy, no-underscore-dangle, no-console +*/ import $ from 'jquery'; import 'vendor/jasmine-jquery'; |