summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-05-17 10:25:11 +0100
committerFilipa Lacerda <filipa@gitlab.com>2018-05-17 10:25:11 +0100
commit1bf74bfd255372f17f9135ba0ce6ad9111c845d9 (patch)
treeec171662f517a4c7b9817ebecefe7f28ee8f7e58
parentf4aced6f6d7419f17fcaeacaab623edc8205baed (diff)
downloadgitlab-ce-1bf74bfd255372f17f9135ba0ce6ad9111c845d9.tar.gz
Moves string to a constant
-rw-r--r--app/assets/javascripts/pipelines/components/pipelines_table_row.vue4
-rw-r--r--app/assets/javascripts/pipelines/components/stage.vue3
-rw-r--r--app/assets/javascripts/pipelines/constants.js2
3 files changed, 6 insertions, 3 deletions
diff --git a/app/assets/javascripts/pipelines/components/pipelines_table_row.vue b/app/assets/javascripts/pipelines/components/pipelines_table_row.vue
index 41b5e418dd1..fdf8c04207f 100644
--- a/app/assets/javascripts/pipelines/components/pipelines_table_row.vue
+++ b/app/assets/javascripts/pipelines/components/pipelines_table_row.vue
@@ -9,6 +9,7 @@
import CommitComponent from '../../vue_shared/components/commit.vue';
import LoadingButton from '../../vue_shared/components/loading_button.vue';
import Icon from '../../vue_shared/components/icon.vue';
+ import { PIPELINES_TABLE } from '../constants.js'
/**
* Pipeline table row.
@@ -46,6 +47,7 @@
required: true,
},
},
+ pipelinesTable: PIPELINES_TABLE,
data() {
return {
isRetrying: false,
@@ -297,7 +299,7 @@
v-for="(stage, index) in pipeline.details.stages"
:key="index">
<pipeline-stage
- type="PIPELINES_TABLE"
+ :type="$options.pipelinesTable"
:stage="stage"
:update-dropdown="updateGraphDropdown"
/>
diff --git a/app/assets/javascripts/pipelines/components/stage.vue b/app/assets/javascripts/pipelines/components/stage.vue
index 61cf7c1b665..1e6392cf60a 100644
--- a/app/assets/javascripts/pipelines/components/stage.vue
+++ b/app/assets/javascripts/pipelines/components/stage.vue
@@ -21,6 +21,7 @@ import Icon from '../../vue_shared/components/icon.vue';
import LoadingIcon from '../../vue_shared/components/loading_icon.vue';
import JobComponent from './graph/job_component.vue';
import tooltip from '../../vue_shared/directives/tooltip';
+import { PIPELINES_TABLE } from '../constants.js'
export default {
components: {
@@ -141,7 +142,7 @@ export default {
},
pipelineActionRequestComplete() {
- if (this.type === 'PIPELINES_TABLE') {
+ if (this.type === PIPELINES_TABLE) {
// warn the table to update
eventHub.$emit('refreshPipelinesTable');
} else {
diff --git a/app/assets/javascripts/pipelines/constants.js b/app/assets/javascripts/pipelines/constants.js
index b384c7500e7..eaa11a84cb9 100644
--- a/app/assets/javascripts/pipelines/constants.js
+++ b/app/assets/javascripts/pipelines/constants.js
@@ -1,2 +1,2 @@
-// eslint-disable-next-line import/prefer-default-export
export const CANCEL_REQUEST = 'CANCEL_REQUEST';
+export const PIPELINES_TABLE = 'PIPELINES_TABLE';