diff options
author | Marin Jankovski <marin@gitlab.com> | 2019-04-23 08:15:00 +0000 |
---|---|---|
committer | Marin Jankovski <marin@gitlab.com> | 2019-04-23 08:15:00 +0000 |
commit | 27943332bfb1da21d1227c2efe527b98ced10d8b (patch) | |
tree | eed61e37c2ecf26902e3c947c2d8bdd2525c57f1 | |
parent | 48528bcd6184e3e3421bde6f114be2cc9844c1b7 (diff) | |
parent | 1492204c03eac6e3db055453e2f25f8d62e9be2a (diff) | |
download | gitlab-ce-27943332bfb1da21d1227c2efe527b98ced10d8b.tar.gz |
Merge branch 'asset-tag-fix-11-9' into '11-9-stable'
[11.9 port] Fix tagging of asset images
See merge request gitlab-org/gitlab-ce!27293
-rwxr-xr-x | scripts/build_assets_image | 19 | ||||
-rwxr-xr-x | scripts/trigger-build | 2 |
2 files changed, 12 insertions, 9 deletions
diff --git a/scripts/build_assets_image b/scripts/build_assets_image index 9afada244c8..25b6060b6c4 100755 --- a/scripts/build_assets_image +++ b/scripts/build_assets_image @@ -7,14 +7,11 @@ then fi # Generate the image name based on the project this is being run in -ASSETS_IMAGE_NAME=$(echo ${CI_PROJECT_NAME} | - awk '{ - split($1, p, "-"); - interim = sprintf("%s-assets-%s", p[1], p[2]); - sub(/-$/, "", interim); - print interim - }' -) +ASSETS_IMAGE_NAME="gitlab-assets-ce" +if [[ "${CI_PROJECT_NAME}" == "gitlab-ee" ]] +then + ASSETS_IMAGE_NAME="gitlab-assets-ee" +fi ASSETS_IMAGE_PATH=${CI_REGISTRY}/${CI_PROJECT_PATH}/${ASSETS_IMAGE_NAME} @@ -27,3 +24,9 @@ docker login -u gitlab-ci-token -p ${CI_JOB_TOKEN} ${CI_REGISTRY} docker push ${ASSETS_IMAGE_PATH}:${CI_COMMIT_REF_SLUG} docker push ${ASSETS_IMAGE_PATH}:${CI_COMMIT_SHA} +# Also tag the image with GitLab version, if running on a tag pipeline, so +# other projects can simply use that instead of computing the slug. +if [ -n "$CI_COMMIT_TAG" ]; then + docker tag ${ASSETS_IMAGE_PATH}:${CI_COMMIT_REF_SLUG} ${ASSETS_IMAGE_PATH}:${CI_COMMIT_REF_NAME} + docker push ${ASSETS_IMAGE_PATH}:${CI_COMMIT_REF_NAME} +fi diff --git a/scripts/trigger-build b/scripts/trigger-build index 9dbafffddfc..9c5fc3c76a5 100755 --- a/scripts/trigger-build +++ b/scripts/trigger-build @@ -141,7 +141,7 @@ module Trigger "GITLAB_#{edition}_VERSION" => ENV['CI_COMMIT_REF_NAME'], "GITLAB_VERSION" => ENV['CI_COMMIT_REF_NAME'], "GITLAB_TAG" => ENV['CI_COMMIT_TAG'], - "GITLAB_ASSETS_TAG" => ENV['CI_COMMIT_REF_SLUG'], + "GITLAB_ASSETS_TAG" => ENV['CI_COMMIT_TAG'] ? ENV['CI_COMMIT_REF_NAME'] : ENV['CI_COMMIT_REF_SLUG'], "#{edition}_PIPELINE" => 'true' } end |