diff options
author | David Kuri <info@davidkuri.de> | 2018-01-09 09:24:08 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-01-09 09:24:08 +0000 |
commit | 9452fd2b4818c63237c4e0172c4f7192be6b04e0 (patch) | |
tree | 1becaaa34ef5bb857330a8a5d3d4b2037954cda1 | |
parent | d2d634a9902d338b029c2b0662c24446b14bc3e0 (diff) | |
download | gitlab-ce-9452fd2b4818c63237c4e0172c4f7192be6b04e0.tar.gz |
Fixing re-ordering of an issue when dragging it to the bottom a long issue list in the board
-rw-r--r-- | app/assets/javascripts/boards/components/board_list.js | 2 | ||||
-rw-r--r-- | changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml | 5 | ||||
-rw-r--r-- | spec/javascripts/boards/board_list_spec.js | 12 |
3 files changed, 18 insertions, 1 deletions
diff --git a/app/assets/javascripts/boards/components/board_list.js b/app/assets/javascripts/boards/components/board_list.js index 84b76a6f1b1..d8cf532fe78 100644 --- a/app/assets/javascripts/boards/components/board_list.js +++ b/app/assets/javascripts/boards/components/board_list.js @@ -187,7 +187,7 @@ export default { <li class="board-list-count text-center" v-if="showCount" - data-id="-1"> + data-issue-id="-1"> <loading-icon v-show="list.loadingMore" diff --git a/changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml b/changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml new file mode 100644 index 00000000000..0ab765a43b7 --- /dev/null +++ b/changelogs/unreleased/36906-reordering-issues-to-the-bottom.yml @@ -0,0 +1,5 @@ +--- +title: "Issue board: fix for dragging an issue to the very bottom in long lists" +merge_request: 16250 +author: David Kuri +type: fixed
\ No newline at end of file diff --git a/spec/javascripts/boards/board_list_spec.js b/spec/javascripts/boards/board_list_spec.js index 7c5888b6d82..b7cc3a8813e 100644 --- a/spec/javascripts/boards/board_list_spec.js +++ b/spec/javascripts/boards/board_list_spec.js @@ -154,6 +154,18 @@ describe('Board list component', () => { }); }); + it('sets data attribute with invalid id', (done) => { + component.showCount = true; + + Vue.nextTick(() => { + expect( + component.$el.querySelector('.board-list-count').getAttribute('data-issue-id'), + ).toBe('-1'); + + done(); + }); + }); + it('shows how many more issues to load', (done) => { component.showCount = true; component.list.issuesSize = 20; |