diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-03-15 15:09:08 +0000 |
|---|---|---|
| committer | Mike Greiling <mike@pixelcog.com> | 2017-03-16 16:08:55 -0500 |
| commit | ae4f72db353a58b2a03e8af1ac7b80e291fc5fc9 (patch) | |
| tree | 4483df28485ffc0bfbd4c9c212fa40c08e1b7f09 | |
| parent | 36e89f977a6a9c649cb9c86bfe76ef6932fdd6a4 (diff) | |
| download | gitlab-ce-ae4f72db353a58b2a03e8af1ac7b80e291fc5fc9.tar.gz | |
Improvements after review
| -rw-r--r-- | doc/development/fe_guide/architecture.md | 2 | ||||
| -rw-r--r-- | doc/development/fe_guide/vue.md | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/doc/development/fe_guide/architecture.md b/doc/development/fe_guide/architecture.md index 3c79ae28c85..1d559b4b55a 100644 --- a/doc/development/fe_guide/architecture.md +++ b/doc/development/fe_guide/architecture.md @@ -1,6 +1,6 @@ # Architecture -The Frontend Architect is an expert who makes high-level frontend design choices +The Frontend Architect is an expert who makes high-level Frontend design decisions and decides on technical standards, including coding standards, and frameworks. When you are assigned a new feature that requires architectural design, diff --git a/doc/development/fe_guide/vue.md b/doc/development/fe_guide/vue.md index 5afcea007ff..9e599db749e 100644 --- a/doc/development/fe_guide/vue.md +++ b/doc/development/fe_guide/vue.md @@ -19,10 +19,9 @@ We don't want to refactor all GitLab frontend code into Vue.js, here are some gu when not to use Vue.js: - Adding or changing static information; -- Features that highly depend on jQuery events will be tricky to work with Vue.js +- Features that highly depend on jQuery will be hard to work with Vue.js - -In case of doubt reach out to one of the Frontend Architects. +As always, the Frontend Architectural Experts are available to help with any Vue or JavaScript questions. ## How to build a new feature with Vue.js |