diff options
author | Z.J. van de Weg <git@zjvandeweg.nl> | 2017-06-12 09:09:51 +0200 |
---|---|---|
committer | Z.J. van de Weg <git@zjvandeweg.nl> | 2017-06-12 12:59:36 +0200 |
commit | f20949a332cf13bb0a75d6a4290aec525db35885 (patch) | |
tree | 53d41ef367e9e261534e1fabf5e96226c86d59a3 | |
parent | 6b3f6c9f9391433783e5c920e38eecf2767b3353 (diff) | |
download | gitlab-ce-f20949a332cf13bb0a75d6a4290aec525db35885.tar.gz |
Fix etag route misses
Fixes gitlab-org/gitlab-ce#33106
-rw-r--r-- | app/models/environment.rb | 3 | ||||
-rw-r--r-- | lib/gitlab/etag_caching/store.rb | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/app/models/environment.rb b/app/models/environment.rb index 6211a5c1e63..d5b974b2d31 100644 --- a/app/models/environment.rb +++ b/app/models/environment.rb @@ -209,7 +209,8 @@ class Environment < ActiveRecord::Base def etag_cache_key Gitlab::Routing.url_helpers.namespace_project_environments_path( project.namespace, - project) + project, + format: :json) end private diff --git a/lib/gitlab/etag_caching/store.rb b/lib/gitlab/etag_caching/store.rb index 17750fe803e..072fcfc65e6 100644 --- a/lib/gitlab/etag_caching/store.rb +++ b/lib/gitlab/etag_caching/store.rb @@ -25,8 +25,8 @@ module Gitlab end def redis_key(key) - raise 'Invalid key' unless Gitlab::EtagCaching::Router.match(key) - + raise 'Invalid key' if !Rails.env.production? && !Gitlab::EtagCaching::Router.match(key) + "#{REDIS_NAMESPACE}#{key}" end end |