Removed formatRelevantDigits from text_utils.js and added it to a new file number_utils.jsenvironment-performance-improvements

Also improved code formatting

2 files changed, 34 insertions, 24 deletions

diff --git a/app/assets/javascripts/lib/utils/number_utils.js b/app/assets/javascripts/lib/utils/number_utils.js
new file mode 100644
index 00000000000..e2bf69ee52e
--- /dev/null
+++ b/app/assets/javascripts/lib/utils/number_utils.js
@@ -0,0 +1,34 @@
+/* eslint-disable import/prefer-default-export */
+
+/**
+ * Function that allows a number with an X amount of decimals
+ * to be formatted in the following fashion:
+ * * For 1 digit to the left of the decimal point and X digits to the right of it
+ * * * Show 3 digits to the right
+ * * For 2 digits to the left of the decimal point and X digits to the right of it
+ * * * Show 2 digits to the right
+*/
+export function formatRelevantDigits(number) {
+  let digitsLeft = '';
+  let relevantDigits = 0;
+  let formattedNumber = '';
+  if (!isNaN(Number(number))) {
+    digitsLeft = number.split('.')[0];
+    switch (digitsLeft.length) {
+      case 1:
+        relevantDigits = 3;
+        break;
+      case 2:
+        relevantDigits = 2;
+        break;
+      case 3:
+        relevantDigits = 1;
+        break;
+      default:
+        relevantDigits = 4;
+        break;
+    }
+    formattedNumber = Number(number).toFixed(relevantDigits);
+  }
+  return formattedNumber;
+}
diff --git a/app/assets/javascripts/lib/utils/text_utility.js b/app/assets/javascripts/lib/utils/text_utility.js
index 2b135b4f96f..2e5f8a09fc1 100644
--- a/app/assets/javascripts/lib/utils/text_utility.js
+++ b/app/assets/javascripts/lib/utils/text_utility.js
@@ -188,29 +188,5 @@ require('vendor/latinise');
     gl.text.slugify = function(str) {
       return str.trim().toLowerCase().latinise();
     };
-    gl.text.formatRelevantDigits = function(number) {
-      var digitsLeft = '';
-      var relevantDigits = 0;
-      if (isNaN(Number(number))) {
-        return 0;
-      } else {
-        digitsLeft = number.split('.')[0];
-        switch (digitsLeft.length) {
-          case 1:
-            relevantDigits = 3;
-            break;
-          case 2:
-            relevantDigits = 2;
-            break;
-          case 3:
-            relevantDigits = 1;
-            break;
-          default:
-            relevantDigits = 4;
-            break;
-        }
-        return Number(number).toFixed(relevantDigits);
-      }
-    };
   })(window);
 }).call(window);