summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/notes
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-06-18 11:44:55 +0100
committerFilipa Lacerda <filipa@gitlab.com>2018-06-18 11:44:55 +0100
commit67608c7be5b3997231789503fa0bc599cb790f7a (patch)
treef04ff6c6b42bf35bb058e690c102788237a75fbc /app/assets/javascripts/notes
parent1907738f02f42b02fa86a02aa8af747492698d66 (diff)
parenta170c587a0ee2f303908c70a942ef3f163e2ddb7 (diff)
downloadgitlab-ce-fl-update-registry-code.tar.gz
[ci skip] Merge branch 'master' into fl-update-registry-codefl-update-registry-code
* master: (68 commits) Render calendar feed inline when accessed from GitLab Make Gitaly wiki RPC's mandatory Remove the ci_job_request_with_tags_matcher Optimised paused runners to not re-query every 3s [Rails5] Set request.format for artifacts_controller [Rails5] Fix sessions_controller_spec Rails5 update Gemfile.rails5.lock [Rails5] Fix pipeline_schedules_controller_spec Fix milestones disappearing when changed on MR Harmonize theme preferences previews Resolve "Wiki git clone holder and dropdown is broken" Resolve "Update link in GitLab cluster setup form to say "see pricing"" Resolve "Misalignment in rows on comparison page" Resolve "Stop horizontal scrolling when clicking on board issue" Enable no-multi-assignment in JS files Fix ci mini graph dropdown alignment and positioning Remove additional border from the create project page Fix alert colors Enable display static for ci job dropdowns so that they dont move when window resizes Remove pointer events in favor of boundary viewport ...
Diffstat (limited to 'app/assets/javascripts/notes')
-rw-r--r--app/assets/javascripts/notes/components/noteable_discussion.vue2
-rw-r--r--app/assets/javascripts/notes/components/noteable_note.vue4
2 files changed, 3 insertions, 3 deletions
diff --git a/app/assets/javascripts/notes/components/noteable_discussion.vue b/app/assets/javascripts/notes/components/noteable_discussion.vue
index f9f5041a9f9..3f865431155 100644
--- a/app/assets/javascripts/notes/components/noteable_discussion.vue
+++ b/app/assets/javascripts/notes/components/noteable_discussion.vue
@@ -152,7 +152,7 @@ export default {
const msg = 'Are you sure you want to cancel creating this comment?';
// eslint-disable-next-line no-alert
- if (!confirm(msg)) {
+ if (!window.confirm(msg)) {
return;
}
}
diff --git a/app/assets/javascripts/notes/components/noteable_note.vue b/app/assets/javascripts/notes/components/noteable_note.vue
index ec3ee407f0a..713f93456b1 100644
--- a/app/assets/javascripts/notes/components/noteable_note.vue
+++ b/app/assets/javascripts/notes/components/noteable_note.vue
@@ -77,7 +77,7 @@ export default {
},
deleteHandler() {
// eslint-disable-next-line no-alert
- if (confirm('Are you sure you want to delete this comment?')) {
+ if (window.confirm('Are you sure you want to delete this comment?')) {
this.isDeleting = true;
this.deleteNote(this.note)
@@ -129,7 +129,7 @@ export default {
formCancelHandler(shouldConfirm, isDirty) {
if (shouldConfirm && isDirty) {
// eslint-disable-next-line no-alert
- if (!confirm('Are you sure you want to cancel editing this comment?'))
+ if (!window.confirm('Are you sure you want to cancel editing this comment?'))
return;
}
this.$refs.noteBody.resetAutoSave();