diff options
author | blackst0ne <blackst0ne.ru@gmail.com> | 2017-06-07 09:45:16 +1100 |
---|---|---|
committer | blackst0ne <blackst0ne.ru@gmail.com> | 2017-06-07 09:45:16 +1100 |
commit | a544e46bb083c27bfa2966ea67ddf97b5dc7cb08 (patch) | |
tree | 14ffd0a5844127e7a63786a5e695832cc356ab2c /app/controllers/admin/groups_controller.rb | |
parent | 71f9c43c833531fb6e2231225b74a42dea4ae00c (diff) | |
download | gitlab-ce-a544e46bb083c27bfa2966ea67ddf97b5dc7cb08.tar.gz |
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers31840-add-a-rubocop-that-forbids-redirect_to-inside-a-controller-destroy-action-without-an-explicit-status
Diffstat (limited to 'app/controllers/admin/groups_controller.rb')
-rw-r--r-- | app/controllers/admin/groups_controller.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/controllers/admin/groups_controller.rb b/app/controllers/admin/groups_controller.rb index 5a2a7c7f27b..2ce26de1768 100644 --- a/app/controllers/admin/groups_controller.rb +++ b/app/controllers/admin/groups_controller.rb @@ -56,7 +56,9 @@ class Admin::GroupsController < Admin::ApplicationController def destroy Groups::DestroyService.new(@group, current_user).async_execute - redirect_to admin_groups_path, alert: "Group '#{@group.name}' was scheduled for deletion." + redirect_to admin_groups_path, + status: 302, + alert: "Group '#{@group.name}' was scheduled for deletion." end private |