Introduce `Ci::Stage`, right now this is artificial object that is build dynamically.

1 files changed, 2 insertions, 7 deletions

diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb
index d9021a38ce3..2a537dc2a13 100644
--- a/app/models/commit_status.rb
+++ b/app/models/commit_status.rb
@@ -41,8 +41,8 @@ class CommitStatus < ActiveRecord::Base
       where("#{quoted_when} <> ? OR status <> ?", 'on_failure', 'skipped')
   end
 
-  scope :latest_ci_stages, -> { latest.ordered.includes(project: :namespace) }
-  scope :retried_ci_stages, -> { retried.ordered.includes(project: :namespace) }
+  scope :latest_ordered, -> { latest.ordered.includes(project: :namespace) }
+  scope :retried_ordered, -> { retried.ordered.includes(project: :namespace) }
 
   state_machine :status do
     event :enqueue do
@@ -117,11 +117,6 @@ class CommitStatus < ActiveRecord::Base
     name.gsub(/\d+[\s:\/\\]+\d+\s*/, '').strip
   end
 
-  def self.stages
-    # We group by stage name, but order stages by theirs' index
-    unscoped.from(all, :sg).group('stage').order('max(stage_idx)', 'stage').select('sg.stage')
-  end
-
   def failed_but_allowed?
     allow_failure? && (failed? || canceled?)
   end