diff options
author | Stan Hu <stanhu@gmail.com> | 2018-04-26 19:45:22 -0700 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-05-24 16:40:02 -0700 |
commit | 760fdd1dd31d30d5ab407a0c42e864040d79504c (patch) | |
tree | db19fdc919e7492d2cd57b83b53d91a3da6f4b7a /app/models/concerns/batch_destroy_dependent_associations.rb | |
parent | ba58a66a55e2270eb46f7429e070d16f77d25b9d (diff) | |
download | gitlab-ce-sh-batch-dependent-destroys.tar.gz |
Fix project destruction failing due to idle in transaction timeoutssh-batch-dependent-destroys
When deleting associated records, Rails loads all associations into memory
(https://github.com/rails/rails/issues/22510) before destroying them. This
can cause a surge in memory and cause destruction of objects to fail
due to idle in transaction database timeouts. This fix is inspired from
https://github.com/thisismydesign to destroy `has_many` relationships
in batches.
Closes #44610
Diffstat (limited to 'app/models/concerns/batch_destroy_dependent_associations.rb')
-rw-r--r-- | app/models/concerns/batch_destroy_dependent_associations.rb | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/app/models/concerns/batch_destroy_dependent_associations.rb b/app/models/concerns/batch_destroy_dependent_associations.rb new file mode 100644 index 00000000000..353ee2e73d0 --- /dev/null +++ b/app/models/concerns/batch_destroy_dependent_associations.rb @@ -0,0 +1,28 @@ +# Provides a way to work around Rails issue where dependent objects are all +# loaded into memory before destroyed: https://github.com/rails/rails/issues/22510. +# +# This concern allows an ActiveRecord module to destroy all its dependent +# associations in batches. The idea is borrowed from https://github.com/thisismydesign/batch_dependent_associations. +# +# The differences here with that gem: +# +# 1. We allow excluding certain associations. +# 2. We don't need to support delete_all since we can use the EachBatch concern. +module BatchDestroyDependentAssociations + extend ActiveSupport::Concern + + DEPENDENT_ASSOCIATIONS_BATCH_SIZE = 1000 + + def dependent_associations_to_destroy + self.class.reflect_on_all_associations(:has_many).select { |assoc| assoc.options[:dependent] == :destroy } + end + + def destroy_dependent_associations_in_batches(exclude: []) + dependent_associations_to_destroy.each do |association| + next if exclude.include?(association.name) + + # rubocop:disable GitlabSecurity/PublicSend + public_send(association.name).find_each(batch_size: DEPENDENT_ASSOCIATIONS_BATCH_SIZE, &:destroy) + end + end +end |