summaryrefslogtreecommitdiff
path: root/app/models/label_note.rb
diff options
context:
space:
mode:
authorJarka Košanová <jarka@gitlab.com>2019-06-28 19:09:31 +0200
committerJarka Košanová <jarka@gitlab.com>2019-07-02 13:27:03 +0200
commit4d02fb67ad942ccd910db80d57d015ec9a81a7d5 (patch)
tree98dcfe8e72db02752307be690a0ec1568a7d90b4 /app/models/label_note.rb
parent3fd4c77ee4777464af74acd0c9dda319e1d29a44 (diff)
downloadgitlab-ce-4d02fb67ad942ccd910db80d57d015ec9a81a7d5.tar.gz
Update label note to support scoped labels notesce-10609-system-notes-scoped-labels
- port of EE change
Diffstat (limited to 'app/models/label_note.rb')
-rw-r--r--app/models/label_note.rb18
1 files changed, 13 insertions, 5 deletions
diff --git a/app/models/label_note.rb b/app/models/label_note.rb
index d6814f4a948..ba5f1f82a81 100644
--- a/app/models/label_note.rb
+++ b/app/models/label_note.rb
@@ -62,19 +62,27 @@ class LabelNote < Note
end
def note_text(html: false)
- added = labels_str('added', label_refs_by_action('add', html))
- removed = labels_str('removed', label_refs_by_action('remove', html))
+ added = labels_str(label_refs_by_action('add', html), prefix: 'added', suffix: added_suffix)
+ removed = labels_str(label_refs_by_action('remove', html), prefix: removed_prefix)
[added, removed].compact.join(' and ')
end
+ def removed_prefix
+ 'removed'
+ end
+
+ def added_suffix
+ ''
+ end
+
# returns string containing added/removed labels including
# count of deleted labels:
#
# added ~1 ~2 + 1 deleted label
# added 3 deleted labels
# added ~1 ~2 labels
- def labels_str(prefix, label_refs)
+ def labels_str(label_refs, prefix: '', suffix: '')
existing_refs = label_refs.select { |ref| ref.present? }.sort
refs_str = existing_refs.empty? ? nil : existing_refs.join(' ')
@@ -84,9 +92,9 @@ class LabelNote < Note
return unless refs_str || deleted_str
label_list_str = [refs_str, deleted_str].compact.join(' + ')
- suffix = 'label'.pluralize(deleted > 0 ? deleted : existing_refs.count)
+ suffix += ' label'.pluralize(deleted > 0 ? deleted : existing_refs.count)
- "#{prefix} #{label_list_str} #{suffix}"
+ "#{prefix} #{label_list_str} #{suffix.squish}"
end
def label_refs_by_action(action, html)