diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-14 15:22:09 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-08-14 18:00:28 +0200 |
| commit | aef9f1eb9405e9bab92b15f5c99bf06eaf28a5d6 (patch) | |
| tree | 01ebae601e9df77c1b2887e0783b73b30f833b2b /app/models/project.rb | |
| parent | 21a6898b10ed75f6260e72467b9e1f839d48456c (diff) | |
| download | gitlab-ce-forks-count-cache.tar.gz | |
Cache the number of forks of a projectforks-count-cache
The number of forks of a project doesn't change very frequently and
running a COUNT(*) every time this information is requested can be quite
expensive. We also end up running such a COUNT(*) query at least twice
on the homepage of a project.
By caching this data and refreshing it when necessary we can reduce
project homepage loading times by around 60 milliseconds (based on the
timings of https://gitlab.com/gitlab-org/gitlab-ce).
Diffstat (limited to 'app/models/project.rb')
| -rw-r--r-- | app/models/project.rb | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/app/models/project.rb b/app/models/project.rb index 7010664e1c8..92ca126bafc 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -196,7 +196,6 @@ class Project < ActiveRecord::Base accepts_nested_attributes_for :import_data delegate :name, to: :owner, allow_nil: true, prefix: true - delegate :count, to: :forks, prefix: true delegate :members, to: :team, prefix: true delegate :add_user, :add_users, to: :team delegate :add_guest, :add_reporter, :add_developer, :add_master, to: :team @@ -1398,6 +1397,10 @@ class Project < ActiveRecord::Base # @deprecated cannot remove yet because it has an index with its name in elasticsearch alias_method :path_with_namespace, :full_path + def forks_count + Projects::ForksCountService.new(self).count + end + private def cross_namespace_reference?(from) |