summaryrefslogtreecommitdiff
path: root/app/services
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2023-05-02 21:19:21 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2023-05-02 21:19:21 +0000
commit90693cc231ba6e1645dc57f2a9111a7b5a5ceae0 (patch)
tree3b2cffdb40c949b2f061b7fd0f52d3214325cc17 /app/services
parentb9ce0fe1e6311105b7a748126621f9bfbe37fb2e (diff)
downloadgitlab-ce-90693cc231ba6e1645dc57f2a9111a7b5a5ceae0.tar.gz
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'app/services')
-rw-r--r--app/services/ci/job_token_scope/add_project_service.rb2
-rw-r--r--app/services/ci/job_token_scope/remove_project_service.rb2
-rw-r--r--app/services/merge_requests/after_create_service.rb1
-rw-r--r--app/services/merge_requests/base_service.rb4
4 files changed, 9 insertions, 0 deletions
diff --git a/app/services/ci/job_token_scope/add_project_service.rb b/app/services/ci/job_token_scope/add_project_service.rb
index 704aa28f8c5..8fb543a2796 100644
--- a/app/services/ci/job_token_scope/add_project_service.rb
+++ b/app/services/ci/job_token_scope/add_project_service.rb
@@ -29,3 +29,5 @@ module Ci
end
end
end
+
+Ci::JobTokenScope::AddProjectService.prepend_mod_with('Ci::JobTokenScope::AddProjectService')
diff --git a/app/services/ci/job_token_scope/remove_project_service.rb b/app/services/ci/job_token_scope/remove_project_service.rb
index 864f9318c68..d6a2defd5b9 100644
--- a/app/services/ci/job_token_scope/remove_project_service.rb
+++ b/app/services/ci/job_token_scope/remove_project_service.rb
@@ -31,3 +31,5 @@ module Ci
end
end
end
+
+Ci::JobTokenScope::RemoveProjectService.prepend_mod_with('Ci::JobTokenScope::RemoveProjectService')
diff --git a/app/services/merge_requests/after_create_service.rb b/app/services/merge_requests/after_create_service.rb
index f3b1c663fa2..f174778e12e 100644
--- a/app/services/merge_requests/after_create_service.rb
+++ b/app/services/merge_requests/after_create_service.rb
@@ -7,6 +7,7 @@ module MergeRequests
def execute(merge_request)
merge_request.ensure_merge_request_diff
+ execute_hooks(merge_request)
prepare_for_mergeability(merge_request)
prepare_merge_request(merge_request)
diff --git a/app/services/merge_requests/base_service.rb b/app/services/merge_requests/base_service.rb
index 0d59e442dce..ec8a17162ca 100644
--- a/app/services/merge_requests/base_service.rb
+++ b/app/services/merge_requests/base_service.rb
@@ -26,6 +26,10 @@ module MergeRequests
end
def execute_hooks(merge_request, action = 'open', old_rev: nil, old_associations: {})
+ # NOTE: Due to the async merge request diffs generation, we need to skip this for CreateService and execute it in
+ # AfterCreateService instead so that the webhook consumers receive the update when diffs are ready.
+ return if merge_request.skip_ensure_merge_request_diff
+
merge_data = Gitlab::Lazy.new { hook_data(merge_request, action, old_rev: old_rev, old_associations: old_associations) }
merge_request.project.execute_hooks(merge_data, :merge_request_hooks)
merge_request.project.execute_integrations(merge_data, :merge_request_hooks)