summaryrefslogtreecommitdiff
path: root/changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-11-02 11:27:01 -0700
committerStan Hu <stanhu@gmail.com>2018-11-02 12:11:30 -0700
commitdbc03ce3a9db7f8c3d29f657beccd839d515e384 (patch)
tree8149327bf0c2b970f07e6a54536db68ae3cb4bb4 /changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml
parent6f12e3929df987e49427a1355cdf35798f97da65 (diff)
downloadgitlab-ce-sh-optimize-mr-commit-sha-lookup.tar.gz
Optimize merge request refresh by using the database to check commit SHAssh-optimize-mr-commit-sha-lookup
Previously for a given merge request, we would: 1. Create the array of commit SHAs involved in the push (A) 2. Request all merge request commits and map the SHA (B) 3. Reload the diff if there were any common commits between A and B We can avoid additional database querying and overhead by checking with the database whether the merge request contains any of the commit SHAs. Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/53213
Diffstat (limited to 'changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml')
-rw-r--r--changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml5
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml b/changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml
new file mode 100644
index 00000000000..bea73f8d329
--- /dev/null
+++ b/changelogs/unreleased/sh-optimize-mr-commit-sha-lookup.yml
@@ -0,0 +1,5 @@
+---
+title: Optimize merge request refresh by using the database to check commit SHAs
+merge_request: 22731
+author:
+type: performance