diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-11-28 01:18:56 -0800 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2018-11-28 01:20:56 -0800 |
| commit | e76a676599bf5fd693d99284c8708448fea4e296 (patch) | |
| tree | 4bd62c741f9208593d4ce01feb5e59ee1bb49389 /changelogs | |
| parent | e0e813bd03e3f4d8b025093b7aae59dd692b1fdd (diff) | |
| download | gitlab-ce-e76a676599bf5fd693d99284c8708448fea4e296.tar.gz | |
Disable password autocomplete in mirror form fill
Chrome and other browsers ignore autocomplete=false and autocomplete=off
now. This causes the mirroring section to expand whenever a user clicked
"Expand" in the Repository settings.
https://developers.google.com/web/fundamentals/design-and-ux/input/forms/?hl=en
recommends using new-password as the new field to prevent automatic
filling.
It looks like we already do this in app/views/shared/_field.html.haml.
This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8477.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50812
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml b/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml new file mode 100644 index 00000000000..e42906e88f2 --- /dev/null +++ b/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml @@ -0,0 +1,5 @@ +--- +title: Disable password autocomplete in mirror form fill +merge_request: 23402 +author: +type: fixed |