summaryrefslogtreecommitdiff
path: root/config
diff options
context:
space:
mode:
authorJason Lee <huacnlee@gmail.com>2015-11-12 13:16:35 +0800
committerJason Lee <huacnlee@gmail.com>2015-11-12 13:16:35 +0800
commit1974087114f3f365d16547c8a5c3ec2e03a66104 (patch)
treebdb754d87349cb4ae7629f537ead5dff8edcebb1 /config
parentca25289b78e1b49148438831ad6bf165fa0ce56e (diff)
downloadgitlab-ce-1974087114f3f365d16547c8a5c3ec2e03a66104.tar.gz
Avoid render edit_form in each notes.
Use RJS to render edit note feature. Before: ``` Rendered projects/notes/_note.html.haml (27.9ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.7ms) Rendered projects/_md_preview.html.haml (3.9ms) Rendered projects/notes/_edit_form.html.haml (6.9ms) Rendered projects/notes/_note.html.haml (17.7ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.6ms) Rendered projects/_md_preview.html.haml (3.4ms) Rendered projects/notes/_edit_form.html.haml (7.0ms) ``` After: ``` Rendered projects/notes/_note.html.haml (13.8ms) Rendered projects/notes/_note.html.haml (7.1ms) Rendered projects/notes/_note.html.haml (9.5ms) Rendered projects/notes/_note.html.haml (8.5ms) ``` This change reduce at least 6ms * N ('N' - number of notes).
Diffstat (limited to 'config')
-rw-r--r--config/routes.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/config/routes.rb b/config/routes.rb
index 2028ea938e4..6b053124fea 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -658,7 +658,7 @@ Gitlab::Application.routes.draw do
end
end
- resources :notes, only: [:index, :create, :destroy, :update], constraints: { id: /\d+/ } do
+ resources :notes, constraints: { id: /\d+/ } do
member do
delete :delete_attachment
end