diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-06-17 00:16:40 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-06-17 00:16:40 +0000 |
commit | 35c9eaced5ac35f942cab44d92ed39f3cfa2f8dd (patch) | |
tree | 1dda894c02c06b9cc7a2310a55a9912de097ddbf /doc/development | |
parent | a2dbe2a8d84ce6d97e3a55676cea2f7054310f42 (diff) | |
download | gitlab-ce-35c9eaced5ac35f942cab44d92ed39f3cfa2f8dd.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development')
-rw-r--r-- | doc/development/i18n/proofreader.md | 2 | ||||
-rw-r--r-- | doc/development/telemetry/usage_ping.md | 6 |
2 files changed, 6 insertions, 2 deletions
diff --git a/doc/development/i18n/proofreader.md b/doc/development/i18n/proofreader.md index 4b1f7a68f7e..8c1f62330f4 100644 --- a/doc/development/i18n/proofreader.md +++ b/doc/development/i18n/proofreader.md @@ -42,7 +42,7 @@ are very appreciative of the work done by translators and proofreaders! - Estonian - Proofreaders needed. - Filipino - - Proofreaders needed. + - Andrei Jiroh Halili - [GitLab](https://gitlab.com/AJHalili2006DevPH), [Crowdin](https://crowdin.com/profile/AndreiJirohHaliliDev2006) - French - Davy Defaud - [GitLab](https://gitlab.com/DevDef), [CrowdIn](https://crowdin.com/profile/DevDef) - Galician diff --git a/doc/development/telemetry/usage_ping.md b/doc/development/telemetry/usage_ping.md index 9ead605548b..0f438e02772 100644 --- a/doc/development/telemetry/usage_ping.md +++ b/doc/development/telemetry/usage_ping.md @@ -322,7 +322,11 @@ Examples of query optimization work: When adding, changing, or updating metrics, please update the [Usage Statistics definition table](#usage-statistics-definitions). -### 5. Ask for a Telemetry Review +### 5. Add new metric to Versions Application + +Check if new metrics need to be added to the Versions Application. See `usage_data` [schema](https://gitlab.com/gitlab-services/version-gitlab-com/-/blob/master/db/schema.rb#L147) and usage data [parameters accepted](https://gitlab.com/gitlab-services/version-gitlab-com/-/blob/master/app/services/usage_ping.rb). Any metrics added under the `counts` key are saved in the `counts` column. + +### 6. Ask for a Telemetry Review On GitLab.com, we have DangerBot setup to monitor Telemetry related files and DangerBot will recommend a Telemetry review. Mention `@gitlab-org/growth/telemetry/engineers` in your MR for a review. |