summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-09-26 12:26:19 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-09-26 12:26:19 +0000
commit3ac4e9ece78216f8c25c8b4d79749bc8294f87c1 (patch)
tree40d54d3a190974a65eb3003ed3e70428bd2773f8 /doc
parent194896f4509e0a23316389b4017c84ed99fc50fd (diff)
downloadgitlab-ce-docs-fl-define-vuejs-expert-role.tar.gz
Diffstat (limited to 'doc')
-rw-r--r--doc/development/fe_guide/vue.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/doc/development/fe_guide/vue.md b/doc/development/fe_guide/vue.md
index 05db9ee9f66..ccfd465531a 100644
--- a/doc/development/fe_guide/vue.md
+++ b/doc/development/fe_guide/vue.md
@@ -222,12 +222,12 @@ The main return value of a Vue component is the rendered output. In order to tes
need to test the rendered output. [Vue][vue-test] guide's to unit test show us exactly that:
## Vue.js Expert Role
-One should apply to be a Vue.js expert by opening an MR when the MR's they create and review show:
+One should apply to be a Vue.js expert by opening an MR when the Merge Request's they create and review show:
- Deep understanding of Vue and Vuex reactivy
- Vue and Vuex code are structured according to both official and our guidelines
-- Full test coverage of a Vue and Vuex application
+- Full understanding of testing a Vue and Vuex application
- Vuex code follows the [documented pattern](./vuex.md#actions-pattern-request-and-receive-namespaces)
-- Knowledge about the existing Vue and Vuex codebase and existing reusable components
+- Knowledge about the existing Vue and Vuex applications and existing reusable components
[vue-docs]: http://vuejs.org/guide/index.html