Merge remote-tracking branch 'upstream/master' into 27377-preload-pipeline-entity27377-preload-pipeline-entity

* upstream/master: (2534 commits)
  Update VERSION to 9.3.0-pre
  Update CHANGELOG.md for 9.2.0
  removes unnecessary redundacy in usage ping doc
  Respect the typo as rubocop said
  Add a test to ensure this works on MySQL
  Change pipelines schedules help page path
  change domain to hostname in usage ping doc
  Fixes broken MySQL migration for retried
  Show password field mask while editing service settings
  Add notes for supported schedulers and cloud providers
  Move environment monitoring to environments doc
  Add docs for change of Cache/Artifact restore order"
  Avoid resource intensive login checks if password is not provided
  Change translation for 'coding' by 'desarrollo' for Spanish
  Add to docs: issues multiple assignees
  rename "Add emoji" and "Award emoji" to "Add reaction" where appropriate
  Add project and group notification settings info
  32570 Fix border-bottom for project activity tab
  Add users endpoint to frontend API class
  Rename users on mysql
  ...

2 files changed, 41 insertions, 22 deletions

diff --git a/lib/backup/database.rb b/lib/backup/database.rb
index 4016ac76348..d97e5d98229 100644
--- a/lib/backup/database.rb
+++ b/lib/backup/database.rb
@@ -80,16 +80,32 @@ module Backup
         'port'      => '--port',
         'socket'    => '--socket',
         'username'  => '--user',
-        'encoding'  => '--default-character-set'
+        'encoding'  => '--default-character-set',
+        # SSL
+        'sslkey'    => '--ssl-key',
+        'sslcert'   => '--ssl-cert',
+        'sslca'     => '--ssl-ca',
+        'sslcapath' => '--ssl-capath',
+        'sslcipher' => '--ssl-cipher'
       }
       args.map { |opt, arg| "#{arg}=#{config[opt]}" if config[opt] }.compact
     end
 
     def pg_env
-      ENV['PGUSER']     = config["username"] if config["username"]
-      ENV['PGHOST']     = config["host"] if config["host"]
-      ENV['PGPORT']     = config["port"].to_s if config["port"]
-      ENV['PGPASSWORD'] = config["password"].to_s if config["password"]
+      args = {
+        'username'  => 'PGUSER',
+        'host'      => 'PGHOST',
+        'port'      => 'PGPORT',
+        'password'  => 'PGPASSWORD',
+        # SSL
+        'sslmode'         => 'PGSSLMODE',
+        'sslkey'          => 'PGSSLKEY',
+        'sslcert'         => 'PGSSLCERT',
+        'sslrootcert'     => 'PGSSLROOTCERT',
+        'sslcrl'          => 'PGSSLCRL',
+        'sslcompression'  => 'PGSSLCOMPRESSION'
+      }
+      args.each { |opt, arg| ENV[arg] = config[opt].to_s if config[opt] }
     end
 
     def report_success(success)
diff --git a/lib/backup/manager.rb b/lib/backup/manager.rb
index 7b4476fa4db..330cd963626 100644
--- a/lib/backup/manager.rb
+++ b/lib/backup/manager.rb
@@ -15,11 +15,10 @@ module Backup
       s[:gitlab_version]     = Gitlab::VERSION
       s[:tar_version]        = tar_version
       s[:skipped]            = ENV["SKIP"]
-      tar_file = "#{s[:backup_created_at].strftime('%s_%Y_%m_%d')}#{FILE_NAME_SUFFIX}"
+      tar_file = "#{s[:backup_created_at].strftime('%s_%Y_%m_%d_')}#{s[:gitlab_version]}#{FILE_NAME_SUFFIX}"
 
-      Dir.chdir(Gitlab.config.backup.path) do
-        File.open("#{Gitlab.config.backup.path}/backup_information.yml",
-                  "w+") do |file|
+      Dir.chdir(backup_path) do
+        File.open("#{backup_path}/backup_information.yml", "w+") do |file|
           file << s.to_yaml.gsub(/^---\n/, '')
         end
 
@@ -64,9 +63,9 @@ module Backup
       $progress.print "Deleting tmp directories ... "
 
       backup_contents.each do |dir|
-        next unless File.exist?(File.join(Gitlab.config.backup.path, dir))
+        next unless File.exist?(File.join(backup_path, dir))
 
-        if FileUtils.rm_rf(File.join(Gitlab.config.backup.path, dir))
+        if FileUtils.rm_rf(File.join(backup_path, dir))
           $progress.puts "done".color(:green)
         else
           puts "deleting tmp directory '#{dir}' failed".color(:red)
@@ -83,8 +82,8 @@ module Backup
       if keep_time > 0
         removed = 0
 
-        Dir.chdir(Gitlab.config.backup.path) do
-          Dir.glob("*#{FILE_NAME_SUFFIX}").each do |file|
+        Dir.chdir(backup_path) do
+          backup_file_list.each do |file|
             next unless file =~ /(\d+)(?:_\d{4}_\d{2}_\d{2})?_gitlab_backup\.tar/
 
             timestamp = $1.to_i
@@ -107,18 +106,14 @@ module Backup
     end
 
     def unpack
-      Dir.chdir(Gitlab.config.backup.path)
+      Dir.chdir(backup_path)
 
       # check for existing backups in the backup dir
-      file_list = Dir.glob("*#{FILE_NAME_SUFFIX}")
-
-      if file_list.count == 0
-        $progress.puts "No backups found in #{Gitlab.config.backup.path}"
+      if backup_file_list.empty?
+        $progress.puts "No backups found in #{backup_path}"
         $progress.puts "Please make sure that file name ends with #{FILE_NAME_SUFFIX}"
         exit 1
-      end
-
-      if file_list.count > 1 && ENV["BACKUP"].nil?
+      elsif backup_file_list.many? && ENV["BACKUP"].nil?
         $progress.puts 'Found more than one backup, please specify which one you want to restore:'
         $progress.puts 'rake gitlab:backup:restore BACKUP=timestamp_of_backup'
         exit 1
@@ -127,7 +122,7 @@ module Backup
       tar_file = if ENV['BACKUP'].present?
                    "#{ENV['BACKUP']}#{FILE_NAME_SUFFIX}"
                  else
-                   file_list.first
+                   backup_file_list.first
                  end
 
       unless File.exist?(tar_file)
@@ -169,6 +164,14 @@ module Backup
 
     private
 
+    def backup_path
+      Gitlab.config.backup.path
+    end
+
+    def backup_file_list
+      @backup_file_list ||= Dir.glob("*#{FILE_NAME_SUFFIX}")
+    end
+
     def connect_to_remote_directory(connection_settings)
       connection = ::Fog::Storage.new(connection_settings)