diff options
| author | Oswaldo Ferreira <oswaldo@gitlab.com> | 2018-05-16 12:46:18 -0300 |
|---|---|---|
| committer | Oswaldo Ferreira <oswaldo@gitlab.com> | 2018-05-24 15:34:43 -0300 |
| commit | bb8f2520b4254c9dabe377df48e29c5f17894a1d (patch) | |
| tree | 59c0f074d6c662fd6243219e2cdfb205000e59f2 /lib/gitlab/diff/file.rb | |
| parent | ddc760a0d625706196629c061f9dfa1cd2d8402e (diff) | |
| download | gitlab-ce-45190-create-notes-diff-files.tar.gz | |
Persist truncated note diffs on a new table45190-create-notes-diff-files
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response.
With this change we solve this problem and simplify a lot fetching this piece of info.
Diffstat (limited to 'lib/gitlab/diff/file.rb')
| -rw-r--r-- | lib/gitlab/diff/file.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/gitlab/diff/file.rb b/lib/gitlab/diff/file.rb index 014854da55c..765fb0289a8 100644 --- a/lib/gitlab/diff/file.rb +++ b/lib/gitlab/diff/file.rb @@ -76,6 +76,13 @@ module Gitlab line_code(line) if line end + # Returns the raw diff content up to the given line index + def diff_hunk(diff_line) + # Adding 2 because of the @@ diff header and Enum#take should consider + # an extra line, because we're passing an index. + raw_diff.each_line.take(diff_line.index + 2).join + end + def old_sha diff_refs&.base_sha end |