summaryrefslogtreecommitdiff
path: root/spec/features/dashboard_issues_spec.rb
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2016-09-29 16:55:55 +0200
committerRémy Coutable <remy@rymai.me>2016-09-29 16:57:17 +0200
commitf3c456eda691a19b9cf1cb274901d43d15f109dc (patch)
treec28065d196d9679d7a518028eb0e3cb7b5d2b0e9 /spec/features/dashboard_issues_spec.rb
parentf525344a6a9458c9c2c0e1936800c16de1d80914 (diff)
downloadgitlab-ce-15356-filters-should-change-issue-counts.tar.gz
Small improvements thanks to Robert's feedback15356-filters-should-change-issue-counts
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/features/dashboard_issues_spec.rb')
-rw-r--r--spec/features/dashboard_issues_spec.rb18
1 files changed, 3 insertions, 15 deletions
diff --git a/spec/features/dashboard_issues_spec.rb b/spec/features/dashboard_issues_spec.rb
index 4dccf645454..9b54b5301e5 100644
--- a/spec/features/dashboard_issues_spec.rb
+++ b/spec/features/dashboard_issues_spec.rb
@@ -21,11 +21,7 @@ describe "Dashboard Issues filtering", feature: true, js: true do
click_link 'No Milestone'
- page.within '.issues-state-filters' do
- expect(page).to have_content('Open 1')
- expect(page).to have_content('Closed 0')
- expect(page).to have_content('All 1')
- end
+ expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
expect(page).to have_selector('.issue', count: 1)
end
@@ -34,11 +30,7 @@ describe "Dashboard Issues filtering", feature: true, js: true do
click_link 'Any Milestone'
- page.within '.issues-state-filters' do
- expect(page).to have_content('Open 2')
- expect(page).to have_content('Closed 0')
- expect(page).to have_content('All 2')
- end
+ expect(page).to have_issuable_counts(open: 2, closed: 0, all: 2)
expect(page).to have_selector('.issue', count: 2)
end
@@ -49,11 +41,7 @@ describe "Dashboard Issues filtering", feature: true, js: true do
click_link milestone.title
end
- page.within '.issues-state-filters' do
- expect(page).to have_content('Open 1')
- expect(page).to have_content('Closed 0')
- expect(page).to have_content('All 1')
- end
+ expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1)
expect(page).to have_selector('.issue', count: 1)
end
end