diff options
author | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-07-13 09:58:05 +0200 |
---|---|---|
committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2017-07-13 13:00:34 +0200 |
commit | 3ee48e422defaedd69946c607bd8d3672e510375 (patch) | |
tree | 55f59787d6726a1506b81c2e1335931b5fad9543 /spec/features | |
parent | 3c197e74827b99a524a70f05fb4e955a036172b5 (diff) | |
download | gitlab-ce-3ee48e422defaedd69946c607bd8d3672e510375.tar.gz |
Enable all feature flags by default in specsbvl-enable-features-in-test
Otherwise some features would go untested in non-specific contexts
I did need to disable the
`gitlab_git_diff_size_limit_increase`-feature in some specs since we
depend on diffs being expandable while the file we are testing on is
smaller than the increased limit.
Diffstat (limited to 'spec/features')
-rw-r--r-- | spec/features/merge_requests/conflicts_spec.rb | 5 | ||||
-rw-r--r-- | spec/features/projects/diffs/diff_show_spec.rb | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/spec/features/merge_requests/conflicts_spec.rb b/spec/features/merge_requests/conflicts_spec.rb index 3e01ea69122..5c0909b6a59 100644 --- a/spec/features/merge_requests/conflicts_spec.rb +++ b/spec/features/merge_requests/conflicts_spec.rb @@ -4,6 +4,11 @@ feature 'Merge request conflict resolution', js: true, feature: true do let(:user) { create(:user) } let(:project) { create(:project) } + before do + # In order to have the diffs collapsed, we need to disable the increase feature + stub_feature_flags(gitlab_git_diff_size_limit_increase: false) + end + def create_merge_request(source_branch) create(:merge_request, source_branch: source_branch, target_branch: 'conflict-start', source_project: project) do |mr| mr.mark_as_unmergeable diff --git a/spec/features/projects/diffs/diff_show_spec.rb b/spec/features/projects/diffs/diff_show_spec.rb index b528b283495..4baccb24806 100644 --- a/spec/features/projects/diffs/diff_show_spec.rb +++ b/spec/features/projects/diffs/diff_show_spec.rb @@ -110,6 +110,10 @@ feature 'Diff file viewer', :js, feature: true do context 'binary file that appears to be text in the first 1024 bytes' do before do + # The file we're visiting is smaller than 10 KB and we want it collapsed + # so we need to disable the size increase feature. + stub_feature_flags(gitlab_git_diff_size_limit_increase: false) + visit_commit('7b1cf4336b528e0f3d1d140ee50cafdbc703597c') end |