diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-23 21:10:24 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-23 21:10:24 +0000 |
commit | 5838993b5f3e2d861d9dd7c82dfeea71506b9fc2 (patch) | |
tree | caab6621fb79f06a355f802dc885982f746b544d /spec/frontend/badges | |
parent | b8d021cb606ac86f41a0ef9dacd133a9677f8414 (diff) | |
download | gitlab-ce-5838993b5f3e2d861d9dd7c82dfeea71506b9fc2.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/frontend/badges')
-rw-r--r-- | spec/frontend/badges/components/badge_form_spec.js | 6 | ||||
-rw-r--r-- | spec/frontend/badges/components/badge_list_row_spec.js | 4 | ||||
-rw-r--r-- | spec/frontend/badges/components/badge_list_spec.js | 8 | ||||
-rw-r--r-- | spec/frontend/badges/components/badge_spec.js | 12 | ||||
-rw-r--r-- | spec/frontend/badges/store/actions_spec.js | 72 |
5 files changed, 51 insertions, 51 deletions
diff --git a/spec/frontend/badges/components/badge_form_spec.js b/spec/frontend/badges/components/badge_form_spec.js index 1edc9adbfb2..34c65d51115 100644 --- a/spec/frontend/badges/components/badge_form_spec.js +++ b/spec/frontend/badges/components/badge_form_spec.js @@ -50,7 +50,7 @@ describe('BadgeForm component', () => { }); }); - const sharedSubmitTests = submitAction => { + const sharedSubmitTests = (submitAction) => { const nameSelector = '#badge-name'; const imageUrlSelector = '#badge-image-url'; const findImageUrlElement = () => vm.$el.querySelector(imageUrlSelector); @@ -65,7 +65,7 @@ describe('BadgeForm component', () => { const submitButton = vm.$el.querySelector('button[type="submit"]'); submitButton.click(); }; - const expectInvalidInput = inputElementSelector => { + const expectInvalidInput = (inputElementSelector) => { const inputElement = vm.$el.querySelector(inputElementSelector); expect(inputElement.checkValidity()).toBe(false); @@ -74,7 +74,7 @@ describe('BadgeForm component', () => { expect(feedbackElement).toBeVisible(); }; - beforeEach(done => { + beforeEach((done) => { jest.spyOn(vm, submitAction).mockReturnValue(Promise.resolve()); store.replaceState({ ...store.state, diff --git a/spec/frontend/badges/components/badge_list_row_spec.js b/spec/frontend/badges/components/badge_list_row_spec.js index 32898abb4f7..c559c979cb3 100644 --- a/spec/frontend/badges/components/badge_list_row_spec.js +++ b/spec/frontend/badges/components/badge_list_row_spec.js @@ -73,7 +73,7 @@ describe('BadgeListRow component', () => { expect(vm.editBadge).toHaveBeenCalled(); }); - it('calls updateBadgeInModal and shows modal when clicking then delete button', done => { + it('calls updateBadgeInModal and shows modal when clicking then delete button', (done) => { jest.spyOn(vm, 'updateBadgeInModal').mockImplementation(() => {}); const deleteButton = vm.$el.querySelector('.table-button-footer button:last-of-type'); @@ -88,7 +88,7 @@ describe('BadgeListRow component', () => { }); describe('for a group badge', () => { - beforeEach(done => { + beforeEach((done) => { badge.kind = GROUP_BADGE; Vue.nextTick().then(done).catch(done.fail); diff --git a/spec/frontend/badges/components/badge_list_spec.js b/spec/frontend/badges/components/badge_list_spec.js index 4b61fc6658a..da59e13e1e9 100644 --- a/spec/frontend/badges/components/badge_list_spec.js +++ b/spec/frontend/badges/components/badge_list_spec.js @@ -48,7 +48,7 @@ describe('BadgeList component', () => { expect(rows).toHaveLength(numberOfDummyBadges); }); - it('renders a message if no badges exist', done => { + it('renders a message if no badges exist', (done) => { store.state.badges = []; Vue.nextTick() @@ -59,7 +59,7 @@ describe('BadgeList component', () => { .catch(done.fail); }); - it('shows a loading icon when loading', done => { + it('shows a loading icon when loading', (done) => { store.state.isLoading = true; Vue.nextTick() @@ -73,13 +73,13 @@ describe('BadgeList component', () => { }); describe('for group badges', () => { - beforeEach(done => { + beforeEach((done) => { store.state.kind = GROUP_BADGE; Vue.nextTick().then(done).catch(done.fail); }); - it('renders a message if no badges exist', done => { + it('renders a message if no badges exist', (done) => { store.state.badges = []; Vue.nextTick() diff --git a/spec/frontend/badges/components/badge_spec.js b/spec/frontend/badges/components/badge_spec.js index 43004004fb2..990bc094d59 100644 --- a/spec/frontend/badges/components/badge_spec.js +++ b/spec/frontend/badges/components/badge_spec.js @@ -23,7 +23,7 @@ describe('Badge component', () => { const createComponent = (props, el = null) => { vm = mountComponent(Component, props, el); const { badgeImage } = findElements(); - return new Promise(resolve => { + return new Promise((resolve) => { badgeImage.addEventListener('load', resolve); // Manually dispatch load event as it is not triggered badgeImage.dispatchEvent(new Event('load')); @@ -36,7 +36,7 @@ describe('Badge component', () => { describe('watchers', () => { describe('imageUrl', () => { - it('sets isLoading and resets numRetries and hasError', done => { + it('sets isLoading and resets numRetries and hasError', (done) => { const props = { ...dummyProps }; createComponent(props) .then(() => { @@ -60,7 +60,7 @@ describe('Badge component', () => { }); describe('methods', () => { - beforeEach(done => { + beforeEach((done) => { createComponent({ ...dummyProps }) .then(done) .catch(done.fail); @@ -98,7 +98,7 @@ describe('Badge component', () => { }); describe('behavior', () => { - beforeEach(done => { + beforeEach((done) => { setFixtures('<div id="dummy-element"></div>'); createComponent({ ...dummyProps }, '#dummy-element') .then(done) @@ -116,7 +116,7 @@ describe('Badge component', () => { expect(vm.$el.querySelector('.btn-group')).toBeHidden(); }); - it('shows a loading icon when loading', done => { + it('shows a loading icon when loading', (done) => { vm.isLoading = true; Vue.nextTick() @@ -132,7 +132,7 @@ describe('Badge component', () => { .catch(done.fail); }); - it('shows an error and reload button if loading failed', done => { + it('shows an error and reload button if loading failed', (done) => { vm.hasError = true; Vue.nextTick() diff --git a/spec/frontend/badges/store/actions_spec.js b/spec/frontend/badges/store/actions_spec.js index 365520d709c..52ae29affac 100644 --- a/spec/frontend/badges/store/actions_spec.js +++ b/spec/frontend/badges/store/actions_spec.js @@ -33,7 +33,7 @@ describe('Badges store actions', () => { }); describe('requestNewBadge', () => { - it('commits REQUEST_NEW_BADGE', done => { + it('commits REQUEST_NEW_BADGE', (done) => { testAction( actions.requestNewBadge, null, @@ -46,7 +46,7 @@ describe('Badges store actions', () => { }); describe('receiveNewBadge', () => { - it('commits RECEIVE_NEW_BADGE', done => { + it('commits RECEIVE_NEW_BADGE', (done) => { const newBadge = createDummyBadge(); testAction( actions.receiveNewBadge, @@ -60,7 +60,7 @@ describe('Badges store actions', () => { }); describe('receiveNewBadgeError', () => { - it('commits RECEIVE_NEW_BADGE_ERROR', done => { + it('commits RECEIVE_NEW_BADGE_ERROR', (done) => { testAction( actions.receiveNewBadgeError, null, @@ -87,10 +87,10 @@ describe('Badges store actions', () => { }; }); - it('dispatches requestNewBadge and receiveNewBadge for successful response', done => { + it('dispatches requestNewBadge and receiveNewBadge for successful response', (done) => { const dummyResponse = createDummyBadgeResponse(); - endpointMock.replyOnce(req => { + endpointMock.replyOnce((req) => { expect(req.data).toBe( JSON.stringify({ name: 'TestBadge', @@ -114,8 +114,8 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestNewBadge and receiveNewBadgeError for error response', done => { - endpointMock.replyOnce(req => { + it('dispatches requestNewBadge and receiveNewBadgeError for error response', (done) => { + endpointMock.replyOnce((req) => { expect(req.data).toBe( JSON.stringify({ name: 'TestBadge', @@ -141,7 +141,7 @@ describe('Badges store actions', () => { }); describe('requestDeleteBadge', () => { - it('commits REQUEST_DELETE_BADGE', done => { + it('commits REQUEST_DELETE_BADGE', (done) => { testAction( actions.requestDeleteBadge, badgeId, @@ -154,7 +154,7 @@ describe('Badges store actions', () => { }); describe('receiveDeleteBadge', () => { - it('commits RECEIVE_DELETE_BADGE', done => { + it('commits RECEIVE_DELETE_BADGE', (done) => { testAction( actions.receiveDeleteBadge, badgeId, @@ -167,7 +167,7 @@ describe('Badges store actions', () => { }); describe('receiveDeleteBadgeError', () => { - it('commits RECEIVE_DELETE_BADGE_ERROR', done => { + it('commits RECEIVE_DELETE_BADGE_ERROR', (done) => { testAction( actions.receiveDeleteBadgeError, badgeId, @@ -188,7 +188,7 @@ describe('Badges store actions', () => { dispatch = jest.fn(); }); - it('dispatches requestDeleteBadge and receiveDeleteBadge for successful response', done => { + it('dispatches requestDeleteBadge and receiveDeleteBadge for successful response', (done) => { endpointMock.replyOnce(() => { expect(dispatch.mock.calls).toEqual([['requestDeleteBadge', badgeId]]); dispatch.mockClear(); @@ -204,7 +204,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestDeleteBadge and receiveDeleteBadgeError for error response', done => { + it('dispatches requestDeleteBadge and receiveDeleteBadgeError for error response', (done) => { endpointMock.replyOnce(() => { expect(dispatch.mock.calls).toEqual([['requestDeleteBadge', badgeId]]); dispatch.mockClear(); @@ -223,7 +223,7 @@ describe('Badges store actions', () => { }); describe('editBadge', () => { - it('commits START_EDITING', done => { + it('commits START_EDITING', (done) => { const dummyBadge = createDummyBadge(); testAction( actions.editBadge, @@ -237,7 +237,7 @@ describe('Badges store actions', () => { }); describe('requestLoadBadges', () => { - it('commits REQUEST_LOAD_BADGES', done => { + it('commits REQUEST_LOAD_BADGES', (done) => { const dummyData = 'this is not real data'; testAction( actions.requestLoadBadges, @@ -251,7 +251,7 @@ describe('Badges store actions', () => { }); describe('receiveLoadBadges', () => { - it('commits RECEIVE_LOAD_BADGES', done => { + it('commits RECEIVE_LOAD_BADGES', (done) => { const badges = dummyBadges; testAction( actions.receiveLoadBadges, @@ -265,7 +265,7 @@ describe('Badges store actions', () => { }); describe('receiveLoadBadgesError', () => { - it('commits RECEIVE_LOAD_BADGES_ERROR', done => { + it('commits RECEIVE_LOAD_BADGES_ERROR', (done) => { testAction( actions.receiveLoadBadgesError, null, @@ -286,7 +286,7 @@ describe('Badges store actions', () => { dispatch = jest.fn(); }); - it('dispatches requestLoadBadges and receiveLoadBadges for successful response', done => { + it('dispatches requestLoadBadges and receiveLoadBadges for successful response', (done) => { const dummyData = 'this is just some data'; const dummyReponse = [ createDummyBadgeResponse(), @@ -310,7 +310,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestLoadBadges and receiveLoadBadgesError for error response', done => { + it('dispatches requestLoadBadges and receiveLoadBadgesError for error response', (done) => { const dummyData = 'this is just some data'; endpointMock.replyOnce(() => { expect(dispatch.mock.calls).toEqual([['requestLoadBadges', dummyData]]); @@ -330,7 +330,7 @@ describe('Badges store actions', () => { }); describe('requestRenderedBadge', () => { - it('commits REQUEST_RENDERED_BADGE', done => { + it('commits REQUEST_RENDERED_BADGE', (done) => { testAction( actions.requestRenderedBadge, null, @@ -343,7 +343,7 @@ describe('Badges store actions', () => { }); describe('receiveRenderedBadge', () => { - it('commits RECEIVE_RENDERED_BADGE', done => { + it('commits RECEIVE_RENDERED_BADGE', (done) => { const dummyBadge = createDummyBadge(); testAction( actions.receiveRenderedBadge, @@ -357,7 +357,7 @@ describe('Badges store actions', () => { }); describe('receiveRenderedBadgeError', () => { - it('commits RECEIVE_RENDERED_BADGE_ERROR', done => { + it('commits RECEIVE_RENDERED_BADGE_ERROR', (done) => { testAction( actions.receiveRenderedBadgeError, null, @@ -388,7 +388,7 @@ describe('Badges store actions', () => { dispatch = jest.fn(); }); - it('returns immediately if imageUrl is empty', done => { + it('returns immediately if imageUrl is empty', (done) => { jest.spyOn(axios, 'get').mockImplementation(() => {}); badgeInForm.imageUrl = ''; @@ -401,7 +401,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('returns immediately if linkUrl is empty', done => { + it('returns immediately if linkUrl is empty', (done) => { jest.spyOn(axios, 'get').mockImplementation(() => {}); badgeInForm.linkUrl = ''; @@ -414,7 +414,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('escapes user input', done => { + it('escapes user input', (done) => { jest .spyOn(axios, 'get') .mockImplementation(() => Promise.resolve({ data: createDummyBadgeResponse() })); @@ -437,7 +437,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestRenderedBadge and receiveRenderedBadge for successful response', done => { + it('dispatches requestRenderedBadge and receiveRenderedBadge for successful response', (done) => { const dummyReponse = createDummyBadgeResponse(); endpointMock.replyOnce(() => { expect(dispatch.mock.calls).toEqual([['requestRenderedBadge']]); @@ -456,7 +456,7 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestRenderedBadge and receiveRenderedBadgeError for error response', done => { + it('dispatches requestRenderedBadge and receiveRenderedBadgeError for error response', (done) => { endpointMock.replyOnce(() => { expect(dispatch.mock.calls).toEqual([['requestRenderedBadge']]); dispatch.mockClear(); @@ -475,7 +475,7 @@ describe('Badges store actions', () => { }); describe('requestUpdatedBadge', () => { - it('commits REQUEST_UPDATED_BADGE', done => { + it('commits REQUEST_UPDATED_BADGE', (done) => { testAction( actions.requestUpdatedBadge, null, @@ -488,7 +488,7 @@ describe('Badges store actions', () => { }); describe('receiveUpdatedBadge', () => { - it('commits RECEIVE_UPDATED_BADGE', done => { + it('commits RECEIVE_UPDATED_BADGE', (done) => { const updatedBadge = createDummyBadge(); testAction( actions.receiveUpdatedBadge, @@ -502,7 +502,7 @@ describe('Badges store actions', () => { }); describe('receiveUpdatedBadgeError', () => { - it('commits RECEIVE_UPDATED_BADGE_ERROR', done => { + it('commits RECEIVE_UPDATED_BADGE_ERROR', (done) => { testAction( actions.receiveUpdatedBadgeError, null, @@ -529,10 +529,10 @@ describe('Badges store actions', () => { dispatch = jest.fn(); }); - it('dispatches requestUpdatedBadge and receiveUpdatedBadge for successful response', done => { + it('dispatches requestUpdatedBadge and receiveUpdatedBadge for successful response', (done) => { const dummyResponse = createDummyBadgeResponse(); - endpointMock.replyOnce(req => { + endpointMock.replyOnce((req) => { expect(req.data).toBe( JSON.stringify({ name: 'TestBadge', @@ -556,8 +556,8 @@ describe('Badges store actions', () => { .catch(done.fail); }); - it('dispatches requestUpdatedBadge and receiveUpdatedBadgeError for error response', done => { - endpointMock.replyOnce(req => { + it('dispatches requestUpdatedBadge and receiveUpdatedBadgeError for error response', (done) => { + endpointMock.replyOnce((req) => { expect(req.data).toBe( JSON.stringify({ name: 'TestBadge', @@ -583,7 +583,7 @@ describe('Badges store actions', () => { }); describe('stopEditing', () => { - it('commits STOP_EDITING', done => { + it('commits STOP_EDITING', (done) => { testAction( actions.stopEditing, null, @@ -596,7 +596,7 @@ describe('Badges store actions', () => { }); describe('updateBadgeInForm', () => { - it('commits UPDATE_BADGE_IN_FORM', done => { + it('commits UPDATE_BADGE_IN_FORM', (done) => { const dummyBadge = createDummyBadge(); testAction( actions.updateBadgeInForm, @@ -609,7 +609,7 @@ describe('Badges store actions', () => { }); describe('updateBadgeInModal', () => { - it('commits UPDATE_BADGE_IN_MODAL', done => { + it('commits UPDATE_BADGE_IN_MODAL', (done) => { const dummyBadge = createDummyBadge(); testAction( actions.updateBadgeInModal, |