diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-03-31 15:10:27 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-03-31 15:10:27 +0000 |
commit | 5facc34f44ce8736078127a5df174a7b52d922b4 (patch) | |
tree | b93fbe904139121e82870cc40e5ab240a97b1f08 /spec/services/ci | |
parent | ea1dcaef18edf97b3ac73892d64ebaf5eecd7f68 (diff) | |
download | gitlab-ce-5facc34f44ce8736078127a5df174a7b52d922b4.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/ci')
7 files changed, 25 insertions, 23 deletions
diff --git a/spec/services/ci/create_downstream_pipeline_service_spec.rb b/spec/services/ci/create_downstream_pipeline_service_spec.rb index 860932d4fde..dd10fb017aa 100644 --- a/spec/services/ci/create_downstream_pipeline_service_spec.rb +++ b/spec/services/ci/create_downstream_pipeline_service_spec.rb @@ -112,7 +112,7 @@ RSpec.describe Ci::CreateDownstreamPipelineService, '#execute' do it 'updates bridge status when downstream pipeline gets processed' do pipeline = service.execute(bridge) - expect(pipeline.reload).to be_pending + expect(pipeline.reload).to be_created expect(bridge.reload).to be_success end @@ -227,7 +227,7 @@ RSpec.describe Ci::CreateDownstreamPipelineService, '#execute' do it 'updates bridge status when downstream pipeline gets processed' do pipeline = service.execute(bridge) - expect(pipeline.reload).to be_pending + expect(pipeline.reload).to be_created expect(bridge.reload).to be_success end diff --git a/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb b/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb index 9cf66dfceb0..d4e9946ac46 100644 --- a/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb +++ b/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb @@ -40,6 +40,7 @@ RSpec.describe Ci::CreatePipelineService, '#execute' do it 'creates bridge job with resource group' do pipeline = create_pipeline! + Ci::InitialPipelineProcessWorker.new.perform(pipeline.id) test = pipeline.statuses.find_by(name: 'instrumentation_test') expect(pipeline).to be_created_successfully diff --git a/spec/services/ci/create_pipeline_service/needs_spec.rb b/spec/services/ci/create_pipeline_service/needs_spec.rb index a6b0a9662c9..4521067cd52 100644 --- a/spec/services/ci/create_pipeline_service/needs_spec.rb +++ b/spec/services/ci/create_pipeline_service/needs_spec.rb @@ -202,7 +202,7 @@ RSpec.describe Ci::CreatePipelineService do YAML end - it 'creates a pipeline with build_a and test_b pending; deploy_b manual' do + it 'creates a pipeline with build_a and test_b pending; deploy_b manual', :sidekiq_inline do processables = pipeline.processables build_a = processables.find { |processable| processable.name == 'build_a' } diff --git a/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb b/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb index a3818937113..5ea75c2253b 100644 --- a/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb +++ b/spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb @@ -91,6 +91,7 @@ RSpec.describe Ci::CreatePipelineService, '#execute' do it 'creates bridge job with resource group', :aggregate_failures do pipeline = create_pipeline! + Ci::InitialPipelineProcessWorker.new.perform(pipeline.id) test = pipeline.statuses.find_by(name: 'instrumentation_test') expect(pipeline).to be_created_successfully diff --git a/spec/services/ci/create_pipeline_service/rules_spec.rb b/spec/services/ci/create_pipeline_service/rules_spec.rb index e97e74c1515..66a3aa7771c 100644 --- a/spec/services/ci/create_pipeline_service/rules_spec.rb +++ b/spec/services/ci/create_pipeline_service/rules_spec.rb @@ -230,8 +230,8 @@ RSpec.describe Ci::CreatePipelineService do end context 'matching the first rule in the list' do - it 'saves a pending pipeline' do - expect(pipeline).to be_pending + it 'saves a created pipeline' do + expect(pipeline).to be_created expect(pipeline).to be_persisted end end @@ -239,8 +239,8 @@ RSpec.describe Ci::CreatePipelineService do context 'matching the last rule in the list' do let(:ref) { 'refs/heads/feature' } - it 'saves a pending pipeline' do - expect(pipeline).to be_pending + it 'saves a created pipeline' do + expect(pipeline).to be_created expect(pipeline).to be_persisted end end @@ -280,8 +280,8 @@ RSpec.describe Ci::CreatePipelineService do end context 'matching the first rule in the list' do - it 'saves a pending pipeline' do - expect(pipeline).to be_pending + it 'saves a created pipeline' do + expect(pipeline).to be_created expect(pipeline).to be_persisted end end @@ -305,8 +305,8 @@ RSpec.describe Ci::CreatePipelineService do context 'with partial match' do let(:ref) { 'refs/heads/feature' } - it 'saves a pending pipeline' do - expect(pipeline).to be_pending + it 'saves a created pipeline' do + expect(pipeline).to be_created expect(pipeline).to be_persisted end end @@ -349,8 +349,8 @@ RSpec.describe Ci::CreatePipelineService do context 'where workflow passes and the job passes' do let(:ref) { 'refs/heads/feature' } - it 'saves a pending pipeline' do - expect(pipeline).to be_pending + it 'saves a created pipeline' do + expect(pipeline).to be_created expect(pipeline).to be_persisted end end diff --git a/spec/services/ci/create_pipeline_service_spec.rb b/spec/services/ci/create_pipeline_service_spec.rb index 9fafc57a770..35f4b97df0a 100644 --- a/spec/services/ci/create_pipeline_service_spec.rb +++ b/spec/services/ci/create_pipeline_service_spec.rb @@ -63,7 +63,7 @@ RSpec.describe Ci::CreatePipelineService do expect(pipeline).to be_push expect(pipeline).to eq(project.ci_pipelines.last) expect(pipeline).to have_attributes(user: user) - expect(pipeline).to have_attributes(status: 'pending') + expect(pipeline).to have_attributes(status: 'created') expect(pipeline.iid).not_to be_nil expect(pipeline.repository_source?).to be true expect(pipeline.builds.first).to be_kind_of(Ci::Build) @@ -253,7 +253,7 @@ RSpec.describe Ci::CreatePipelineService do pipeline pipeline_on_previous_commit - expect(pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil) + expect(pipeline.reload).to have_attributes(status: 'created', auto_canceled_by_id: nil) end it 'auto cancel pending non-HEAD pipelines', :sidekiq_might_not_need_inline do @@ -263,8 +263,8 @@ RSpec.describe Ci::CreatePipelineService do expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id) end - it 'cancels running outdated pipelines', :sidekiq_might_not_need_inline do - pipeline_on_previous_commit.run + it 'cancels running outdated pipelines', :sidekiq_inline do + pipeline_on_previous_commit.reload.run head_pipeline = execute_service expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: head_pipeline.id) @@ -278,13 +278,13 @@ RSpec.describe Ci::CreatePipelineService do end it 'does not cancel pipelines from the other branches' do - pending_pipeline = execute_service( + new_pipeline = execute_service( ref: 'refs/heads/feature', after: previous_commit_sha_from_ref('feature') ) pipeline - expect(pending_pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil) + expect(new_pipeline.reload).to have_attributes(status: 'created', auto_canceled_by_id: nil) end context 'when the interruptible attribute is' do @@ -465,12 +465,12 @@ RSpec.describe Ci::CreatePipelineService do project.update!(auto_cancel_pending_pipelines: 'disabled') end - it 'does not auto cancel pending non-HEAD pipelines' do + it 'does not auto cancel created non-HEAD pipelines' do pipeline_on_previous_commit pipeline expect(pipeline_on_previous_commit.reload) - .to have_attributes(status: 'pending', auto_canceled_by_id: nil) + .to have_attributes(status: 'created', auto_canceled_by_id: nil) end end @@ -770,7 +770,7 @@ RSpec.describe Ci::CreatePipelineService do stub_ci_pipeline_yaml_file(config) end - it 'does not create a new pipeline' do + it 'does not create a new pipeline', :sidekiq_inline do result = execute_service expect(result).to be_persisted diff --git a/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb b/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb index e2bdfae27f0..0cbeaa5446b 100644 --- a/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb +++ b/spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb @@ -34,7 +34,7 @@ RSpec.describe Ci::ExternalPullRequests::CreatePipelineService do expect(subject).to eq(project.ci_pipelines.last) expect(subject.external_pull_request).to eq(pull_request) expect(subject.user).to eq(user) - expect(subject.status).to eq('pending') + expect(subject.status).to eq('created') expect(subject.ref).to eq(pull_request.source_branch) expect(subject.sha).to eq(pull_request.source_sha) expect(subject.source_sha).to eq(pull_request.source_sha) |