diff options
author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-05-26 13:38:28 +0200 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-05-27 12:24:19 +0200 |
commit | e704d220ac3d655a57e2e8cb6d0e5076227bf30f (patch) | |
tree | a5a10442eff4c194486c6e73582604aec526c90f /spec/support/webmock.rb | |
parent | 35e977d69b622e5a82be58c632ddc427d771cc09 (diff) | |
download | gitlab-ce-separate-banzai-references.tar.gz |
Refactor Participableseparate-banzai-references
There are several changes to this module:
1. The use of an explicit stack in Participable#participants
2. Proc behaviour has been changed
3. Batch permissions checking
== Explicit Stack
Participable#participants no longer uses recursion to process "self" and
all child objects, instead it uses an Array and processes objects in
breadth-first order. This allows us to for example create a single
Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
a ReferenceExtractor removes the need for running potentially many SQL
queries every time a Proc is called on a new object.
== Proc Behaviour Changed
Previously a Proc in Participable was expected to return an Array of
User instances. This has been changed and instead it's now expected that
a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
value of the Proc is ignored.
== Permissions Checking
The method Participable#participants uses
Ability.users_that_can_read_project to check if the returned users have
access to the project of "self" _without_ running multiple SQL queries
for every user.
Diffstat (limited to 'spec/support/webmock.rb')
0 files changed, 0 insertions, 0 deletions