summaryrefslogtreecommitdiff
path: root/spec/workers/repository_check
diff options
context:
space:
mode:
authorToon Claes <toon@gitlab.com>2018-04-23 12:09:38 +0200
committerToon Claes <toon@gitlab.com>2018-05-07 09:42:09 +0200
commitf70d7e4ea03f004a74c514f4edf1659329bdc9f6 (patch)
treed3beccce8faf52edfa7d5083c544f55a834b5872 /spec/workers/repository_check
parentb07c4e3dc454fb90c320b3912ef84da06cd56ddf (diff)
downloadgitlab-ce-f70d7e4ea03f004a74c514f4edf1659329bdc9f6.tar.gz
Refactor RepositoryCheck::SingleRepositoryWorker
A repo does not need pushes before it will be repo-checked. There are other sources where commits can come from (e.g. import or webIDE). In the test I made the method of breaking a repo more robust. And added a few test examples. See also gitlab-org/gitlab-ce#45046.
Diffstat (limited to 'spec/workers/repository_check')
-rw-r--r--spec/workers/repository_check/single_repository_worker_spec.rb76
1 files changed, 44 insertions, 32 deletions
diff --git a/spec/workers/repository_check/single_repository_worker_spec.rb b/spec/workers/repository_check/single_repository_worker_spec.rb
index 1d9bbf2ca62..ebd03a80826 100644
--- a/spec/workers/repository_check/single_repository_worker_spec.rb
+++ b/spec/workers/repository_check/single_repository_worker_spec.rb
@@ -2,44 +2,55 @@ require 'spec_helper'
require 'fileutils'
describe RepositoryCheck::SingleRepositoryWorker do
- subject { described_class.new }
+ subject(:worker) { described_class.new }
- it 'passes when the project has no push events' do
- project = create(:project_empty_repo, :wiki_disabled)
- project.events.destroy_all
- break_repo(project)
+ it 'skips when the project repo is empty' do
+ project = create(:project, :wiki_disabled)
- subject.perform(project.id)
+ expect(worker).not_to receive(:git_fsck)
+
+ worker.perform(project.id)
expect(project.reload.last_repository_check_failed).to eq(false)
end
- it 'fails when the project has push events and a broken repository' do
- project = create(:project_empty_repo)
- create_push_event(project)
- break_repo(project)
+ it 'succeeds when the project repo is valid' do
+ project = create(:project, :repository, :wiki_disabled)
- subject.perform(project.id)
+ expect(worker).to receive(:git_fsck).and_call_original
+
+ expect do
+ worker.perform(project.id)
+ end.to change { project.reload.last_repository_check_at }
+
+ expect(project.reload.last_repository_check_failed).to eq(false)
+ end
+
+ it 'fails when the project is not empty and a broken repository' do
+ project = create(:project, :repository)
+ break_project(project)
+
+ worker.perform(project.id)
expect(project.reload.last_repository_check_failed).to eq(true)
end
it 'fails if the wiki repository is broken' do
- project = create(:project_empty_repo, :wiki_enabled)
+ project = create(:project, :wiki_enabled)
project.create_wiki
# Test sanity: everything should be fine before the wiki repo is broken
- subject.perform(project.id)
+ worker.perform(project.id)
expect(project.reload.last_repository_check_failed).to eq(false)
break_wiki(project)
- subject.perform(project.id)
+ worker.perform(project.id)
expect(project.reload.last_repository_check_failed).to eq(true)
end
it 'skips wikis when disabled' do
- project = create(:project_empty_repo, :wiki_disabled)
+ project = create(:project, :wiki_disabled)
# Make sure the test would fail if the wiki repo was checked
break_wiki(project)
@@ -49,8 +60,8 @@ describe RepositoryCheck::SingleRepositoryWorker do
end
it 'creates missing wikis' do
- project = create(:project_empty_repo, :wiki_enabled)
- FileUtils.rm_rf(wiki_path(project))
+ project = create(:project, :wiki_enabled)
+ Gitlab::Shell.new.rm_directory(project.repository_storage_path, project.wiki.path)
subject.perform(project.id)
@@ -58,34 +69,35 @@ describe RepositoryCheck::SingleRepositoryWorker do
end
it 'does not create a wiki if the main repo does not exist at all' do
- project = create(:project_empty_repo)
- create_push_event(project)
- FileUtils.rm_rf(project.repository.path_to_repo)
- FileUtils.rm_rf(wiki_path(project))
+ project = create(:project, :repository)
+ Gitlab::Shell.new.rm_directory(project.repository_storage_path, project.path)
+ Gitlab::Shell.new.rm_directory(project.repository_storage_path, project.wiki.path)
subject.perform(project.id)
- expect(File.exist?(wiki_path(project))).to eq(false)
+ expect(Gitlab::Shell.new.exists?(project.repository_storage_path, project.wiki.path)).to eq(false)
end
def break_wiki(project)
- objects_dir = wiki_path(project) + '/objects'
-
- # Replace the /objects directory with a file so that the repo is
- # invalid, _and_ 'git init' cannot fix it.
- FileUtils.rm_rf(objects_dir)
- FileUtils.touch(objects_dir) if File.directory?(wiki_path(project))
+ break_repo(wiki_path(project))
end
def wiki_path(project)
project.wiki.repository.path_to_repo
end
- def create_push_event(project)
- project.events.create(action: Event::PUSHED, author_id: create(:user).id)
+ def break_project(project)
+ break_repo(project.repository.path_to_repo)
end
- def break_repo(project)
- FileUtils.rm_rf(File.join(project.repository.path_to_repo, 'objects'))
+ def break_repo(repo)
+ # Create or replace blob ffffffffffffffffffffffffffffffffffffffff with an empty file
+ # This will make the repo invalid, _and_ 'git init' cannot fix it.
+ path = File.join(repo, 'objects', 'ff')
+ file = File.join(path, 'ffffffffffffffffffffffffffffffffffffff')
+
+ FileUtils.mkdir_p(path)
+ FileUtils.rm_f(file)
+ FileUtils.touch(file)
end
end