diff options
author | Rémy Coutable <remy@rymai.me> | 2016-12-13 13:19:28 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-12-13 13:19:28 +0000 |
commit | 0764c2ead1cc3ee3778a24218412317ba19b5e83 (patch) | |
tree | 36fdc74eb42e635f4124d33ae5d68fa25ec9bad0 /spec | |
parent | 8f299a5825997eb279011d67565689d506bf7d66 (diff) | |
parent | 61aa90ef2089c9d840b88f14a553ef0dd49b779f (diff) | |
download | gitlab-ce-0764c2ead1cc3ee3778a24218412317ba19b5e83.tar.gz |
Merge branch 'allow-more-filenames' into 'master'
Allow all alphanumeric characters in file names
## What does this MR do?
Allow more characters in file names such as Chinese symbols.
## Why was this MR needed?
It is annoying that some files which can be uploaded using Git CLI cannot be created with the web editor.
## What are the relevant issue numbers?
fixes #20190
See merge request !8002
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/projects/files/creating_a_file_spec.rb | 44 |
1 files changed, 44 insertions, 0 deletions
diff --git a/spec/features/projects/files/creating_a_file_spec.rb b/spec/features/projects/files/creating_a_file_spec.rb new file mode 100644 index 00000000000..ae448706130 --- /dev/null +++ b/spec/features/projects/files/creating_a_file_spec.rb @@ -0,0 +1,44 @@ +require 'spec_helper' + +feature 'User wants to create a file', feature: true do + include WaitForAjax + + let(:project) { create(:project) } + let(:user) { create(:user) } + + background do + project.team << [user, :master] + login_as user + visit namespace_project_new_blob_path(project.namespace, project, project.default_branch) + end + + def submit_new_file(options) + file_name = find('#file_name') + file_name.set options[:file_name] || 'README.md' + + file_content = find('#file-content') + file_content.set options[:file_content] || 'Some content' + + click_button 'Commit Changes' + end + + scenario 'file name contains Chinese characters' do + submit_new_file(file_name: '测试.md') + expect(page).to have_content 'The file has been successfully created.' + end + + scenario 'directory name contains Chinese characters' do + submit_new_file(file_name: '中文/测试.md') + expect(page).to have_content 'The file has been successfully created.' + end + + scenario 'file name contains invalid characters' do + submit_new_file(file_name: '\\') + expect(page).to have_content 'Your changes could not be committed, because the file name can contain only' + end + + scenario 'file name contains directory traversal' do + submit_new_file(file_name: '../README.md') + expect(page).to have_content 'Your changes could not be committed, because the file name cannot include directory traversal.' + end +end |