diff options
Diffstat (limited to '.rubocop_todo')
39 files changed, 392 insertions, 777 deletions
diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index c9eed57e74d..653865e3d43 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -52,7 +52,6 @@ Cop/UserAdmin: - lib/api/entities/ci/runner_details.rb - lib/api/groups.rb - lib/api/helpers.rb - - lib/api/personal_access_tokens.rb - lib/api/users.rb - lib/api/v3/github.rb - lib/constraints/admin_constrainer.rb diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index 07d8ce12fa8..86db4e0c91f 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -7,7 +7,6 @@ Database/MultipleDatabases: - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' - 'spec/db/schema_spec.rb' - 'spec/initializers/database_config_spec.rb' - 'spec/lib/gitlab/database_spec.rb' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 92aad8b990e..0daacdfe2b1 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -41,7 +41,7 @@ Gitlab/FeatureAvailableUsage: - ee/app/helpers/ee/search_helper.rb - ee/app/helpers/ee/tree_helper.rb - ee/app/models/approval_state.rb - - ee/app/models/concerns/approvable.rb + - ee/app/models/concerns/ee/approvable.rb - ee/app/models/concerns/ee/project_security_scanners_information.rb - ee/app/models/concerns/ee/protected_ref_access.rb - ee/app/models/concerns/insights_feature.rb @@ -140,6 +140,7 @@ Gitlab/FeatureAvailableUsage: - ee/lib/ee/gitlab/tree_summary.rb - ee/lib/gitlab/alert_management.rb - ee/lib/gitlab/ci/pipeline/chain/config/content/compliance.rb + - ee/lib/gitlab/ci/project_config/compliance.rb - ee/lib/gitlab/code_owners.rb - ee/lib/gitlab/incident_management.rb - ee/lib/gitlab/path_locks_finder.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index b79402ce5bf..230ef959153 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -252,7 +252,6 @@ Gitlab/NamespacedClass: - 'app/models/notification_setting.rb' - 'app/models/oauth_access_grant.rb' - 'app/models/oauth_access_token.rb' - - 'app/models/onboarding_progress.rb' - 'app/models/out_of_context_discussion.rb' - 'app/models/pages_deployment.rb' - 'app/models/pages_domain.rb' @@ -405,6 +404,7 @@ Gitlab/NamespacedClass: - 'app/policies/project_hook_policy.rb' - 'app/policies/prometheus_alert_policy.rb' - 'app/policies/protected_branch_policy.rb' + - 'app/policies/protected_branch_access_policy.rb' - 'app/policies/release_policy.rb' - 'app/policies/repository_policy.rb' - 'app/policies/resource_label_event_policy.rb' @@ -656,7 +656,6 @@ Gitlab/NamespacedClass: - 'app/services/metrics_service.rb' - 'app/services/note_summary.rb' - 'app/services/notification_service.rb' - - 'app/services/onboarding_progress_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/push_event_payload_service.rb' @@ -852,7 +851,7 @@ Gitlab/NamespacedClass: - 'app/workers/x509_issuer_crl_check_worker.rb' - 'ee/app/controllers/countries_controller.rb' - 'ee/app/controllers/country_states_controller.rb' - - 'ee/app/controllers/omniauth_kerberos_spnego_controller.rb' + - 'ee/app/controllers/omniauth_kerberos_controller.rb' - 'ee/app/controllers/operations_controller.rb' - 'ee/app/controllers/sitemap_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 1977bedd143..bd4cd386153 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -391,7 +391,6 @@ Layout/ArgumentAlignment: - 'ee/spec/features/projects/environments/environments_spec.rb' - 'ee/spec/features/projects/merge_requests/user_edits_merge_request_spec.rb' - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - - 'ee/spec/features/uncompleted_learn_gitlab_link_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/mutations/requirements_management/export_requirements_spec.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index 84e367e0514..5207d493044 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -2,157 +2,6 @@ # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: Exclude: - - 'app/controllers/abuse_reports_controller.rb' - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - - 'app/controllers/admin/plan_limits_controller.rb' - - 'app/controllers/boards/issues_controller.rb' - - 'app/controllers/groups_controller.rb' - - 'app/controllers/projects/issues_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/controllers/projects/pipelines_controller.rb' - - 'app/controllers/projects_controller.rb' - - 'app/finders/issuable_finder.rb' - - 'app/finders/merge_requests/by_approvals_finder.rb' - - 'app/finders/user_groups_counter.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/models/ci/job_token/scope.rb' - - 'app/models/container_repository.rb' - - 'app/models/customer_relations/contact.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/group.rb' - - 'app/models/integration.rb' - - 'app/models/internal_id.rb' - - 'app/models/issue.rb' - - 'app/models/member.rb' - - 'app/models/merge_request.rb' - - 'app/models/namespace.rb' - - 'app/models/packages/package.rb' - - 'app/models/project.rb' - - 'app/models/projects/topic.rb' - - 'app/models/todo.rb' - - 'app/models/user.rb' - - 'app/services/ci/delete_objects_service.rb' - - 'app/services/labels/transfer_service.rb' - - 'app/services/milestones/transfer_service.rb' - - 'app/workers/ssh_keys/expired_notification_worker.rb' - - 'config/initializers/postgres_partitioning.rb' - - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' - - 'ee/app/controllers/groups/settings/reporting_controller.rb' - - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' - - 'ee/app/finders/geo/project_registry_finder.rb' - - 'ee/app/finders/merge_requests/by_approvers_finder.rb' - - 'ee/app/graphql/mutations/vulnerabilities/create.rb' - - 'ee/app/helpers/ee/application_settings_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' - - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/project.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/protected_environment.rb' - - 'ee/app/models/vulnerabilities/read.rb' - - 'ee/app/serializers/dashboard_environments_serializer.rb' - - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - - 'ee/app/services/vulnerabilities/create_service_base.rb' - - 'ee/lib/ee/api/helpers/award_emoji.rb' - - 'ee/lib/ee/gitlab/geo_git_access.rb' - - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - - 'ee/lib/gitlab/elastic/helper.rb' - - 'ee/lib/gitlab/sitemaps/url_extractor.rb' - - 'ee/lib/tasks/gitlab/seed/metrics.rake' - - 'ee/spec/controllers/admin/audit_log_reports_controller_spec.rb' - - 'ee/spec/controllers/admin/licenses/usage_exports_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/coverage_reports_controller_spec.rb' - - 'ee/spec/controllers/groups/security/merge_commit_reports_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - - 'ee/spec/features/boards/boards_licensed_features_spec.rb' - - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - - 'ee/spec/features/groups/group_roadmap_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - - 'ee/spec/finders/merge_requests/by_approvers_finder_spec.rb' - - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - - 'ee/spec/frontend/fixtures/dast_profiles.rb' - - 'ee/spec/frontend/fixtures/search.rb' - - 'ee/spec/graphql/mutations/incident_management/escalation_policy/create_spec.rb' - - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - - 'ee/spec/graphql/types/ci/pipeline_type_spec.rb' - - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' - - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' - - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_links_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric_spec.rb' - - 'ee/spec/lib/gitlab/vulnerabilities/parser_spec.rb' - - 'ee/spec/models/analytics/cycle_analytics/group_value_stream_spec.rb' - - 'ee/spec/models/application_setting_spec.rb' - - 'ee/spec/models/approval_state_spec.rb' - - 'ee/spec/models/burndown_spec.rb' - - 'ee/spec/models/concerns/ee/noteable_spec.rb' - - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/namespace_spec.rb' - - 'ee/spec/models/ee/release_spec.rb' - - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/namespace_setting_spec.rb' - - 'ee/spec/models/project_spec.rb' - - 'ee/spec/models/requirements_management/test_report_spec.rb' - - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' - - 'ee/spec/models/security/scan_spec.rb' - - 'ee/spec/models/security/training_provider_spec.rb' - - 'ee/spec/models/snippet_repository_spec.rb' - - 'ee/spec/policies/project_policy_spec.rb' - - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - - 'ee/spec/requests/api/experiments_spec.rb' - - 'ee/spec/requests/api/graphql/analytics/devops_adoption/enabled_namespaces_spec.rb' - - 'ee/spec/requests/api/graphql/group/epics_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb' - - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' - - 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb' - - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - - 'ee/spec/requests/api/ldap_group_links_spec.rb' - - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' - - 'ee/spec/services/audit_events/export_csv_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service_spec.rb' - - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - - 'ee/spec/services/protected_environments/base_service_spec.rb' - - 'ee/spec/services/search_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/process_scan_result_policy_service_spec.rb' - - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - - 'ee/spec/workers/geo/scheduler/scheduler_worker_spec.rb' - - 'lib/event_filter.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/email/message/in_product_marketing/team.rb' - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/import_export/base/relation_factory.rb' @@ -195,26 +44,6 @@ Layout/FirstArrayElementIndentation: - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/code_owners_with_protected_branch_and_squashed_commits_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - 'spec/controllers/concerns/send_file_upload_spec.rb' - - 'spec/controllers/graphql_controller_spec.rb' - - 'spec/controllers/projects/ci/daily_build_group_report_results_controller_spec.rb' - - 'spec/controllers/projects/ci/lints_controller_spec.rb' - - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/deprecation_toolkit_env.rb' - - 'spec/features/clusters/create_agent_spec.rb' - - 'spec/finders/bulk_imports/entities_finder_spec.rb' - - 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb' - - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' - - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - - 'spec/frontend/fixtures/search.rb' - - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' - - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - - 'spec/graphql/types/ci/runner_architecture_type_spec.rb' - - 'spec/graphql/types/ci/runner_platform_type_spec.rb' - - 'spec/graphql/types/metrics/dashboard_type_spec.rb' - - 'spec/graphql/types/packages/composer/metadatum_type_spec.rb' - 'spec/graphql/types/packages/tag_type_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/commits_helper_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 4a98bcea706..62d877624a7 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -2,388 +2,5 @@ # Cop supports --auto-correct. Layout/HashAlignment: Exclude: - - 'ee/lib/api/iterations.rb' - - 'ee/lib/api/merge_trains.rb' - - 'ee/lib/api/related_epic_links.rb' - - 'ee/lib/api/vulnerability_exports.rb' - - 'ee/lib/api/vulnerability_findings.rb' - - 'ee/lib/ee/api/helpers/groups_helpers.rb' - - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/ee/api/helpers/protected_branches_helpers.rb' - - 'ee/lib/ee/api/merge_requests.rb' - - 'ee/lib/ee/audit/project_setting_changes_auditor.rb' - - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - - 'ee/lib/ee/banzai/filter/references/epic_reference_filter.rb' - - 'ee/lib/ee/banzai/filter/references/vulnerability_reference_filter.rb' - - 'ee/lib/ee/gitlab/application_rate_limiter.rb' - - 'ee/lib/ee/gitlab/ci/pipeline/chain/validate/after_config.rb' - - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - - 'ee/lib/ee/gitlab/tracking.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/latest/commit_config.rb' - - 'ee/lib/elastic/latest/config.rb' - - 'ee/lib/elastic/latest/merge_request_config.rb' - - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' - - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'ee/lib/gitlab/auth/smartcard/ldap_certificate.rb' - - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - - 'ee/lib/gitlab/elastic/helper.rb' - - 'ee/lib/gitlab/elastic/indexer.rb' - - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' - - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - - 'ee/spec/controllers/groups/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - - 'ee/spec/factories/dependencies.rb' - - 'ee/spec/factories/projects.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - - 'ee/spec/features/projects/environments/environments_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - - 'ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/finders/merge_requests_finder_spec.rb' - - 'ee/spec/frontend/fixtures/dast_profiles.rb' - - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities/issue_links_resolver_spec.rb' - - 'ee/spec/helpers/billing_plans_helper_spec.rb' - - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/config/entry/need_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/legacy_tree_saver_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' - - 'ee/spec/lib/gitlab/insights/loader_spec.rb' - - 'ee/spec/lib/gitlab/template/custom_templates_spec.rb' - - 'ee/spec/models/application_setting_spec.rb' - - 'ee/spec/models/approval_merge_request_rule_spec.rb' - - 'ee/spec/models/member_spec.rb' - - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/protected_environments/approval_summary_spec.rb' - - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - - 'ee/spec/requests/api/deployments_spec.rb' - - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' - - 'ee/spec/requests/api/graphql/group/epics_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/api/issues_spec.rb' - - 'ee/spec/requests/api/protected_environments_spec.rb' - - 'ee/spec/requests/api/templates_spec.rb' - - 'ee/spec/requests/ee/projects/environments_controller_spec.rb' - - 'ee/spec/requests/ee/projects/service_desk_controller_spec.rb' - - 'ee/spec/requests/projects/security/dast_site_profiles_controller_spec.rb' - - 'ee/spec/requests/rack_attack_global_spec.rb' - - 'ee/spec/serializers/integrations/zentao_serializers/issue_entity_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' - - 'ee/spec/services/ci/process_pipeline_service_spec.rb' - - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' - - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - - 'ee/spec/services/status_page/unpublish_details_service_spec.rb' - - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' - - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' - - 'ee/spec/support/shared_examples/services/audit_event_logging_shared_examples.rb' - - 'ee/spec/support/shared_examples/status_page/publish_shared_examples.rb' - - 'ee/spec/support/shared_examples/status_page/reference_links_examples.rb' - - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'lib/gitlab/abuse.rb' - - 'lib/gitlab/access.rb' - - 'lib/gitlab/application_rate_limiter.rb' - - 'lib/gitlab/auth/ldap/config.rb' - - 'lib/gitlab/auth/o_auth/auth_hash.rb' - - 'lib/gitlab/auth/o_auth/provider.rb' - - 'lib/gitlab/auth/o_auth/user.rb' - - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' - - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/ansi2json/parser.rb' - - 'lib/gitlab/ci/config/entry/processable.rb' - - 'lib/gitlab/ci/jwt_v2.rb' - - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' - - 'lib/gitlab/ci/reports/security/scanner.rb' - - 'lib/gitlab/database/background_migration/health_status.rb' - - 'lib/gitlab/database/reflection.rb' - - 'lib/gitlab/diff/file_collection/compare.rb' - - 'lib/gitlab/email/attachment_uploader.rb' - - 'lib/gitlab/emoji.rb' - - 'lib/gitlab/etag_caching/middleware.rb' - - 'lib/gitlab/experimentation.rb' - - 'lib/gitlab/fogbugz_import/importer.rb' - - 'lib/gitlab/git/repository.rb' - - 'lib/gitlab/gitaly_client/commit_service.rb' - - 'lib/gitlab/gitaly_client/operation_service.rb' - - 'lib/gitlab/hook_data/project_member_builder.rb' - - 'lib/gitlab/import_export/group/legacy_tree_restorer.rb' - - 'lib/gitlab/import_export/group/relation_factory.rb' - - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - - 'lib/gitlab/import_export/members_mapper.rb' - - 'lib/gitlab/import_export/project/import_task.rb' - - 'lib/gitlab/import_export/shared.rb' - - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - - 'lib/gitlab/kubernetes.rb' - - 'lib/gitlab/marginalia/comment.rb' - - 'lib/gitlab/metrics/dashboard/stages/grafana_formatter.rb' - - 'lib/gitlab/metrics/dashboard/transformers/yml/v1/prometheus_metrics.rb' - - 'lib/gitlab/metrics/dashboard/validator/client.rb' - - 'lib/gitlab/metrics/exporter/metrics_middleware.rb' - - 'lib/gitlab/metrics/samplers/puma_sampler.rb' - - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' - - 'lib/gitlab/no_cache_headers.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' - - 'lib/gitlab/slash_commands/presenters/base.rb' - - 'lib/gitlab/template/gitignore_template.rb' - - 'lib/gitlab/visibility_level.rb' - - 'lib/product_analytics/event_params.rb' - - 'lib/sidebars/projects/menus/infrastructure_menu.rb' - - 'lib/tasks/gitlab/import_export/export.rake' - - 'lib/tasks/gitlab/import_export/import.rake' - - 'lib/tasks/tanuki_emoji.rake' - - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - - 'spec/controllers/concerns/redis_tracking_spec.rb' - - 'spec/controllers/import/bitbucket_controller_spec.rb' - - 'spec/controllers/oauth/token_info_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - - 'spec/controllers/projects/grafana_api_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' - - 'spec/controllers/projects/registry/tags_controller_spec.rb' - - 'spec/controllers/projects/service_desk_controller_spec.rb' - - 'spec/db/migration_spec.rb' - - 'spec/factories/ci/builds.rb' - - 'spec/factories/environments.rb' - - 'spec/factories/groups.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - - 'spec/features/dashboard/todos/todos_sorting_spec.rb' - - 'spec/features/jira_oauth_provider_authorize_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/profiles/active_sessions_spec.rb' - - 'spec/features/projects/badges/coverage_spec.rb' - - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - - 'spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - - 'spec/features/projects/milestones/milestones_sorting_spec.rb' - - 'spec/features/projects/new_project_spec.rb' - - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/snippets/user_creates_snippet_spec.rb' - - 'spec/features/users/email_verification_on_login_spec.rb' - - 'spec/features/users/login_spec.rb' - - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - - 'spec/finders/group_descendants_finder_spec.rb' - - 'spec/finders/group_members_finder_spec.rb' - - 'spec/finders/template_finder_spec.rb' - - 'spec/graphql/mutations/releases/update_spec.rb' - - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/group_runners_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/jobs_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/runners_resolver_spec.rb' - - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' - - 'spec/graphql/resolvers/container_repository_tags_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' - - 'spec/graphql/resolvers/work_items_resolver_spec.rb' - - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/sorting_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - - 'spec/helpers/wiki_helper_spec.rb' - - 'spec/initializers/00_rails_disable_joins_spec.rb' - - 'spec/lib/backup/gitaly_backup_spec.rb' - - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/auth/ldap/auth_hash_spec.rb' - - 'spec/lib/gitlab/auth/ldap/config_spec.rb' - - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' - - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' - - 'spec/lib/gitlab/ci/lint_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/seed/deployment_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - - 'spec/lib/gitlab/data_builder/note_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - - 'spec/lib/gitlab/diff/lines_unfolder_spec.rb' - - 'spec/lib/gitlab/diff/position_spec.rb' - - 'spec/lib/gitlab/error_tracking/processor/context_payload_processor_spec.rb' - - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' - - 'spec/lib/gitlab/etag_caching/middleware_spec.rb' - - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' - - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_sources_spec.rb' - - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - - 'spec/lib/gitlab/jira/middleware_spec.rb' - - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/validator/errors_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/validator_spec.rb' - - 'spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/action_view_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/load_balancing_spec.rb' - - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' - - 'spec/lib/gitlab/omniauth_initializer_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - - 'spec/lib/gitlab/sidekiq_death_handler_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - - 'spec/lib/gitlab/slug/environment_spec.rb' - - 'spec/lib/gitlab/tracking_spec.rb' - - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/note_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - - 'spec/lib/gitlab/utils_spec.rb' - - 'spec/lib/gitlab/word_diff/parser_spec.rb' - - 'spec/lib/marginalia_spec.rb' - - 'spec/lib/security/ci_configuration/sast_build_action_spec.rb' - - 'spec/mailers/emails/pipelines_spec.rb' - - 'spec/migrations/20210804150320_create_base_work_item_types_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/processable_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/container_registry/event_spec.rb' - - 'spec/models/deployment_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - - 'spec/models/integrations/drone_ci_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/operations/feature_flag_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/presenters/clusters/cluster_presenter_spec.rb' - - 'spec/presenters/project_presenter_spec.rb' - - 'spec/requests/api/ci/job_artifacts_spec.rb' - - 'spec/requests/api/ci/jobs_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/feature_flags_spec.rb' - - 'spec/requests/api/graphql/ci/config_spec.rb' - - 'spec/requests/api/graphql/ci/group_variables_spec.rb' - - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' - - 'spec/requests/api/graphql/ci/project_variables_spec.rb' - - 'spec/requests/api/graphql/ci/runner_spec.rb' - - 'spec/requests/api/graphql/ci/runners_spec.rb' - - 'spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - - 'spec/requests/api/graphql/query_spec.rb' - - 'spec/requests/api/groups_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/issues/get_group_issues_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/suggestions_spec.rb' - - 'spec/requests/api/unleash_spec.rb' - - 'spec/requests/git_http_spec.rb' - - 'spec/requests/oauth_tokens_spec.rb' - - 'spec/requests/openid_connect_spec.rb' - - 'spec/requests/projects/environments_controller_spec.rb' - - 'spec/requests/projects/merge_requests_discussions_spec.rb' - - 'spec/routing/project_routing_spec.rb' - - 'spec/serializers/ci/lint/job_entity_spec.rb' - - 'spec/serializers/container_repository_entity_spec.rb' - - 'spec/serializers/deployment_entity_spec.rb' - 'spec/serializers/environment_serializer_spec.rb' - - 'spec/serializers/merge_request_metrics_helper_spec.rb' - - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - - 'spec/services/ci/create_pipeline_service/tags_spec.rb' - - 'spec/services/ci/job_artifacts/create_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/deployments/link_merge_requests_service_spec.rb' - - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/event_create_service_spec.rb' - - 'spec/services/groups/import_export/import_service_spec.rb' - - 'spec/services/issuable/bulk_update_service_spec.rb' - - 'spec/services/issues/create_service_spec.rb' - - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' - - 'spec/services/notes/destroy_service_spec.rb' - - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - - 'spec/support/helpers/create_environments_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/helpers/migrations_helpers/work_item_types_helper.rb' - - 'spec/support/helpers/seed_helper.rb' - - 'spec/support/helpers/stub_object_storage.rb' - - 'spec/support/helpers/test_env.rb' - - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - - 'spec/support/shared_contexts/design_management_shared_contexts.rb' - - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - - 'spec/support/shared_examples/graphql/members_shared_examples.rb' - - 'spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support/shared_examples/routing/resource_routing_shared_examples.rb' - - 'spec/support/shared_examples/routing/wiki_routing_shared_examples.rb' - - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' - - 'spec/tooling/danger/datateam_spec.rb' - - 'spec/views/projects/tags/index.html.haml_spec.rb' - - 'spec/workers/emails_on_push_worker_spec.rb' - - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 80c0f986552..01c83d7ac5d 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -1123,7 +1123,6 @@ Layout/LineLength: - 'ee/app/controllers/concerns/ee/issuable_collections.rb' - 'ee/app/controllers/concerns/group_invite_members.rb' - 'ee/app/controllers/concerns/insights_actions.rb' - - 'ee/app/controllers/concerns/registrations/create_project.rb' - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' - 'ee/app/controllers/ee/application_controller.rb' @@ -1160,8 +1159,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/requirements_management/requirements_controller.rb' - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - - 'ee/app/controllers/registrations/groups_controller.rb' - - 'ee/app/controllers/registrations/groups_projects_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' @@ -1862,8 +1859,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/subscriptions_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/subscriptions/groups_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' @@ -1979,13 +1974,11 @@ Layout/LineLength: - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/read_only_spec.rb' - - 'ee/spec/features/registrations/combined_registration_spec.rb' - 'ee/spec/features/search/elastic/global_search_spec.rb' - 'ee/spec/features/search/elastic/project_search_spec.rb' - 'ee/spec/features/search/elastic/snippet_search_spec.rb' - 'ee/spec/features/subscriptions_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - - 'ee/spec/features/uncompleted_learn_gitlab_link_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/snapshots_finder_spec.rb' @@ -2960,8 +2953,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/projects/license_scanning_report_comparison_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/groups_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/features/epics_filtered_search_shared_examples.rb' - 'ee/spec/support/shared_examples/features/over_free_user_limit_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' @@ -3017,7 +3008,6 @@ Layout/LineLength: - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' - 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb' @@ -3675,7 +3665,6 @@ Layout/LineLength: - 'qa/qa/ee/page/project/secure/security_dashboard.rb' - 'qa/qa/ee/page/project/secure/show.rb' - 'qa/qa/ee/resource/license.rb' - - 'qa/qa/fixtures/auto_devops_rack/config.ru' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/git/repository.rb' - 'qa/qa/page/base.rb' @@ -5169,7 +5158,6 @@ Layout/LineLength: - 'spec/lib/grafana/validator_spec.rb' - 'spec/lib/kramdown/kramdown_spec.rb' - 'spec/lib/kramdown/parser/atlassian_document_format_spec.rb' - - 'spec/lib/learn_gitlab/project_spec.rb' - 'spec/lib/mattermost/command_spec.rb' - 'spec/lib/microsoft_teams/notifier_spec.rb' - 'spec/lib/object_storage/config_spec.rb' @@ -5292,7 +5280,6 @@ Layout/LineLength: - 'spec/models/ci/instance_variable_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/job_token/scope_spec.rb' - - 'spec/models/ci/namespace_mirror_spec.rb' - 'spec/models/ci/pipeline_schedule_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/processable_spec.rb' @@ -5404,7 +5391,6 @@ Layout/LineLength: - 'spec/models/namespace_statistics_spec.rb' - 'spec/models/note_spec.rb' - 'spec/models/notification_setting_spec.rb' - - 'spec/models/onboarding_progress_spec.rb' - 'spec/models/packages/composer/cache_file_spec.rb' - 'spec/models/packages/composer/metadatum_spec.rb' - 'spec/models/packages/conan/metadatum_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index c88fdf5a3b0..9359939514b 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -96,7 +96,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/namespace_statistics.rb' - 'app/models/note.rb' - 'app/models/note_diff_file.rb' - - 'app/models/onboarding_progress.rb' - 'app/models/operations/feature_flags/user_list.rb' - 'app/models/packages/build_info.rb' - 'app/models/packages/maven/metadatum.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml deleted file mode 100644 index 4fdc308eaa5..00000000000 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ /dev/null @@ -1,134 +0,0 @@ ---- -# Cop supports --auto-correct. -Layout/SpaceInsideBlockBraces: - Exclude: - - 'spec/config/settings_spec.rb' - - 'spec/controllers/admin/application_settings_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/groups/labels_controller_spec.rb' - - 'spec/controllers/groups/releases_controller_spec.rb' - - 'spec/controllers/import/manifest_controller_spec.rb' - - 'spec/controllers/projects/blame_controller_spec.rb' - - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/labels_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/controllers/projects/releases_controller_spec.rb' - - 'spec/controllers/projects/tree_controller_spec.rb' - - 'spec/controllers/registrations/welcome_controller_spec.rb' - - 'spec/controllers/snippets/notes_controller_spec.rb' - - 'spec/dependencies/omniauth_saml_spec.rb' - - 'spec/experiments/application_experiment_spec.rb' - - 'spec/factories/ci/build_trace_chunks.rb' - - 'spec/factories/ci/job_artifacts.rb' - - 'spec/factories/ci/pipeline_artifacts.rb' - - 'spec/factories/commit_statuses.rb' - - 'spec/factories/emails.rb' - - 'spec/factories/external_pull_requests.rb' - - 'spec/factories/gitlab/database/postgres_index.rb' - - 'spec/factories/packages/dependencies.rb' - - 'spec/factories/packages/package_tags.rb' - - 'spec/factories/packages/packages.rb' - - 'spec/factories/prometheus_alert.rb' - - 'spec/factories/prometheus_metrics.rb' - - 'spec/finders/ci/jobs_finder_spec.rb' - - 'spec/finders/ci/runners_finder_spec.rb' - - 'spec/finders/concerns/packages/finder_helper_spec.rb' - - 'spec/finders/container_repositories_finder_spec.rb' - - 'spec/finders/design_management/versions_finder_spec.rb' - - 'spec/finders/milestones_finder_spec.rb' - - 'spec/finders/packages/group_packages_finder_spec.rb' - - 'spec/finders/packages/npm/package_finder_spec.rb' - - 'spec/finders/projects_finder_spec.rb' - - 'spec/frontend/fixtures/api_merge_requests.rb' - - 'spec/frontend/fixtures/api_projects.rb' - - 'spec/frontend/fixtures/application_settings.rb' - - 'spec/frontend/fixtures/blob.rb' - - 'spec/frontend/fixtures/branches.rb' - - 'spec/frontend/fixtures/clusters.rb' - - 'spec/frontend/fixtures/deploy_keys.rb' - - 'spec/frontend/fixtures/groups.rb' - - 'spec/frontend/fixtures/issues.rb' - - 'spec/frontend/fixtures/jobs.rb' - - 'spec/frontend/fixtures/labels.rb' - - 'spec/frontend/fixtures/merge_requests.rb' - - 'spec/frontend/fixtures/merge_requests_diffs.rb' - - 'spec/frontend/fixtures/metrics_dashboard.rb' - - 'spec/frontend/fixtures/pipeline_schedules.rb' - - 'spec/frontend/fixtures/pipelines.rb' - - 'spec/frontend/fixtures/projects.rb' - - 'spec/frontend/fixtures/raw.rb' - - 'spec/frontend/fixtures/snippet.rb' - - 'spec/frontend/fixtures/todos.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/blob_helper_spec.rb' - - 'spec/helpers/gitlab_script_tag_helper_spec.rb' - - 'spec/helpers/issuables_helper_spec.rb' - - 'spec/helpers/projects/pipeline_helper_spec.rb' - - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - - 'spec/helpers/search_helper_spec.rb' - - 'spec/helpers/wiki_page_version_helper_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' - - 'spec/initializers/trusted_proxies_spec.rb' - - 'spec/mailers/emails/service_desk_spec.rb' - - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/confirm_support_bot_user_spec.rb' - - 'spec/migrations/reset_job_token_scope_enabled_again_spec.rb' - - 'spec/migrations/reset_job_token_scope_enabled_spec.rb' - - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - - 'spec/policies/clusters/agent_policy_spec.rb' - - 'spec/policies/group_member_policy_spec.rb' - - 'spec/policies/issue_policy_spec.rb' - - 'spec/policies/project_policy_spec.rb' - - 'spec/policies/terraform/state_policy_spec.rb' - - 'spec/policies/terraform/state_version_policy_spec.rb' - - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - - 'spec/presenters/packages/conan/package_presenter_spec.rb' - - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - - 'spec/presenters/project_presenter_spec.rb' - - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' - - 'spec/serializers/cluster_entity_spec.rb' - - 'spec/serializers/import/provider_repo_serializer_spec.rb' - - 'spec/support/helpers/cycle_analytics_helpers.rb' - - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' - - 'spec/support/shared_contexts/requests/api/conan_packages_shared_context.rb' - - 'spec/support/shared_examples/controllers/error_tracking_shared_examples.rb' - - 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb' - - 'spec/support/shared_examples/features/board_sidebar_labels_examples.rb' - - 'spec/support/shared_examples/features/snippets_shared_examples.rb' - - 'spec/support/shared_examples/features/wiki/user_views_asciidoc_page_with_includes_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/sql/set_operator_shared_examples.rb' - - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/analytics/cycle_analytics/stage_event_model_examples.rb' - - 'spec/support/shared_examples/models/concerns/has_repository_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - - 'spec/support/shared_examples/models/label_note_shared_examples.rb' - - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' - - 'spec/support/shared_examples/models/project_latest_successful_build_for_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/issues/merge_requests_count_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/support/shared_examples/requests/lfs_http_shared_examples.rb' - - 'spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb' - - 'spec/support/shared_examples/services/gitlab_projects_import_service_shared_examples.rb' - - 'spec/support/shared_examples/services/merge_request_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/tasks/gitlab/snippets_rake_spec.rb' - - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb' - - 'spec/validators/addressable_url_validator_spec.rb' - - 'spec/views/help/instance_configuration.html.haml_spec.rb' - - 'spec/views/layouts/_header_search.html.haml_spec.rb' - - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - - 'spec/workers/bulk_imports/export_request_worker_spec.rb' - - 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb' - - 'spec/workers/packages/helm/extraction_worker_spec.rb' - - 'spec/workers/pages_worker_spec.rb' - - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - - 'spec/workers/releases/manage_evidence_worker_spec.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 495b4a51e56..9e42e85cce8 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -26,7 +26,6 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/delete_orphaned_deployments.rb' - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' diff --git a/.rubocop_todo/rails/application_controller.yml b/.rubocop_todo/rails/application_controller.yml deleted file mode 100644 index d53fd3411d3..00000000000 --- a/.rubocop_todo/rails/application_controller.yml +++ /dev/null @@ -1,13 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/ApplicationController: - Exclude: - - 'app/controllers/acme_challenges_controller.rb' - - 'app/controllers/chaos_controller.rb' - - 'app/controllers/health_controller.rb' - - 'app/controllers/metrics_controller.rb' - - 'ee/app/controllers/oauth/geo_auth_controller.rb' - - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - - 'lib/gitlab/base_doorkeeper_controller.rb' - - 'lib/gitlab/request_forgery_protection.rb' - - 'spec/controllers/concerns/continue_params_spec.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 006e66ed0b2..f43ca39f47c 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -66,7 +66,7 @@ Rails/HelperInstanceVariable: - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/integrations_helper.rb' - - 'ee/app/helpers/ee/kerberos_spnego_helper.rb' + - 'ee/app/helpers/ee/kerberos_helper.rb' - 'ee/app/helpers/ee/labels_helper.rb' - 'ee/app/helpers/ee/lock_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' diff --git a/.rubocop_todo/rails/index_with.yml b/.rubocop_todo/rails/index_with.yml index 09339d3fd56..d8ccbd97f7c 100644 --- a/.rubocop_todo/rails/index_with.yml +++ b/.rubocop_todo/rails/index_with.yml @@ -43,7 +43,6 @@ Rails/IndexWith: - 'spec/lib/gitlab/import_export/model_configuration_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' - - 'spec/lib/learn_gitlab/onboarding_spec.rb' - 'spec/models/event_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - 'spec/support/database/multiple_databases.rb' diff --git a/.rubocop_todo/rails/squished_sql_heredocs.yml b/.rubocop_todo/rails/squished_sql_heredocs.yml index 3696f661893..9dcb989f571 100644 --- a/.rubocop_todo/rails/squished_sql_heredocs.yml +++ b/.rubocop_todo/rails/squished_sql_heredocs.yml @@ -136,7 +136,6 @@ Rails/SquishedSQLHeredocs: - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' diff --git a/.rubocop_todo/rails/where_exists.yml b/.rubocop_todo/rails/where_exists.yml index 00ff82d137e..77722549722 100644 --- a/.rubocop_todo/rails/where_exists.yml +++ b/.rubocop_todo/rails/where_exists.yml @@ -19,7 +19,6 @@ Rails/WhereExists: - 'app/models/lfs_object.rb' - 'app/models/merge_request_diff.rb' - 'app/models/namespace.rb' - - 'app/models/onboarding_progress.rb' - 'app/models/project.rb' - 'app/models/protected_branch/push_access_level.rb' - 'app/services/projects/transfer_service.rb' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 2cc2478e530..e7855e84b28 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -73,7 +73,7 @@ RSpec/AnyInstanceOf: - ee/spec/requests/api/projects_spec.rb - ee/spec/requests/git_http_spec.rb - ee/spec/requests/groups_controller_spec.rb - - ee/spec/requests/omniauth_kerberos_spnego_spec.rb + - ee/spec/requests/omniauth_kerberos_spec.rb - ee/spec/requests/repositories/git_http_controller_spec.rb - ee/spec/services/ee/git/branch_push_service_spec.rb - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 163533621a6..97480a0e0ba 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -64,7 +64,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/projects/settings/repository_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' - 'ee/spec/controllers/security/dashboard_controller_spec.rb' @@ -921,8 +920,6 @@ RSpec/ContextWording: - 'ee/spec/support/shared_examples/controllers/boards_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/groups_controller_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/features/insights_shared_examples.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' @@ -968,7 +965,6 @@ RSpec/ContextWording: - 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - - 'ee/spec/views/registrations/groups/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/search/_category.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' @@ -2470,7 +2466,6 @@ RSpec/ContextWording: - 'spec/models/note_spec.rb' - 'spec/models/notification_recipient_spec.rb' - 'spec/models/notification_setting_spec.rb' - - 'spec/models/onboarding_progress_spec.rb' - 'spec/models/operations/feature_flag_spec.rb' - 'spec/models/packages/conan/file_metadatum_spec.rb' - 'spec/models/packages/debian/file_metadatum_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml new file mode 100644 index 00000000000..8304704985b --- /dev/null +++ b/.rubocop_todo/rspec/described_class.yml @@ -0,0 +1,282 @@ +--- +# Cop supports --auto-correct. +RSpec/DescribedClass: + Exclude: + - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' + - 'ee/spec/controllers/concerns/routable_actions_spec.rb' + - 'ee/spec/controllers/repositories/git_http_controller_spec.rb' + - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' + - 'ee/spec/lib/gitlab/auth/saml/config_spec.rb' + - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' + - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' + - 'ee/spec/lib/gitlab/geo_spec.rb' + - 'ee/spec/lib/gitlab/gl_repository/repo_type_spec.rb' + - 'ee/spec/lib/gitlab/instrumentation/elasticsearch_transport_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/findings_preloader_spec.rb' + - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' + - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' + - 'ee/spec/models/ci/processable_spec.rb' + - 'ee/spec/models/concerns/elastic/issue_spec.rb' + - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' + - 'ee/spec/models/concerns/elastic/note_spec.rb' + - 'ee/spec/models/concerns/elastic/project_spec.rb' + - 'ee/spec/models/concerns/elastic/repository_spec.rb' + - 'ee/spec/models/concerns/elastic/snippet_spec.rb' + - 'ee/spec/models/dast_scanner_profile_spec.rb' + - 'ee/spec/models/dast_site_profile_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' + - 'ee/spec/models/ee/ci/pending_build_spec.rb' + - 'ee/spec/models/ee/ci/runner_spec.rb' + - 'ee/spec/models/ee/gpg_key_spec.rb' + - 'ee/spec/models/ee/group_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/merge_request_diff_spec.rb' + - 'ee/spec/models/ee/namespace/storage/notification_spec.rb' + - 'ee/spec/models/ee/vulnerability_spec.rb' + - 'ee/spec/models/epic_issue_spec.rb' + - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/geo/container_repository_registry_spec.rb' + - 'ee/spec/models/geo/design_registry_spec.rb' + - 'ee/spec/models/geo/package_file_registry_spec.rb' + - 'ee/spec/models/geo/project_registry_spec.rb' + - 'ee/spec/models/geo/secondary_usage_data_spec.rb' + - 'ee/spec/models/incident_management/escalation_policy_spec.rb' + - 'ee/spec/models/issuable_metric_image_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' + - 'ee/spec/models/plan_spec.rb' + - 'ee/spec/models/project_import_state_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/release_highlight_spec.rb' + - 'ee/spec/models/requirements_management/requirement_spec.rb' + - 'ee/spec/models/requirements_management/test_report_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/uploads/local_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/models/vulnerabilities/flag_spec.rb' + - 'ee/spec/models/vulnerabilities/read_spec.rb' + - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' + - 'ee/spec/services/arkose/user_verification_service_spec.rb' + - 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb' + - 'ee/spec/services/ee/users/reject_service_spec.rb' + - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' + - 'ee/spec/services/users/captcha_challenge_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' + - 'ee/spec/workers/elastic/migration_worker_spec.rb' + - 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb' + - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' + - 'qa/spec/service/docker_run/base_spec.rb' + - 'qa/spec/support/formatters/test_stats_formatter_spec.rb' + - 'qa/spec/support/loglinking_spec.rb' + - 'qa/spec/support/page_error_checker_spec.rb' + - 'spec/config/settings_spec.rb' + - 'spec/controllers/concerns/confirm_email_warning_spec.rb' + - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' + - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' + - 'spec/controllers/concerns/graceful_timeout_handling_spec.rb' + - 'spec/controllers/concerns/group_tree_spec.rb' + - 'spec/controllers/concerns/metrics_dashboard_spec.rb' + - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' + - 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb' + - 'spec/controllers/concerns/redis_tracking_spec.rb' + - 'spec/controllers/concerns/renders_commits_spec.rb' + - 'spec/controllers/concerns/routable_actions_spec.rb' + - 'spec/controllers/concerns/sourcegraph_decorator_spec.rb' + - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' + - 'spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb' + - 'spec/controllers/concerns/static_object_external_storage_spec.rb' + - 'spec/controllers/repositories/git_http_controller_spec.rb' + - 'spec/experiments/application_experiment_spec.rb' + - 'spec/experiments/concerns/project_commit_count_spec.rb' + - 'spec/frontend/fixtures/metrics_dashboard.rb' + - 'spec/frontend/fixtures/timezones.rb' + - 'spec/frontend/fixtures/u2f.rb' + - 'spec/frontend/fixtures/webauthn.rb' + - 'spec/graphql/gitlab_schema_spec.rb' + - 'spec/graphql/graphql_triggers_spec.rb' + - 'spec/graphql/types/global_id_type_spec.rb' + - 'spec/initializers/google_api_client_spec.rb' + - 'spec/lib/api/entities/project_spec.rb' + - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' + - 'spec/lib/expand_variables_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/application_context_spec.rb' + - 'spec/lib/gitlab/asciidoc/html5_converter_spec.rb' + - 'spec/lib/gitlab/buffered_io_spec.rb' + - 'spec/lib/gitlab/checks/snippet_check_spec.rb' + - 'spec/lib/gitlab/ci/tags/bulk_insert_spec.rb' + - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection/item_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection/sort_spec.rb' + - 'spec/lib/gitlab/ci/variables/collection_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/config/entry/composable_array_spec.rb' + - 'spec/lib/gitlab/config/entry/composable_hash_spec.rb' + - 'spec/lib/gitlab/current_settings_spec.rb' + - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/host_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/primary_host_spec.rb' + - 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb' + - 'spec/lib/gitlab/database/reindexing_spec.rb' + - 'spec/lib/gitlab/database/similarity_score_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/email/handler_spec.rb' + - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' + - 'spec/lib/gitlab/encrypted_configuration_spec.rb' + - 'spec/lib/gitlab/error_tracking/logger_spec.rb' + - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' + - 'spec/lib/gitlab/git/blame_spec.rb' + - 'spec/lib/gitlab/git/blob_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/compare_spec.rb' + - 'spec/lib/gitlab/git/diff_collection_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/lib/gitlab/git_access_snippet_spec.rb' + - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' + - 'spec/lib/gitlab/import_formatter_spec.rb' + - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' + - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' + - 'spec/lib/gitlab/no_cache_headers_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' + - 'spec/lib/gitlab/relative_positioning/range_spec.rb' + - 'spec/lib/gitlab/runtime_spec.rb' + - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' + - 'spec/lib/gitlab/seeder_spec.rb' + - 'spec/lib/gitlab/serverless/service_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' + - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' + - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' + - 'spec/lib/gitlab/utils/measuring_spec.rb' + - 'spec/lib/gitlab/webpack/file_loader_spec.rb' + - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/gitlab/x509/commit_spec.rb' + - 'spec/lib/gitlab/x509/signature_spec.rb' + - 'spec/lib/peek/views/active_record_spec.rb' + - 'spec/lib/service_ping/devops_report_spec.rb' + - 'spec/lib/sidebars/panel_spec.rb' + - 'spec/mailers/emails/service_desk_spec.rb' + - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb' + - 'spec/models/active_session_spec.rb' + - 'spec/models/alert_management/alert_spec.rb' + - 'spec/models/application_record_spec.rb' + - 'spec/models/application_setting_spec.rb' + - 'spec/models/awareness_session_spec.rb' + - 'spec/models/broadcast_message_spec.rb' + - 'spec/models/chat_name_spec.rb' + - 'spec/models/ci/build_runner_session_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/group_variable_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/namespace_mirror_spec.rb' + - 'spec/models/ci/pipeline_artifact_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/processable_spec.rb' + - 'spec/models/ci/ref_spec.rb' + - 'spec/models/ci/variable_spec.rb' + - 'spec/models/ci_platform_metric_spec.rb' + - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/commit_status_spec.rb' + - 'spec/models/concerns/blocks_unsafe_serialization_spec.rb' + - 'spec/models/concerns/bulk_insertable_associations_spec.rb' + - 'spec/models/concerns/counter_attribute_spec.rb' + - 'spec/models/concerns/has_user_type_spec.rb' + - 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb' + - 'spec/models/concerns/integrations/reset_secret_fields_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/mentionable_spec.rb' + - 'spec/models/concerns/resolvable_note_spec.rb' + - 'spec/models/concerns/token_authenticatable_spec.rb' + - 'spec/models/customer_relations/contact_spec.rb' + - 'spec/models/customer_relations/organization_spec.rb' + - 'spec/models/dependency_proxy/manifest_spec.rb' + - 'spec/models/deployment_spec.rb' + - 'spec/models/experiment_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/import_failure_spec.rb' + - 'spec/models/integration_spec.rb' + - 'spec/models/internal_id_spec.rb' + - 'spec/models/issue_assignee_spec.rb' + - 'spec/models/issue_spec.rb' + - 'spec/models/jira_import_state_spec.rb' + - 'spec/models/label_link_spec.rb' + - 'spec/models/lfs_objects_project_spec.rb' + - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/merge_request_assignee_spec.rb' + - 'spec/models/merge_request_diff_commit_spec.rb' + - 'spec/models/merge_request_diff_file_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/milestone_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/namespace_statistics_spec.rb' + - 'spec/models/oauth_access_token_spec.rb' + - 'spec/models/packages/dependency_spec.rb' + - 'spec/models/packages/maven/metadatum_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'spec/models/pages_deployment_spec.rb' + - 'spec/models/pages_domain_spec.rb' + - 'spec/models/performance_monitoring/prometheus_dashboard_spec.rb' + - 'spec/models/performance_monitoring/prometheus_metric_spec.rb' + - 'spec/models/performance_monitoring/prometheus_panel_group_spec.rb' + - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' + - 'spec/models/plan_spec.rb' + - 'spec/models/postgresql/detached_partition_spec.rb' + - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' + - 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb' + - 'spec/models/project_feature_usage_spec.rb' + - 'spec/models/project_setting_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/projects/topic_spec.rb' + - 'spec/models/release_highlight_spec.rb' + - 'spec/models/release_spec.rb' + - 'spec/models/route_spec.rb' + - 'spec/models/todo_spec.rb' + - 'spec/models/u2f_registration_spec.rb' + - 'spec/models/user_custom_attribute_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/users/merge_request_interaction_spec.rb' + - 'spec/models/users_statistics_spec.rb' + - 'spec/models/wiki_directory_spec.rb' + - 'spec/models/work_items/type_spec.rb' + - 'spec/serializers/context_commits_diff_entity_spec.rb' + - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' + - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' + - 'spec/services/ci/register_job_service_spec.rb' + - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' + - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' + - 'spec/services/issuable/process_assignees_spec.rb' + - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' + - 'spec/services/merge_requests/update_service_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/resource_access_tokens/create_service_spec.rb' + - 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' + - 'spec/services/snippets/update_service_spec.rb' + - 'spec/services/system_hooks_service_spec.rb' + - 'spec/services/user_project_access_changed_service_spec.rb' + - 'spec/services/webauthn/authenticate_service_spec.rb' + - 'spec/services/webauthn/register_service_spec.rb' + - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' + - 'spec/support_specs/helpers/graphql_helpers_spec.rb' + - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' + - 'spec/validators/html_safety_validator_spec.rb' + - 'spec/workers/bulk_imports/entity_worker_spec.rb' + - 'spec/workers/jira_connect/retry_request_worker_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_example_group.yml b/.rubocop_todo/rspec/empty_line_after_example_group.yml new file mode 100644 index 00000000000..80d60ee181e --- /dev/null +++ b/.rubocop_todo/rspec/empty_line_after_example_group.yml @@ -0,0 +1,39 @@ +--- +# Cop supports --auto-correct. +RSpec/EmptyLineAfterExampleGroup: + Exclude: + - 'ee/spec/controllers/groups/clusters_controller_spec.rb' + - 'ee/spec/controllers/groups/groups_controller_spec.rb' + - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' + - 'ee/spec/features/security/group/private_access_spec.rb' + - 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb' + - 'ee/spec/services/ee/gpg_keys/create_service_spec.rb' + - 'ee/spec/services/ee/issues/create_from_vulnerability_data_service_spec.rb' + - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' + - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' + - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' + - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' + - 'qa/spec/support/loglinking_spec.rb' + - 'spec/controllers/explore/projects_controller_spec.rb' + - 'spec/controllers/projects/notes_controller_spec.rb' + - 'spec/factories/projects/ci_feature_usages.rb' + - 'spec/features/security/group/internal_access_spec.rb' + - 'spec/features/security/group/private_access_spec.rb' + - 'spec/features/security/group/public_access_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' + - 'spec/helpers/git_helper_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' + - 'spec/lib/gitlab/blob_helper_spec.rb' + - 'spec/lib/gitlab/file_type_detection_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' + - 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb' + - 'spec/models/note_spec.rb' + - 'spec/models/project_feature_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/zoom_meeting_spec.rb' + - 'spec/requests/api/graphql/project/issues_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/routing/project_routing_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 03066626883..f8962515874 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -22,8 +22,6 @@ RSpec/ExpectChange: - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' @@ -245,7 +243,6 @@ RSpec/ExpectChange: - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' @@ -431,6 +428,7 @@ RSpec/ExpectChange: - 'spec/models/project_auto_devops_spec.rb' - 'spec/models/project_import_state_spec.rb' - 'spec/models/project_spec.rb' + - 'spec/models/project_statistics_spec.rb' - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - 'spec/models/projects/ci_feature_usage_spec.rb' - 'spec/models/release_spec.rb' @@ -491,6 +489,7 @@ RSpec/ExpectChange: - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' + - 'spec/services/ci/job_artifacts/delete_service_spec.rb' - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/process_build_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index d138ea806f8..1551f2dc637 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -6,8 +6,6 @@ RSpec/ExpectInHook: - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/settings/slacks_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_controller_spec.rb' - - 'ee/spec/controllers/registrations/groups_projects_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' @@ -17,7 +15,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/registrations/combined_registration_spec.rb' - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/features/registrations/trial_during_signup_flow_spec.rb' - 'ee/spec/features/signup_spec.rb' @@ -35,7 +32,7 @@ RSpec/ExpectInHook: - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - - 'ee/spec/helpers/kerberos_spnego_helper_spec.rb' + - 'ee/spec/helpers/kerberos_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' @@ -72,7 +69,7 @@ RSpec/ExpectInHook: - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb' - - 'ee/spec/requests/omniauth_kerberos_spnego_spec.rb' + - 'ee/spec/requests/omniauth_kerberos_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' @@ -103,7 +100,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/security/findings/cleanup_service_spec.rb' - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - - 'ee/spec/support/shared_examples/controllers/registrations/projects_controller_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' @@ -315,12 +311,10 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/verify/uploads_spec.rb' - 'spec/lib/gitlab/zentao/query_spec.rb' - 'spec/lib/gitlab_spec.rb' - - 'spec/lib/learn_gitlab/onboarding_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/sidebars/projects/menus/external_issue_tracker_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/learn_gitlab_menu_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/20210406144743_backfill_total_tuple_count_for_batched_migrations_spec.rb' diff --git a/.rubocop_todo/rspec/missing_example_group_argument.yml b/.rubocop_todo/rspec/missing_example_group_argument.yml new file mode 100644 index 00000000000..1506c9536a0 --- /dev/null +++ b/.rubocop_todo/rspec/missing_example_group_argument.yml @@ -0,0 +1,16 @@ +--- +RSpec/MissingExampleGroupArgument: + Exclude: + - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/merge_requests_controller_spec.rb' + - 'spec/factories/projects/ci_feature_usages.rb' + - 'spec/lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2_spec.rb' + - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/policies/award_emoji_policy_spec.rb' + - 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb' + - 'spec/requests/api/graphql/mutations/notes/create/image_diff_note_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' diff --git a/.rubocop_todo/rspec/predicate_matcher.yml b/.rubocop_todo/rspec/predicate_matcher.yml index 7b31ca3622c..f3cfe93191d 100644 --- a/.rubocop_todo/rspec/predicate_matcher.yml +++ b/.rubocop_todo/rspec/predicate_matcher.yml @@ -340,6 +340,7 @@ RSpec/PredicateMatcher: - 'spec/models/concerns/awardable_spec.rb' - 'spec/models/concerns/chronic_duration_attribute_spec.rb' - 'spec/models/concerns/ci/has_deployment_name_spec.rb' + - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/featurable_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/integrations/has_data_fields_spec.rb' diff --git a/.rubocop_todo/rspec/shared_examples.yml b/.rubocop_todo/rspec/shared_examples.yml new file mode 100644 index 00000000000..612692bdb55 --- /dev/null +++ b/.rubocop_todo/rspec/shared_examples.yml @@ -0,0 +1,24 @@ +--- +# Cop supports --auto-correct. +RSpec/SharedExamples: + Exclude: + - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' + - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/gitlab/asciidoc_spec.rb' + - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_on_issuable_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' + - 'spec/lib/gitlab/email/receiver_spec.rb' + - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/models/design_management/version_spec.rb' + - 'spec/models/integrations/drone_ci_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' + - 'spec/rubocop/cop/performance/readlines_each_spec.rb' + - 'spec/support/shared_contexts/email_shared_context.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 70b54d5bc7f..a225dbf21ae 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -41,7 +41,7 @@ RSpec/VerifiedDoubles: - ee/spec/helpers/ee/subscribable_banner_helper_spec.rb - ee/spec/helpers/ee/trial_helper_spec.rb - ee/spec/helpers/ee/trial_registration_helper_spec.rb - - ee/spec/helpers/kerberos_spnego_helper_spec.rb + - ee/spec/helpers/kerberos_helper_spec.rb - ee/spec/helpers/license_helper_spec.rb - ee/spec/helpers/roadmaps_helper_spec.rb - ee/spec/helpers/routing/pseudonymization_helper_spec.rb @@ -90,7 +90,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - - ee/spec/models/approvable_spec.rb - ee/spec/models/concerns/geo/verification_state_spec.rb - ee/spec/models/ee/ci/job_artifact_spec.rb - ee/spec/models/ee/user_spec.rb @@ -449,7 +448,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/ci/config/external/file/project_spec.rb - spec/lib/gitlab/ci/config/external/rules_spec.rb - spec/lib/gitlab/ci/parsers/test/junit_spec.rb - - spec/lib/gitlab/ci/pipeline/chain/command_spec.rb - spec/lib/gitlab/ci/pipeline/chain/evaluate_workflow_rules_spec.rb - spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb - spec/lib/gitlab/ci/pipeline/chain/limit/deployments_spec.rb diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index 104ead817d5..1a155e3cca0 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -1,16 +1,13 @@ --- # Cop supports --auto-correct. Style/BarePercentLiterals: - # Offense count: 220 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/commit.rb' - 'app/models/concerns/storage/legacy_namespace.rb' - 'app/models/integrations/datadog.rb' - 'app/services/feature_flags/base_service.rb' - 'app/services/repositories/base_service.rb' - - 'app/services/repositories/destroy_service.rb' - 'ee/app/services/jira/jql_builder_service.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/spec/features/projects/environments/environments_spec.rb' @@ -41,17 +38,15 @@ Style/BarePercentLiterals: - 'qa/qa/ee/page/project/show.rb' - 'qa/qa/ee/page/project/snippet/index.rb' - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/page/component/design_management.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/element.rb' - 'qa/qa/page/file/form.rb' - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/resource/events/project.rb' - - 'qa/qa/resource/members.rb' + - 'qa/qa/resource/personal_access_token_cache.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' + - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/qa/support/page/logging.rb' - 'qa/spec/runtime/feature_spec.rb' - 'scripts/regenerate-schema' - 'scripts/trigger-build.rb' @@ -79,6 +74,7 @@ Style/BarePercentLiterals: - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' + - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' @@ -95,6 +91,7 @@ Style/BarePercentLiterals: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/models/deployment_spec.rb' + - 'spec/models/incident_management/timeline_event_spec.rb' - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/teamcity_spec.rb' - 'spec/models/project_label_spec.rb' @@ -102,6 +99,8 @@ Style/BarePercentLiterals: - 'spec/requests/api/ci/job_artifacts_spec.rb' - 'spec/requests/api/deployments_spec.rb' - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' + - 'spec/requests/api/graphql/project/incident_management/timeline_events_spec.rb' + - 'spec/requests/projects/packages/package_files_controller_spec.rb' - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - 'spec/support/banzai/reference_filter_shared_examples.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index e0747f232a1..2674902c7ee 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -384,9 +384,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/admin/subscriptions_controller.rb' - 'ee/app/controllers/admin/user_permission_exports_controller.rb' - - 'ee/app/controllers/concerns/registrations/apply_trial.rb' - - 'ee/app/controllers/concerns/registrations/create_group.rb' - - 'ee/app/controllers/concerns/registrations/create_project.rb' - 'ee/app/controllers/concerns/registrations/verification.rb' - 'ee/app/controllers/ee/profiles/accounts_controller.rb' - 'ee/app/controllers/ee/profiles/preferences_controller.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index f211d022dcd..07e42692f60 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -29,7 +29,7 @@ Style/EmptyElse: - 'config/initializers/doorkeeper_openid_connect.rb' - 'ee/app/controllers/admin/audit_logs_controller.rb' - 'ee/app/controllers/ee/groups_controller.rb' - - 'ee/app/helpers/ee/kerberos_spnego_helper.rb' + - 'ee/app/helpers/ee/kerberos_helper.rb' - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/models/ee/audit_event.rb' - 'ee/app/services/ee/users/update_service.rb' diff --git a/.rubocop_todo/style/float_division.yml b/.rubocop_todo/style/float_division.yml new file mode 100644 index 00000000000..7fd0cda469d --- /dev/null +++ b/.rubocop_todo/style/float_division.yml @@ -0,0 +1,7 @@ +--- +Style/FloatDivision: + Exclude: + - 'ee/app/models/geo_node_status.rb' + - 'ee/app/models/namespaces/storage/root_size.rb' + - 'qa/qa/support/formatters/allure_metadata_formatter.rb' + - 'qa/qa/tools/reliable_report.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index bb95d8f7fe9..66c368a7a52 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -65,6 +65,7 @@ Style/FormatString: - 'app/helpers/members_helper.rb' - 'app/helpers/merge_requests_helper.rb' - 'app/helpers/mirror_helper.rb' + - 'app/helpers/notify_helper.rb' - 'app/helpers/preferences_helper.rb' - 'app/helpers/profiles_helper.rb' - 'app/helpers/projects/project_members_helper.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index 384d2dc5fce..aa22e9ed82b 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -20,7 +20,6 @@ Style/HashAsLastArrayItem: - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/boards/board_issue_input_base_type.rb' - - 'app/helpers/learn_gitlab_helper.rb' - 'app/helpers/namespaces_helper.rb' - 'app/models/customer_relations/contact.rb' - 'app/models/customer_relations/organization.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index a58f71aee8f..cc21860d462 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -652,6 +652,7 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/validators/host_validator.rb' - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index 5b898417d96..f733af601ec 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -77,7 +77,7 @@ Style/Lambda: - 'app/models/note.rb' - 'app/models/note_diff_file.rb' - 'app/models/notification_setting.rb' - - 'app/models/onboarding_progress.rb' + - 'app/models/onboarding/progress.rb' - 'app/models/operations/feature_flags/user_list.rb' - 'app/models/packages/package.rb' - 'app/models/packages/package_file.rb' @@ -217,7 +217,6 @@ Style/Lambda: - 'lib/gitlab/sidekiq_signals.rb' - 'lib/gitlab/utils/measuring.rb' - 'lib/gitlab/visibility_level.rb' - - 'qa/qa/fixtures/auto_devops_rack/config.ru' - 'rubocop/cop/rspec/modify_sidekiq_middleware.rb' - 'rubocop/cop/rspec/timecop_freeze.rb' - 'rubocop/cop/rspec/timecop_travel.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index 4106cba955f..9570bd7b036 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -3,17 +3,7 @@ Style/Next: Exclude: - 'app/models/concerns/integrations/slack_mattermost_notifier.rb' - - 'app/models/preloaders/environments/deployment_preloader.rb' - - 'app/models/route.rb' - - 'app/services/authorized_project_update/find_records_due_for_refresh_service.rb' - 'app/validators/nested_attributes_duplicates_validator.rb' - - 'config/initializers/01_secret_token.rb' - - 'config/initializers/sidekiq_cluster.rb' - - 'ee/app/controllers/groups/analytics/cycle_analytics/value_streams_controller.rb' - - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service.rb' - - 'ee/app/services/security/auto_fix_service.rb' - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - 'ee/db/fixtures/development/20_vulnerabilities.rb' - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index ae019079a8d..9989ae3f8b3 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -254,7 +254,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/mailers/previews/license_mailer_preview.rb' - 'ee/app/models/app_sec/fuzzing/api/scan_profile.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/concerns/approvable.rb' - 'ee/app/models/concerns/ee/issue_available_features.rb' - 'ee/app/models/ee/audit_event.rb' - 'ee/app/models/ee/description_version.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 65f2ea327d7..8c688dc89c1 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -47,7 +47,6 @@ Style/RedundantSelf: - 'app/models/commit_status.rb' - 'app/models/compare.rb' - 'app/models/concerns/after_commit_queue.rb' - - 'app/models/concerns/approvable_base.rb' - 'app/models/concerns/atomic_internal_id.rb' - 'app/models/concerns/avatarable.rb' - 'app/models/concerns/awardable.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 2330683cc18..3dd708d2c49 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -74,7 +74,7 @@ Style/StringConcatenation: - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/elastic/search_results.rb' - 'ee/lib/gitlab/geo/git_ssh_proxy.rb' - - 'ee/lib/omni_auth/strategies/kerberos_spnego.rb' + - 'ee/lib/omni_auth/strategies/kerberos.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/license.rake' - 'ee/spec/controllers/trial_registrations_controller_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 75aab7c6116..bfb3867b127 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -239,7 +239,6 @@ Style/SymbolProc: - 'spec/graphql/mutations/releases/create_spec.rb' - 'spec/graphql/types/work_items/widget_type_enum_spec.rb' - 'spec/helpers/instance_configuration_helper_spec.rb' - - 'spec/helpers/learn_gitlab_helper_spec.rb' - 'spec/helpers/members_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' |