diff options
Diffstat (limited to '.rubocop_todo')
58 files changed, 775 insertions, 1978 deletions
diff --git a/.rubocop_todo/api/ensure_string_detail.yml b/.rubocop_todo/api/ensure_string_detail.yml new file mode 100644 index 00000000000..feac99aa569 --- /dev/null +++ b/.rubocop_todo/api/ensure_string_detail.yml @@ -0,0 +1,5 @@ +--- +API/EnsureStringDetail: + Details: grace period + Exclude: + - 'ee/lib/api/analytics/group_activity_analytics.rb' diff --git a/.rubocop_todo/gitlab/json.yml b/.rubocop_todo/gitlab/json.yml new file mode 100644 index 00000000000..190778a3de7 --- /dev/null +++ b/.rubocop_todo/gitlab/json.yml @@ -0,0 +1,465 @@ +--- +# Cop supports --autocorrect. +Gitlab/Json: + Exclude: + - 'app/controllers/admin/application_settings_controller.rb' + - 'app/controllers/concerns/authenticates_with_two_factor.rb' + - 'app/controllers/projects/commit_controller.rb' + - 'app/controllers/projects/google_cloud/configuration_controller.rb' + - 'app/controllers/projects/google_cloud/databases_controller.rb' + - 'app/controllers/projects/google_cloud/deployments_controller.rb' + - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' + - 'app/controllers/projects/google_cloud/service_accounts_controller.rb' + - 'app/controllers/projects/graphs_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' + - 'app/controllers/projects/notes_controller.rb' + - 'app/controllers/projects/settings/ci_cd_controller.rb' + - 'app/controllers/projects/templates_controller.rb' + - 'app/controllers/projects_controller.rb' + - 'app/controllers/search_controller.rb' + - 'app/helpers/access_tokens_helper.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/breadcrumbs_helper.rb' + - 'app/helpers/ci/builds_helper.rb' + - 'app/helpers/ci/pipelines_helper.rb' + - 'app/helpers/compare_helper.rb' + - 'app/helpers/emails_helper.rb' + - 'app/helpers/environment_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/ide_helper.rb' + - 'app/helpers/integrations_helper.rb' + - 'app/helpers/invite_members_helper.rb' + - 'app/helpers/issuables_description_templates_helper.rb' + - 'app/helpers/issuables_helper.rb' + - 'app/helpers/jira_connect_helper.rb' + - 'app/helpers/learn_gitlab_helper.rb' + - 'app/helpers/namespaces_helper.rb' + - 'app/helpers/notes_helper.rb' + - 'app/helpers/operations_helper.rb' + - 'app/helpers/packages_helper.rb' + - 'app/helpers/projects/project_members_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/helpers/terms_helper.rb' + - 'app/helpers/users_helper.rb' + - 'app/mailers/emails/members.rb' + - 'app/presenters/packages/composer/packages_presenter.rb' + - 'app/presenters/projects/security/configuration_presenter.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' + - 'config/initializers/rack_multipart_patch.rb' + - 'ee/app/controllers/admin/geo/nodes_controller.rb' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' + - 'ee/app/controllers/ee/search_controller.rb' + - 'ee/app/controllers/subscriptions_controller.rb' + - 'ee/app/graphql/types/json_string_type.rb' + - 'ee/app/helpers/billing_plans_helper.rb' + - 'ee/app/helpers/ee/environments_helper.rb' + - 'ee/app/helpers/ee/geo_helper.rb' + - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' + - 'ee/app/helpers/ee/invite_members_helper.rb' + - 'ee/app/helpers/ee/operations_helper.rb' + - 'ee/app/helpers/ee/projects/pipeline_helper.rb' + - 'ee/app/helpers/ee/projects_helper.rb' + - 'ee/app/helpers/ee/security_orchestration_helper.rb' + - 'ee/app/helpers/groups/ldap_sync_helper.rb' + - 'ee/app/helpers/groups/security_features_helper.rb' + - 'ee/app/helpers/incident_management/oncall_schedule_helper.rb' + - 'ee/app/helpers/projects/on_demand_scans_helper.rb' + - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' + - 'ee/app/helpers/security_helper.rb' + - 'ee/app/helpers/subscriptions_helper.rb' + - 'ee/app/helpers/users/identity_verification_helper.rb' + - 'ee/app/helpers/vulnerabilities_helper.rb' + - 'ee/app/models/product_analytics/jitsu_authentication.rb' + - 'ee/app/presenters/epic_presenter.rb' + - 'ee/app/services/arkose/blocked_users_report_service.rb' + - 'ee/app/services/elastic/indexing_control_service.rb' + - 'ee/app/services/elastic/process_bookkeeping_service.rb' + - 'ee/app/services/security/token_revocation_service.rb' + - 'ee/app/services/status_page/publish_base_service.rb' + - 'ee/app/services/upcoming_reconciliations/update_service.rb' + - 'ee/app/services/vulnerabilities/create_service_base.rb' + - 'ee/app/workers/concerns/elastic/migration_state.rb' + - 'ee/app/workers/sync_seat_link_request_worker.rb' + - 'ee/db/fixtures/development/20_vulnerabilities.rb' + - 'ee/lib/api/analytics/product_analytics.rb' + - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/geo/signed_data.rb' + - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' + - 'ee/lib/gitlab/subscription_portal/clients/rest.rb' + - 'ee/lib/slack/api.rb' + - 'ee/lib/tasks/gitlab/elastic.rake' + - 'ee/lib/tasks/gitlab/spdx.rake' + - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' + - 'ee/spec/controllers/countries_controller_spec.rb' + - 'ee/spec/controllers/country_states_controller_spec.rb' + - 'ee/spec/controllers/ee/search_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/cycle_analytics_controller_spec.rb' + - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' + - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' + - 'ee/spec/controllers/subscriptions_controller_spec.rb' + - 'ee/spec/factories/vulnerabilities/findings.rb' + - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' + - 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb' + - 'ee/spec/features/projects/integrations/jira_issues_list_spec.rb' + - 'ee/spec/features/projects/integrations/user_activates_github_spec.rb' + - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'ee/spec/frontend/fixtures/dast_profiles.rb' + - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/graphql/api/vulnerabilities_spec.rb' + - 'ee/spec/graphql/types/json_string_type_spec.rb' + - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' + - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' + - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' + - 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb' + - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' + - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/license_compliance/license_scanning_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb' + - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' + - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' + - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' + - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' + - 'ee/spec/lib/slack/api_spec.rb' + - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' + - 'ee/spec/models/ee/integrations/jira_spec.rb' + - 'ee/spec/models/gitlab/seat_link_data_spec.rb' + - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/integrations/github/status_notifier_spec.rb' + - 'ee/spec/models/integrations/github_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' + - 'ee/spec/models/vulnerabilities/finding_spec.rb' + - 'ee/spec/presenters/audit_event_presenter_spec.rb' + - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' + - 'ee/spec/requests/api/experiments_spec.rb' + - 'ee/spec/requests/api/geo_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb' + - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/location_spec.rb' + - 'ee/spec/requests/api/integrations/slack/events_spec.rb' + - 'ee/spec/requests/api/releases_spec.rb' + - 'ee/spec/requests/api/settings_spec.rb' + - 'ee/spec/requests/git_http_geo_spec.rb' + - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' + - 'ee/spec/requests/projects/security/policies_controller_spec.rb' + - 'ee/spec/requests/users/identity_verification_controller_spec.rb' + - 'ee/spec/serializers/clusters/environment_entity_spec.rb' + - 'ee/spec/serializers/clusters/environment_serializer_spec.rb' + - 'ee/spec/serializers/dependency_list_serializer_spec.rb' + - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' + - 'ee/spec/serializers/evidences/evidence_entity_spec.rb' + - 'ee/spec/serializers/issue_serializer_spec.rb' + - 'ee/spec/serializers/licenses_list_serializer_spec.rb' + - 'ee/spec/serializers/member_entity_spec.rb' + - 'ee/spec/serializers/member_user_entity_spec.rb' + - 'ee/spec/serializers/status_page/incident_entity_spec.rb' + - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/serializers/test_reports_comparer_serializer_spec.rb' + - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' + - 'ee/spec/services/arkose/token_verification_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' + - 'ee/spec/services/integrations/slack_events/app_home_opened_service_spec.rb' + - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' + - 'ee/spec/services/projects/slack_application_install_service_spec.rb' + - 'ee/spec/services/security/token_revocation_service_spec.rb' + - 'ee/spec/support/helpers/subscription_portal_helpers.rb' + - 'ee/spec/support/shared_examples/controllers/cluster_metrics_shared_examples.rb' + - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' + - 'ee/spec/support/shared_examples/status_page/publish_shared_examples.rb' + - 'ee/spec/tasks/gitlab/spdx_rake_spec.rb' + - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' + - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' + - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' + - 'ee/spec/workers/vulnerability_exports/export_worker_spec.rb' + - 'lib/api/api.rb' + - 'lib/api/feature_flags_user_lists.rb' + - 'lib/api/helpers.rb' + - 'lib/api/terraform/state.rb' + - 'lib/atlassian/jira_connect/client.rb' + - 'lib/atlassian/jira_connect/serializers/base_entity.rb' + - 'lib/backup/gitaly_backup.rb' + - 'lib/bitbucket_server/client.rb' + - 'lib/bulk_imports/clients/graphql.rb' + - 'lib/error_tracking/sentry_client.rb' + - 'lib/gitlab/alert_management/payload/prometheus.rb' + - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' + - 'lib/gitlab/auth/otp/strategies/forti_authenticator/manual_otp.rb' + - 'lib/gitlab/auth/otp/strategies/forti_authenticator/push_otp.rb' + - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' + - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' + - 'lib/gitlab/bitbucket_import/importer.rb' + - 'lib/gitlab/bitbucket_server_import/importer.rb' + - 'lib/gitlab/chat/responder/mattermost.rb' + - 'lib/gitlab/chat/responder/slack.rb' + - 'lib/gitlab/chat_name_token.rb' + - 'lib/gitlab/ci/ansi2html.rb' + - 'lib/gitlab/ci/ansi2json/state.rb' + - 'lib/gitlab/ci/build/releaser.rb' + - 'lib/gitlab/ci/config/external/mapper.rb' + - 'lib/gitlab/ci/pipeline/chain/validate/external.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/composer/cache.rb' + - 'lib/gitlab/database/background_migration/batched_migration.rb' + - 'lib/gitlab/database/background_migration_job.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' + - 'lib/gitlab/database/migrations/instrumentation.rb' + - 'lib/gitlab/database/migrations/runner.rb' + - 'lib/gitlab/database/postgres_hll/buckets.rb' + - 'lib/gitlab/database/reindexing/grafana_notifier.rb' + - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb' + - 'lib/gitlab/diff/highlight_cache.rb' + - 'lib/gitlab/discussions_diff/highlight_cache.rb' + - 'lib/gitlab/external_authorization/client.rb' + - 'lib/gitlab/file_hook.rb' + - 'lib/gitlab/gitaly_client/conflicts_service.rb' + - 'lib/gitlab/graphql/pagination/active_record_array_connection.rb' + - 'lib/gitlab/graphql/pagination/keyset/connection.rb' + - 'lib/gitlab/health_checks/middleware.rb' + - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' + - 'lib/gitlab/import_export/json/legacy_writer.rb' + - 'lib/gitlab/import_export/json/ndjson_writer.rb' + - 'lib/gitlab/import_export/lfs_saver.rb' + - 'lib/gitlab/jira/http_client.rb' + - 'lib/gitlab/json_cache.rb' + - 'lib/gitlab/legacy_github_import/importer.rb' + - 'lib/gitlab/lfs/client.rb' + - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' + - 'lib/gitlab/middleware/read_only/controller.rb' + - 'lib/gitlab/patch/hangouts_chat_http_override.rb' + - 'lib/gitlab/puma_logging/json_formatter.rb' + - 'lib/gitlab/sidekiq_config.rb' + - 'lib/gitlab/sidekiq_daemon/monitor.rb' + - 'lib/gitlab/sidekiq_logging/json_formatter.rb' + - 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb' + - 'lib/gitlab/utils/json_size_estimator.rb' + - 'lib/gitlab/version_info.rb' + - 'lib/gitlab/workhorse.rb' + - 'lib/mattermost/command.rb' + - 'lib/mattermost/team.rb' + - 'lib/microsoft_teams/notifier.rb' + - 'lib/tasks/gitlab/background_migrations.rake' + - 'lib/version_check.rb' + - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' + - 'spec/controllers/admin/integrations_controller_spec.rb' + - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' + - 'spec/controllers/groups/settings/integrations_controller_spec.rb' + - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' + - 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb' + - 'spec/controllers/projects/alerting/notifications_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' + - 'spec/factories/ci/pipeline_artifacts.rb' + - 'spec/features/dashboard/issues_spec.rb' + - 'spec/features/error_tracking/user_filters_errors_by_status_spec.rb' + - 'spec/features/file_uploads/graphql_add_design_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/markdown/copy_as_gfm_spec.rb' + - 'spec/features/markdown/metrics_spec.rb' + - 'spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'spec/features/projects/settings/monitor_settings_spec.rb' + - 'spec/frontend/fixtures/timezones.rb' + - 'spec/helpers/access_tokens_helper_spec.rb' + - 'spec/helpers/breadcrumbs_helper_spec.rb' + - 'spec/helpers/ci/builds_helper_spec.rb' + - 'spec/helpers/environment_helper_spec.rb' + - 'spec/helpers/environments_helper_spec.rb' + - 'spec/helpers/groups/group_members_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' + - 'spec/helpers/ide_helper_spec.rb' + - 'spec/helpers/invite_members_helper_spec.rb' + - 'spec/helpers/issuables_description_templates_helper_spec.rb' + - 'spec/helpers/listbox_helper_spec.rb' + - 'spec/helpers/namespaces_helper_spec.rb' + - 'spec/helpers/projects/project_members_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' + - 'spec/initializers/hangouts_chat_http_override_spec.rb' + - 'spec/lib/api/entities/merge_request_basic_spec.rb' + - 'spec/lib/api/helpers/caching_spec.rb' + - 'spec/lib/api/helpers/common_helpers_spec.rb' + - 'spec/lib/atlassian/jira_connect/client_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/build_entity_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' + - 'spec/lib/atlassian/jira_connect/serializers/repository_entity_spec.rb' + - 'spec/lib/bitbucket_server/connection_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb' + - 'spec/lib/container_registry/client_spec.rb' + - 'spec/lib/container_registry/gitlab_api_client_spec.rb' + - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' + - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' + - 'spec/lib/gitlab/chat/responder/mattermost_spec.rb' + - 'spec/lib/gitlab/chat/responder/slack_spec.rb' + - 'spec/lib/gitlab/ci/build/releaser_spec.rb' + - 'spec/lib/gitlab/ci/parsers/accessibility/pa11y_spec.rb' + - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' + - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/cyclonedx_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' + - 'spec/lib/gitlab/composer/cache_spec.rb' + - 'spec/lib/gitlab/composer/version_index_spec.rb' + - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' + - 'spec/lib/gitlab/database/postgres_hll/buckets_spec.rb' + - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' + - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/diff/stats_cache_spec.rb' + - 'spec/lib/gitlab/discussions_diff/highlight_cache_spec.rb' + - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' + - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' + - 'spec/lib/gitlab/external_authorization/client_spec.rb' + - 'spec/lib/gitlab/external_authorization/response_spec.rb' + - 'spec/lib/gitlab/file_hook_spec.rb' + - 'spec/lib/gitlab/git/rugged_impl/use_rugged_spec.rb' + - 'spec/lib/gitlab/github_import/client_spec.rb' + - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/exception_logger_spec.rb' + - 'spec/lib/gitlab/harbor/client_spec.rb' + - 'spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb' + - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' + - 'spec/lib/gitlab/json_cache_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' + - 'spec/lib/gitlab/lfs/client_spec.rb' + - 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb' + - 'spec/lib/gitlab/middleware/multipart_spec.rb' + - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' + - 'spec/lib/gitlab/tracking/service_ping_context_spec.rb' + - 'spec/lib/gitlab/tracking/standard_context_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' + - 'spec/lib/gitlab/usage/service_ping/legacy_metric_timing_decorator_spec.rb' + - 'spec/lib/gitlab/utils/json_size_estimator_spec.rb' + - 'spec/lib/gitlab/version_info_spec.rb' + - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/gitlab/workhorse_spec.rb' + - 'spec/lib/gitlab/zentao/client_spec.rb' + - 'spec/lib/grafana/client_spec.rb' + - 'spec/lib/json_web_token/hmac_token_spec.rb' + - 'spec/lib/mattermost/command_spec.rb' + - 'spec/lib/mattermost/team_spec.rb' + - 'spec/lib/microsoft_teams/notifier_spec.rb' + - 'spec/lib/object_storage/direct_upload_spec.rb' + - 'spec/lib/service_ping/devops_report_spec.rb' + - 'spec/lib/version_check_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/migrations/20220204194347_encrypt_integration_properties_spec.rb' + - 'spec/migrations/20220412143552_consume_remaining_encrypt_integration_property_jobs_spec.rb' + - 'spec/models/blob_viewer/package_json_spec.rb' + - 'spec/models/ci/runner_spec.rb' + - 'spec/models/concerns/prometheus_adapter_spec.rb' + - 'spec/models/concerns/redis_cacheable_spec.rb' + - 'spec/models/concerns/sensitive_serializable_hash_spec.rb' + - 'spec/models/diff_discussion_spec.rb' + - 'spec/models/diff_note_spec.rb' + - 'spec/models/hooks/web_hook_spec.rb' + - 'spec/models/integrations/datadog_spec.rb' + - 'spec/models/integrations/jira_spec.rb' + - 'spec/models/integrations/mattermost_slash_commands_spec.rb' + - 'spec/models/integrations/mock_ci_spec.rb' + - 'spec/models/merge_request_diff_commit_spec.rb' + - 'spec/models/packages/composer/metadatum_spec.rb' + - 'spec/models/terraform/state_spec.rb' + - 'spec/presenters/packages/composer/packages_presenter_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/composer_packages_spec.rb' + - 'spec/requests/api/conan_instance_packages_spec.rb' + - 'spec/requests/api/conan_project_packages_spec.rb' + - 'spec/requests/api/container_registry_event_spec.rb' + - 'spec/requests/api/graphql/mutations/design_management/upload_spec.rb' + - 'spec/requests/api/integrations/jira_connect/subscriptions_spec.rb' + - 'spec/requests/api/internal/base_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/namespaces_spec.rb' + - 'spec/requests/api/project_snapshots_spec.rb' + - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' + - 'spec/requests/projects/incident_management/pagerduty_incidents_spec.rb' + - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' + - 'spec/requests/users_controller_spec.rb' + - 'spec/requests/whats_new_controller_spec.rb' + - 'spec/scripts/pipeline_test_report_builder_spec.rb' + - 'spec/serializers/ci/dag_job_entity_spec.rb' + - 'spec/serializers/ci/dag_job_group_entity_spec.rb' + - 'spec/serializers/ci/dag_pipeline_entity_spec.rb' + - 'spec/serializers/ci/dag_pipeline_serializer_spec.rb' + - 'spec/serializers/ci/dag_stage_entity_spec.rb' + - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' + - 'spec/serializers/ci/lint/result_serializer_spec.rb' + - 'spec/serializers/ci/trigger_entity_spec.rb' + - 'spec/serializers/ci/trigger_serializer_spec.rb' + - 'spec/serializers/diff_line_serializer_spec.rb' + - 'spec/serializers/evidences/evidence_entity_spec.rb' + - 'spec/serializers/feature_flags_client_serializer_spec.rb' + - 'spec/serializers/group_link/group_group_link_entity_spec.rb' + - 'spec/serializers/group_link/group_group_link_serializer_spec.rb' + - 'spec/serializers/group_link/group_link_entity_spec.rb' + - 'spec/serializers/group_link/project_group_link_entity_spec.rb' + - 'spec/serializers/group_link/project_group_link_serializer_spec.rb' + - 'spec/serializers/member_entity_spec.rb' + - 'spec/serializers/member_serializer_spec.rb' + - 'spec/serializers/member_user_entity_spec.rb' + - 'spec/serializers/test_reports_comparer_serializer_spec.rb' + - 'spec/services/ci/runners/process_runner_version_update_service_spec.rb' + - 'spec/services/draft_notes/create_service_spec.rb' + - 'spec/services/error_tracking/issue_details_service_spec.rb' + - 'spec/services/error_tracking/issue_latest_event_service_spec.rb' + - 'spec/services/error_tracking/list_issues_service_spec.rb' + - 'spec/services/git/branch_push_service_spec.rb' + - 'spec/services/jira/requests/projects/list_service_spec.rb' + - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' + - 'spec/services/packages/composer/create_package_service_spec.rb' + - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' + - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' + - 'spec/services/webauthn/authenticate_service_spec.rb' + - 'spec/services/webauthn/register_service_spec.rb' + - 'spec/support/frontend_fixtures.rb' + - 'spec/support/google_api/cloud_platform_helpers.rb' + - 'spec/support/helpers/ci_artifact_metadata_generator.rb' + - 'spec/support/helpers/dependency_proxy_helpers.rb' + - 'spec/support/helpers/fake_webauthn_device.rb' + - 'spec/support/helpers/features/two_factor_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/input_helper.rb' + - 'spec/support/helpers/jira_integration_helpers.rb' + - 'spec/support/helpers/kubernetes_helpers.rb' + - 'spec/support/helpers/prometheus_helpers.rb' + - 'spec/support/helpers/sentry_client_helpers.rb' + - 'spec/support/helpers/usage_data_helpers.rb' + - 'spec/support/import_export/configuration_helper.rb' + - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' + - 'spec/support/shared_contexts/features/error_tracking_shared_context.rb' + - 'spec/support/shared_contexts/prometheus/alert_shared_context.rb' + - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' + - 'spec/support/shared_examples/blocks_unsafe_serialization_shared_examples.rb' + - 'spec/support/shared_examples/controllers/rate_limited_endpoint_shared_examples.rb' + - 'spec/support/shared_examples/controllers/snowplow_event_tracking_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' + - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' + - 'spec/support_specs/helpers/graphql_helpers_spec.rb' + - 'spec/tasks/gitlab/update_templates_rake_spec.rb' + - 'spec/tasks/gitlab/usage_data_rake_spec.rb' + - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' + - 'spec/tooling/rspec_flaky/listener_spec.rb' + - 'spec/workers/ci/runners/process_runner_version_update_worker_spec.rb' + - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' + - 'spec/workers/packages/composer/cache_update_worker_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 230ef959153..3fb2df623e0 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -1283,7 +1283,6 @@ Gitlab/NamespacedClass: - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - - 'spec/support/helpers/bare_repo_operations.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - 'spec/support/helpers/fake_migration_classes.rb' - 'spec/support/helpers/fake_u2f_device.rb' diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index 0dcee5f32ee..195dfe5a81d 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -1,6 +1,5 @@ --- Gitlab/NoCodeCoverageComment: - Details: grace period Exclude: - 'app/models/integration.rb' - 'app/services/ci/job_artifacts/destroy_batch_service.rb' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml index ccf934e09b3..03b73d6491d 100644 --- a/.rubocop_todo/gitlab/service_response.yml +++ b/.rubocop_todo/gitlab/service_response.yml @@ -1,6 +1,5 @@ --- Gitlab/ServiceResponse: - Details: grace period Exclude: - 'app/services/alert_management/metric_images/upload_service.rb' - 'app/services/analytics/cycle_analytics/stages/base_service.rb' diff --git a/.rubocop_todo/graphql/enum_names.yml b/.rubocop_todo/graphql/enum_names.yml new file mode 100644 index 00000000000..18f485b6759 --- /dev/null +++ b/.rubocop_todo/graphql/enum_names.yml @@ -0,0 +1,37 @@ +--- +Graphql/EnumNames: + Details: grace period + Exclude: + - 'app/graphql/types/access_level_enum.rb' + - 'app/graphql/types/availability_enum.rb' + - 'app/graphql/types/ci/pipeline_config_source_enum.rb' + - 'app/graphql/types/ci/pipeline_scope_enum.rb' + - 'app/graphql/types/ci/pipeline_status_enum.rb' + - 'app/graphql/types/container_expiration_policy_cadence_enum.rb' + - 'app/graphql/types/container_expiration_policy_keep_enum.rb' + - 'app/graphql/types/container_expiration_policy_older_than_enum.rb' + - 'app/graphql/types/data_visualization_palette/color_enum.rb' + - 'app/graphql/types/data_visualization_palette/weight_enum.rb' + - 'app/graphql/types/merge_strategy_enum.rb' + - 'app/graphql/types/milestone_state_enum.rb' + - 'app/graphql/types/packages/cleanup/keep_duplicated_package_files_enum.rb' + - 'app/graphql/types/packages/conan/metadatum_file_type_enum.rb' + - 'app/graphql/types/packages/package_type_enum.rb' + - 'app/graphql/types/security/report_type_enum.rb' + - 'app/graphql/types/snippets/blob_action_enum.rb' + - 'app/graphql/types/snippets/type_enum.rb' + - 'app/graphql/types/snippets/visibility_scopes_enum.rb' + - 'app/graphql/types/sort_direction_enum.rb' + - 'app/graphql/types/todo_action_enum.rb' + - 'app/graphql/types/todo_state_enum.rb' + - 'app/graphql/types/todo_target_enum.rb' + - 'app/graphql/types/user_callout_feature_name_enum.rb' + - 'app/graphql/types/visibility_levels_enum.rb' + - 'ee/app/graphql/types/dast_scan_type_enum.rb' + - 'ee/app/graphql/types/dast_site_profile_validation_status_enum.rb' + - 'ee/app/graphql/types/dast_site_validation_status_enum.rb' + - 'ee/app/graphql/types/dast_site_validation_strategy_enum.rb' + - 'ee/app/graphql/types/dast_target_type_enum.rb' + - 'ee/app/graphql/types/geo/replication_state_enum.rb' + - 'ee/app/graphql/types/geo/verification_state_enum.rb' + - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' diff --git a/.rubocop_todo/graphql/enum_values.yml b/.rubocop_todo/graphql/enum_values.yml new file mode 100644 index 00000000000..3984c54a9f2 --- /dev/null +++ b/.rubocop_todo/graphql/enum_values.yml @@ -0,0 +1,37 @@ +--- +Graphql/EnumValues: + Details: grace period + Exclude: + - 'app/graphql/types/alert_management/domain_filter_enum.rb' + - 'app/graphql/types/blob_viewers/type_enum.rb' + - 'app/graphql/types/ci/config/include_type_enum.rb' + - 'app/graphql/types/ci/test_case_status_enum.rb' + - 'app/graphql/types/container_expiration_policy_cadence_enum.rb' + - 'app/graphql/types/container_expiration_policy_keep_enum.rb' + - 'app/graphql/types/container_expiration_policy_older_than_enum.rb' + - 'app/graphql/types/customer_relations/contact_state_enum.rb' + - 'app/graphql/types/customer_relations/organization_state_enum.rb' + - 'app/graphql/types/design_management/design_version_event_enum.rb' + - 'app/graphql/types/issuable_state_enum.rb' + - 'app/graphql/types/merge_request_state_enum.rb' + - 'app/graphql/types/milestone_state_enum.rb' + - 'app/graphql/types/notes/position_type_enum.rb' + - 'app/graphql/types/packages/cleanup/keep_duplicated_package_files_enum.rb' + - 'app/graphql/types/snippets/blob_action_enum.rb' + - 'app/graphql/types/snippets/type_enum.rb' + - 'app/graphql/types/snippets/visibility_scopes_enum.rb' + - 'app/graphql/types/todo_action_enum.rb' + - 'app/graphql/types/todo_state_enum.rb' + - 'app/graphql/types/tree/type_enum.rb' + - 'app/graphql/types/user_state_enum.rb' + - 'app/graphql/types/visibility_levels_enum.rb' + - 'ee/app/graphql/ee/types/list_limit_metric_enum.rb' + - 'ee/app/graphql/types/epic_state_enum.rb' + - 'ee/app/graphql/types/health_status_enum.rb' + - 'ee/app/graphql/types/incident_management/issuable_resource_link_type_enum.rb' + - 'ee/app/graphql/types/iteration_state_enum.rb' + - 'ee/app/graphql/types/move_type_enum.rb' + - 'ee/app/graphql/types/network_policy_kind_enum.rb' + - 'ee/app/graphql/types/security_scanner_type_enum.rb' + - 'ee/app/graphql/types/vulnerability_report_type_enum.rb' + - 'ee/app/graphql/types/vulnerability_sort_enum.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 195f3fee98e..4b5fb5ad1a6 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -655,7 +655,6 @@ Layout/ArgumentAlignment: - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/merge_requests/user_views_open_merge_requests_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/commit/mini_pipeline_graph_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/environments/environments_spec.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index cbe806fc16f..d4a3d2f5524 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: - Details: grace period Exclude: - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' - 'spec/lib/gitlab/search/found_blob_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index fe9c0593f7d..b5fc199c0ca 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -371,7 +371,6 @@ Layout/LineLength: - 'app/models/diff_note.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/project_error_tracking_setting.rb' - - 'app/models/event_collection.rb' - 'app/models/exported_protected_branch.rb' - 'app/models/group.rb' - 'app/models/incident_management/project_incident_management_setting.rb' @@ -597,7 +596,6 @@ Layout/LineLength: - 'app/services/loose_foreign_keys/cleaner_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/invitation_reminder_email_service.rb' - - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/assign_issues_service.rb' - 'app/services/merge_requests/base_service.rb' @@ -1817,7 +1815,6 @@ Layout/LineLength: - 'ee/spec/features/groups/scim_token_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/invites_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' @@ -1915,7 +1912,7 @@ Layout/LineLength: - 'ee/spec/frontend/fixtures/projects.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - - 'ee/spec/graphql/ee/resolvers/issues_resolver_spec.rb' + - 'ee/spec/graphql/ee/resolvers/project_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/types/board_type_spec.rb' - 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb' - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' @@ -2855,7 +2852,6 @@ Layout/LineLength: - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' - 'ee/spec/views/shared/_namespace_user_cap_reached_alert.html.haml_spec.rb' - - 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_eoa_bronze_plan_banner.html.haml_spec.rb' - 'ee/spec/views/shared/billings/_trial_status.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' @@ -2910,7 +2906,6 @@ Layout/LineLength: - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' - 'lib/api/admin/instance_clusters.rb' - - 'lib/api/admin/plan_limits.rb' - 'lib/api/api.rb' - 'lib/api/appearance.rb' - 'lib/api/award_emoji.rb' @@ -2946,19 +2941,15 @@ Layout/LineLength: - 'lib/api/entities/issue_basic.rb' - 'lib/api/entities/merge_request.rb' - 'lib/api/entities/namespace.rb' - - 'lib/api/entities/package.rb' - 'lib/api/entities/project.rb' - 'lib/api/entities/user.rb' - 'lib/api/environments.rb' - - 'lib/api/error_tracking/project_settings.rb' - 'lib/api/feature_flags.rb' - 'lib/api/files.rb' - 'lib/api/generic_packages.rb' - - 'lib/api/go_proxy.rb' - 'lib/api/group_clusters.rb' - 'lib/api/group_import.rb' - 'lib/api/group_labels.rb' - - 'lib/api/group_packages.rb' - 'lib/api/group_variables.rb' - 'lib/api/groups.rb' - 'lib/api/helm_packages.rb' @@ -2992,7 +2983,6 @@ Layout/LineLength: - 'lib/api/members.rb' - 'lib/api/merge_request_diffs.rb' - 'lib/api/merge_requests.rb' - - 'lib/api/metrics/dashboard/annotations.rb' - 'lib/api/metrics/user_starred_dashboards.rb' - 'lib/api/milestone_responses.rb' - 'lib/api/namespaces.rb' @@ -3921,7 +3911,6 @@ Layout/LineLength: - 'spec/features/groups/settings/repository_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - - 'spec/features/incidents/user_views_incident_spec.rb' - 'spec/features/invites_spec.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' @@ -4012,7 +4001,6 @@ Layout/LineLength: - 'spec/features/projects/blobs/shortcuts_blob_spec.rb' - 'spec/features/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb' - 'spec/features/projects/blobs/user_views_pipeline_editor_button_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/ci/editor_spec.rb' - 'spec/features/projects/commit/cherry_pick_spec.rb' - 'spec/features/projects/commit/user_reverts_commit_spec.rb' @@ -4185,11 +4173,11 @@ Layout/LineLength: - 'spec/graphql/resolvers/group_issues_resolver_spec.rb' - 'spec/graphql/resolvers/group_labels_resolver_spec.rb' - 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb' - - 'spec/graphql/resolvers/issues_resolver_spec.rb' - 'spec/graphql/resolvers/merge_requests_resolver_spec.rb' - 'spec/graphql/resolvers/metrics/dashboard_resolver_spec.rb' - 'spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb' - 'spec/graphql/resolvers/namespace_projects_resolver_spec.rb' + - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' - 'spec/graphql/resolvers/project_jobs_resolver_spec.rb' - 'spec/graphql/resolvers/project_resolver_spec.rb' - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' @@ -5543,7 +5531,6 @@ Layout/LineLength: - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/members/invitation_reminder_email_service_spec.rb' - 'spec/services/members/unassign_issuables_service_spec.rb' - - 'spec/services/members/update_service_spec.rb' - 'spec/services/merge_requests/add_context_service_spec.rb' - 'spec/services/merge_requests/after_create_service_spec.rb' - 'spec/services/merge_requests/assign_issues_service_spec.rb' @@ -5968,7 +5955,6 @@ Layout/LineLength: - 'spec/views/projects/tags/index.html.haml_spec.rb' - 'spec/views/projects/tree/show.html.haml_spec.rb' - 'spec/views/search/_results.html.haml_spec.rb' - - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/views/shared/milestones/_issuable.html.haml_spec.rb' - 'spec/views/shared/projects/_project.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 9359939514b..f025680c209 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -69,7 +69,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/diff_note.rb' - 'app/models/environment.rb' - 'app/models/error_tracking/error.rb' - - 'app/models/event_collection.rb' - 'app/models/external_pull_request.rb' - 'app/models/group.rb' - 'app/models/integration.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 805a9791409..e6238992619 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -1,103 +1,20 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Layout/SpaceInsideParens: # Offense count: 701 # Temporarily disabled due to too many offenses Enabled: false Exclude: - - 'app/controllers/projects/environments_controller.rb' - - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/graphql/mutations/ci/job/base.rb' - - 'app/helpers/icons_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - - 'app/models/alert_management/alert.rb' - - 'app/models/ci/build_metadata.rb' - - 'app/models/concerns/milestoneable.rb' - - 'app/models/concerns/mirror_authentication.rb' - - 'app/models/concerns/protected_ref_access.rb' - - 'app/models/cycle_analytics/project_level_stage_adapter.rb' - - 'app/models/merge_request.rb' - - 'app/models/pages_domain.rb' - - 'app/models/project.rb' - - 'app/services/ci/archive_trace_service.rb' - - 'app/services/jira_import/start_import_service.rb' - - 'app/services/labels/transfer_service.rb' - - 'app/services/packages/debian/create_distribution_service.rb' - - 'app/services/packages/debian/update_distribution_service.rb' - - 'app/services/packages/npm/create_package_service.rb' - - 'app/services/personal_access_tokens/revoke_service.rb' - - 'app/services/snippets/create_service.rb' - - 'app/services/spam/spam_verdict_service.rb' - 'config/initializers/wikicloth_redos_patch.rb' - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb' - - 'ee/app/graphql/resolvers/external_issue_resolver.rb' - - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/boards_helper.rb' - - 'ee/app/models/ee/lfs_object.rb' - - 'ee/app/models/ee/merge_request_diff.rb' - - 'ee/app/models/ee/pages_deployment.rb' - - 'ee/app/models/ee/upload.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/resource_iteration_event.rb' - - 'ee/app/services/compliance_management/frameworks/create_service.rb' - - 'ee/app/services/compliance_management/frameworks/destroy_service.rb' - - 'ee/app/services/compliance_management/frameworks/update_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/sitemap/create_service.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/gitlab/auth/smartcard/session.rb' - - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - - 'ee/spec/controllers/ee/groups_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' - - 'ee/spec/controllers/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' - - 'ee/spec/features/account_recovery_regular_check_spec.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/boards/board_filters_spec.rb' - - 'ee/spec/features/boards/group_boards/board_deletion_spec.rb' - - 'ee/spec/features/boards/user_visits_board_spec.rb' - - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' - - 'ee/spec/features/groups/issues_spec.rb' - - 'ee/spec/features/groups/iteration_spec.rb' - - 'ee/spec/features/groups/iterations/user_creates_iteration_in_cadence_spec.rb' - - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' - - 'ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb' - - 'ee/spec/features/merge_requests/user_resets_approvers_spec.rb' - - 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb' - - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' - 'ee/spec/frontend/fixtures/epic.rb' - 'ee/spec/frontend/fixtures/projects.rb' - - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' - - 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb' - - 'ee/spec/graphql/mutations/dast/profiles/create_spec.rb' - - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/auth_hash_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/dynamic_settings_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb' - - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_runner_validation_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/secure_binaries_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb' - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' @@ -171,70 +88,11 @@ Layout/SpaceInsideParens: - 'qa/qa/tools/delete_subgroups.rb' - 'qa/spec/runtime/feature_spec.rb' - 'qa/spec/scenario/template_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - - 'spec/controllers/groups/children_controller_spec.rb' - - 'spec/controllers/groups/registry/repositories_controller_spec.rb' - - 'spec/controllers/groups/releases_controller_spec.rb' - - 'spec/controllers/groups/runners_controller_spec.rb' - - 'spec/controllers/groups_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/projects/environments_controller_spec.rb' - - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/factories/usage_data.rb' - - 'spec/features/boards/board_filters_spec.rb' - - 'spec/features/boards/user_visits_board_spec.rb' - - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - - 'spec/features/graphql_known_operations_spec.rb' - - 'spec/features/groups/activity_spec.rb' - - 'spec/features/groups/board_sidebar_spec.rb' - - 'spec/features/groups/empty_states_spec.rb' - - 'spec/features/groups/issues_spec.rb' - - 'spec/features/groups/milestone_spec.rb' - - 'spec/features/groups/milestones_sorting_spec.rb' - - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' - - 'spec/features/merge_request/user_edits_assignees_sidebar_spec.rb' - - 'spec/features/profiles/two_factor_auths_spec.rb' - - 'spec/features/projects/branches/user_views_branches_spec.rb' - - 'spec/features/projects/fork_spec.rb' - - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/pipeline_schedules_spec.rb' - - 'spec/features/projects/releases/user_views_edit_release_spec.rb' - - 'spec/features/projects/releases/user_views_releases_spec.rb' - 'spec/finders/alert_management/http_integrations_finder_spec.rb' - 'spec/finders/events_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - - 'spec/frontend/fixtures/api_merge_requests.rb' - - 'spec/frontend/fixtures/api_projects.rb' - - 'spec/frontend/fixtures/application_settings.rb' - - 'spec/frontend/fixtures/blob.rb' - - 'spec/frontend/fixtures/branches.rb' - - 'spec/frontend/fixtures/clusters.rb' - - 'spec/frontend/fixtures/deploy_keys.rb' - - 'spec/frontend/fixtures/issues.rb' - - 'spec/frontend/fixtures/jobs.rb' - - 'spec/frontend/fixtures/labels.rb' - - 'spec/frontend/fixtures/merge_requests.rb' - - 'spec/frontend/fixtures/merge_requests_diffs.rb' - - 'spec/frontend/fixtures/metrics_dashboard.rb' - - 'spec/frontend/fixtures/pipeline_schedules.rb' - - 'spec/frontend/fixtures/pipelines.rb' - - 'spec/frontend/fixtures/projects.rb' - - 'spec/frontend/fixtures/raw.rb' - - 'spec/frontend/fixtures/snippet.rb' - - 'spec/frontend/fixtures/todos.rb' - - 'spec/graphql/mutations/todos/restore_many_spec.rb' - - 'spec/graphql/resolvers/board_list_issues_resolver_spec.rb' - - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - - 'spec/graphql/resolvers/board_resolver_spec.rb' - - 'spec/graphql/resolvers/boards_resolver_spec.rb' - - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' - - 'spec/graphql/resolvers/projects_resolver_spec.rb' - - 'spec/graphql/resolvers/recent_boards_resolver_spec.rb' - - 'spec/graphql/resolvers/users_resolver_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/ci/runners_helper_spec.rb' @@ -323,55 +181,9 @@ Layout/SpaceInsideParens: - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - 'spec/migrations/backfill_issues_upvotes_count_spec.rb' - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/build_trace_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/trigger_request_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/deploy_token_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/environment_status_spec.rb' - - 'spec/models/experiment_spec.rb' - - 'spec/models/exported_protected_branch_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/member_spec.rb' - - 'spec/models/metrics/dashboard/annotation_spec.rb' - - 'spec/models/namespace_setting_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/network/graph_spec.rb' - - 'spec/models/packages/package_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/users/calloutable_spec.rb' - 'spec/policies/clusters/agent_policy_spec.rb' - 'spec/presenters/ci/build_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - - 'spec/requests/api/boards_spec.rb' - - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/ci/runners_reset_registration_token_spec.rb' - - 'spec/requests/api/ci/runners_spec.rb' - - 'spec/requests/api/dependency_proxy_spec.rb' - - 'spec/requests/api/deployments_spec.rb' - - 'spec/requests/api/files_spec.rb' - - 'spec/requests/api/go_proxy_spec.rb' - - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' - - 'spec/requests/api/graphql/ci/jobs_spec.rb' - - 'spec/requests/api/graphql/ci/pipelines_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb' - - 'spec/requests/api/group_boards_spec.rb' - - 'spec/requests/api/issues/issues_spec.rb' - - 'spec/requests/api/issues/post_projects_issues_spec.rb' - - 'spec/requests/api/labels_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/pages/pages_spec.rb' - - 'spec/requests/api/project_milestones_spec.rb' - - 'spec/requests/api/project_snippets_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/submodules_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/projects/merge_requests/diffs_spec.rb' - 'spec/requests/projects/merge_requests_spec.rb' @@ -379,28 +191,6 @@ Layout/SpaceInsideParens: - 'spec/requests/search_controller_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/merge_request_user_entity_spec.rb' - - 'spec/services/boards/issues/list_service_spec.rb' - - 'spec/services/ci/compare_test_reports_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/clusters/gcp/provision_service_spec.rb' - - 'spec/services/clusters/gcp/verify_provision_status_service_spec.rb' - - 'spec/services/groups/destroy_service_spec.rb' - - 'spec/services/groups/update_shared_runners_service_spec.rb' - - 'spec/services/import/gitlab_projects/file_acquisition_strategies/file_upload_spec.rb' - - 'spec/services/issues/export_csv_service_spec.rb' - - 'spec/services/labels/promote_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - - 'spec/services/notes/update_service_spec.rb' - - 'spec/services/packages/composer/composer_json_service_spec.rb' - - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/services/search/group_service_spec.rb' - - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - - 'spec/services/system_notes/issuables_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - - 'spec/services/x509_certificate_revoke_service_spec.rb' - 'spec/support/helpers/database/partitioning_helpers.rb' - 'spec/support/helpers/dependency_proxy_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml index d9c88c989e0..8e3e0795c03 100644 --- a/.rubocop_todo/layout/trailing_whitespace.yml +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Layout/TrailingWhitespace: - Details: grace period Exclude: - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' - 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 87ac47deaf5..5e1421c0f3e 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -3,8 +3,6 @@ Lint/MissingCopEnableDirective: Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/projects/forks_controller.rb' - - 'app/graphql/resolvers/group_issues_resolver.rb' - - 'app/graphql/resolvers/issues_resolver.rb' - 'app/graphql/resolvers/project_members_resolver.rb' - 'app/graphql/resolvers/project_milestones_resolver.rb' - 'app/graphql/resolvers/projects/snippets_resolver.rb' diff --git a/.rubocop_todo/performance/method_object_as_block.yml b/.rubocop_todo/performance/method_object_as_block.yml index 1bc82ff05ec..acb1e2d621b 100644 --- a/.rubocop_todo/performance/method_object_as_block.yml +++ b/.rubocop_todo/performance/method_object_as_block.yml @@ -29,7 +29,6 @@ Performance/MethodObjectAsBlock: - 'ee/app/services/security/findings/cleanup_service.rb' - 'ee/app/services/security/ingestion/ingest_reports_service.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - - 'ee/app/services/security/store_findings_metadata_service.rb' - 'ee/app/services/security/store_grouped_scans_service.rb' - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' diff --git a/.rubocop_todo/rails/active_record_callbacks_order.yml b/.rubocop_todo/rails/active_record_callbacks_order.yml index 11ffff36e8d..baeba86c4b9 100644 --- a/.rubocop_todo/rails/active_record_callbacks_order.yml +++ b/.rubocop_todo/rails/active_record_callbacks_order.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Rails/ActiveRecordCallbacksOrder: - Details: grace period Exclude: - 'app/models/award_emoji.rb' - 'app/models/gpg_key.rb' diff --git a/.rubocop_todo/rails/content_tag.yml b/.rubocop_todo/rails/content_tag.yml index 33f6dd36008..d54bd97cc08 100644 --- a/.rubocop_todo/rails/content_tag.yml +++ b/.rubocop_todo/rails/content_tag.yml @@ -1,63 +1,9 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Rails/ContentTag: - # Offense count: 163 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'app/controllers/concerns/wiki_actions.rb' - - 'app/helpers/appearances_helper.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/avatars_helper.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/breadcrumbs_helper.rb' - - 'app/helpers/button_helper.rb' - - 'app/helpers/ci/pipelines_helper.rb' - - 'app/helpers/ci/runners_helper.rb' - - 'app/helpers/ci/status_helper.rb' - - 'app/helpers/clusters_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/diff_helper.rb' - - 'app/helpers/dropdowns_helper.rb' - - 'app/helpers/emails_helper.rb' - - 'app/helpers/environment_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/groups_helper.rb' - - 'app/helpers/hooks_helper.rb' - - 'app/helpers/icons_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/issues_helper.rb' - - 'app/helpers/labels_helper.rb' - - 'app/helpers/listbox_helper.rb' - - 'app/helpers/markup_helper.rb' - - 'app/helpers/notes_helper.rb' - - 'app/helpers/projects_helper.rb' - - 'app/helpers/repository_languages_helper.rb' - - 'app/helpers/search_helper.rb' - - 'app/helpers/tab_helper.rb' - - 'app/helpers/timeboxes_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/helpers/users_helper.rb' - - 'app/helpers/version_check_helper.rb' - - 'app/helpers/wiki_helper.rb' - - 'app/presenters/ci/pipeline_presenter.rb' - - 'app/presenters/merge_request_presenter.rb' - - 'app/presenters/project_presenter.rb' - - 'app/serializers/analytics/cycle_analytics/stage_entity.rb' - - 'app/serializers/entity_date_helper.rb' - - 'app/services/system_notes/base_service.rb' - - 'app/services/system_notes/commit_service.rb' - - 'ee/app/helpers/ee/button_helper.rb' - - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups_helper.rb' - - 'ee/app/helpers/ee/issuables_helper.rb' - - 'ee/app/helpers/ee/lock_helper.rb' - - 'ee/app/helpers/ee/namespaces_helper.rb' - - 'ee/app/helpers/ee/search_helper.rb' - - 'ee/lib/gitlab/expiring_subscription_message.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/gollum_tags_filter.rb' - - 'lib/gitlab/emoji.rb' - - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' + - 'app/helpers/page_layout_helper.rb' - 'lib/gitlab/middleware/go.rb' - - 'spec/frontend/fixtures/tabs.rb' + - 'spec/helpers/avatars_helper_spec.rb' diff --git a/.rubocop_todo/rails/create_table_with_timestamps.yml b/.rubocop_todo/rails/create_table_with_timestamps.yml deleted file mode 100644 index 6e60fa3e1d5..00000000000 --- a/.rubocop_todo/rails/create_table_with_timestamps.yml +++ /dev/null @@ -1,69 +0,0 @@ ---- -Rails/CreateTableWithTimestamps: - # Offense count: 63 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'db/migrate/20210305180331_create_ci_unit_tests.rb' - - 'db/migrate/20210305182855_create_ci_unit_test_failures.rb' - - 'db/migrate/20210317035357_create_dast_profiles_pipelines.rb' - - 'db/migrate/20210317104301_create_in_product_marketing_emails.rb' - - 'db/migrate/20210323125809_create_status_check_responses_table.rb' - - 'db/migrate/20210329191850_add_finding_signature_table.rb' - - 'db/migrate/20210411212813_add_clusters_integrations_prometheus.rb' - - 'db/migrate/20210423054022_create_dast_site_profiles_pipelines.rb' - - 'db/migrate/20210429032320_add_escalation_rules.rb' - - 'db/migrate/20210429131525_create_user_credit_card_validations.rb' - - 'db/migrate/20210511104929_add_epic_board_recent_visits_table.rb' - - 'db/migrate/20210512120122_add_pending_builds_table.rb' - - 'db/migrate/20210527194558_create_ci_job_token_project_scope_links.rb' - - 'db/migrate/20210601123341_add_running_builds_table.rb' - - 'db/migrate/20210602122213_add_upcoming_reconciliations.rb' - - 'db/migrate/20210604032738_create_dast_site_profiles_builds.rb' - - 'db/migrate/20210604051330_create_dast_scanner_profiles_builds.rb' - - 'db/migrate/20210604082145_create_external_status_checks_table.rb' - - 'db/migrate/20210713211008_create_banned_users.rb' - - 'db/migrate/20210729081739_create_project_topics.rb' - - 'db/migrate/20210729202143_create_incident_management_issuable_escalation_statuses.rb' - - 'db/migrate/20210730101609_create_analytics_cycle_analytics_stage_event_hashes.rb' - - 'db/migrate/20210809014850_create_agent_group_authorizations.rb' - - 'db/migrate/20210812171704_create_project_ci_feature_usages.rb' - - 'db/migrate/20210813101742_create_zentao_tracker_data.rb' - - 'db/migrate/20210813111909_create_ci_build_trace_metadata.rb' - - 'db/migrate/20210819185500_create_external_audit_event_destinations_table.rb' - - 'db/migrate/20210823172643_create_user_group_callout.rb' - - 'db/migrate/20210823213417_create_dependency_proxy_image_ttl_group_policies.rb' - - 'db/migrate/20210913010411_create_agent_project_authorizations.rb' - - 'db/migrate/20210922215740_create_issue_customer_relations_contacts.rb' - - 'db/migrate/20211004062942_create_coverage_fuzzing_corpuses.rb' - - 'db/migrate/20211004122540_create_member_tasks.rb' - - 'db/migrate/20211011004242_create_content_blocked_states.rb' - - 'db/migrate/20211011140930_create_ci_namespace_mirrors.rb' - - 'db/migrate/20211011140931_create_ci_project_mirrors.rb' - - 'db/migrate/20211011140932_create_namespaces_sync_events.rb' - - 'db/migrate/20211011141239_create_projects_sync_events.rb' - - 'db/migrate/20211028132247_create_packages_npm_metadata.rb' - - 'db/migrate/20211101132310_add_reindexing_queue.rb' - - 'db/migrate/20211101165656_create_upload_states.rb' - - 'db/migrate/20211110014701_create_agent_activity_events.rb' - - 'db/migrate/20211110092710_create_issue_emails.rb' - - 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb' - - 'db/migrate/20211115132613_create_incident_management_timeline_events.rb' - - 'db/migrate/20211117174209_create_vulnerability_reads.rb' - - 'db/migrate/20211119111006_create_job_artifact_states.rb' - - 'db/migrate/20211119154221_create_pages_deployment_states.rb' - - 'db/migrate/20211119195201_create_deployment_approvals.rb' - - 'db/migrate/20211201143042_create_lfs_object_states.rb' - - 'db/migrate/20211216220939_add_group_crm_settings.rb' - - 'db/migrate/20220110170953_create_ci_secure_files.rb' - - 'db/migrate/20220112205111_create_security_training_providers.rb' - - 'db/migrate/20220113125401_create_security_trainings.rb' - - 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220211125954_create_related_epic_links.rb' - - 'db/migrate/20220216110023_create_saved_replies.rb' - - 'db/migrate/20220301175426_create_project_build_artifacts_size_refresh.rb' - - 'db/migrate/20220302110724_add_group_features_table.rb' - - 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb' - - 'db/migrate/20220425120604_create_packages_cleanup_policies.rb' - - 'db/migrate/20220503102855_add_namespace_ci_cd_settings_table.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index 24a08fa5ee2..898d303bd3d 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -1,6 +1,5 @@ --- Rails/FilePath: - Details: grace period Exclude: - 'app/controllers/help_controller.rb' - 'app/helpers/startupjs_helper.rb' diff --git a/.rubocop_todo/rails/has_many_or_has_one_dependent.yml b/.rubocop_todo/rails/has_many_or_has_one_dependent.yml deleted file mode 100644 index 92ba718bfff..00000000000 --- a/.rubocop_todo/rails/has_many_or_has_one_dependent.yml +++ /dev/null @@ -1,154 +0,0 @@ ---- -Rails/HasManyOrHasOneDependent: - # Offense count: 593 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/models/alert_management/alert.rb' - - 'app/models/analytics/cycle_analytics/project_value_stream.rb' - - 'app/models/analytics/cycle_analytics/stage_event_hash.rb' - - 'app/models/application_setting/term.rb' - - 'app/models/bulk_import.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/bulk_imports/export.rb' - - 'app/models/ci/bridge.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/pipeline_schedule.rb' - - 'app/models/ci/processable.rb' - - 'app/models/ci/ref.rb' - - 'app/models/ci/resource_group.rb' - - 'app/models/ci/runner.rb' - - 'app/models/ci/stage.rb' - - 'app/models/ci/trigger.rb' - - 'app/models/ci/trigger_request.rb' - - 'app/models/ci/unit_test.rb' - - 'app/models/clusters/agent.rb' - - 'app/models/clusters/applications/knative.rb' - - 'app/models/clusters/cluster.rb' - - 'app/models/clusters/project.rb' - - 'app/models/commit_status.rb' - - 'app/models/concerns/ci/metadatable.rb' - - 'app/models/concerns/integrations/has_data_fields.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/label_eventable.rb' - - 'app/models/concerns/milestone_eventable.rb' - - 'app/models/concerns/packages/debian/distribution.rb' - - 'app/models/concerns/protected_ref.rb' - - 'app/models/concerns/state_eventable.rb' - - 'app/models/concerns/timebox.rb' - - 'app/models/concerns/versioned_description.rb' - - 'app/models/concerns/with_uploads.rb' - - 'app/models/customer_relations/contact.rb' - - 'app/models/deploy_key.rb' - - 'app/models/deploy_token.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/version.rb' - - 'app/models/environment.rb' - - 'app/models/error_tracking/error.rb' - - 'app/models/event.rb' - - 'app/models/experiment.rb' - - 'app/models/fork_network.rb' - - 'app/models/gpg_key.rb' - - 'app/models/group.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/integration.rb' - - 'app/models/issue.rb' - - 'app/models/jira_connect_installation.rb' - - 'app/models/label.rb' - - 'app/models/lfs_object.rb' - - 'app/models/list.rb' - - 'app/models/member.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request_context_commit.rb' - - 'app/models/milestone.rb' - - 'app/models/namespace.rb' - - 'app/models/namespaces/project_namespace.rb' - - 'app/models/note.rb' - - 'app/models/operations/feature_flag.rb' - - 'app/models/operations/feature_flags/strategy.rb' - - 'app/models/operations/feature_flags/user_list.rb' - - 'app/models/packages/debian/project_distribution.rb' - - 'app/models/packages/dependency.rb' - - 'app/models/packages/dependency_link.rb' - - 'app/models/packages/package.rb' - - 'app/models/packages/package_file.rb' - - 'app/models/pages_domain.rb' - - 'app/models/plan.rb' - - 'app/models/pool_repository.rb' - - 'app/models/project.rb' - - 'app/models/projects/topic.rb' - - 'app/models/prometheus_alert.rb' - - 'app/models/prometheus_metric.rb' - - 'app/models/release.rb' - - 'app/models/snippet.rb' - - 'app/models/terraform/state.rb' - - 'app/models/user.rb' - - 'app/models/wiki_page/meta.rb' - - 'app/models/work_items/type.rb' - - 'app/models/x509_certificate.rb' - - 'app/models/x509_issuer.rb' - - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - - 'ee/app/models/analytics/devops_adoption/snapshot.rb' - - 'ee/app/models/approval_merge_request_rule.rb' - - 'ee/app/models/approval_project_rule.rb' - - 'ee/app/models/boards/epic_board.rb' - - 'ee/app/models/boards/epic_list.rb' - - 'ee/app/models/compliance_management/framework.rb' - - 'ee/app/models/concerns/ee/iteration_eventable.rb' - - 'ee/app/models/concerns/ee/protected_branch.rb' - - 'ee/app/models/concerns/ee/protected_ref.rb' - - 'ee/app/models/concerns/ee/weight_eventable.rb' - - 'ee/app/models/concerns/geo/eventable.rb' - - 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb' - - 'ee/app/models/concerns/security/scan_execution_policy.rb' - - 'ee/app/models/dast/profile.rb' - - 'ee/app/models/dast_site.rb' - - 'ee/app/models/dast_site_profile.rb' - - 'ee/app/models/dast_site_validation.rb' - - 'ee/app/models/ee/alert_management/alert.rb' - - 'ee/app/models/ee/analytics/cycle_analytics/stage_event_hash.rb' - - 'ee/app/models/ee/board.rb' - - 'ee/app/models/ee/ci/build.rb' - - 'ee/app/models/ee/ci/job_artifact.rb' - - 'ee/app/models/ee/ci/pipeline.rb' - - 'ee/app/models/ee/deployment.rb' - - 'ee/app/models/ee/environment.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - - 'ee/app/models/ee/label.rb' - - 'ee/app/models/ee/lfs_object.rb' - - 'ee/app/models/ee/merge_request.rb' - - 'ee/app/models/ee/merge_request_diff.rb' - - 'ee/app/models/ee/milestone.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/pages_deployment.rb' - - 'ee/app/models/ee/plan.rb' - - 'ee/app/models/ee/project.rb' - - 'ee/app/models/ee/upload.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/elastic/reindexing_subtask.rb' - - 'ee/app/models/elastic/reindexing_task.rb' - - 'ee/app/models/geo/event.rb' - - 'ee/app/models/geo_node.rb' - - 'ee/app/models/incident_management/escalation_policy.rb' - - 'ee/app/models/incident_management/oncall_participant.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/incident_management/oncall_schedule.rb' - - 'ee/app/models/integrations/gitlab_slack_application.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/protected_environment.rb' - - 'ee/app/models/protected_environments/approval_rule.rb' - - 'ee/app/models/push_rule.rb' - - 'ee/app/models/saml_provider.rb' - - 'ee/app/models/security/finding.rb' - - 'ee/app/models/security/scan.rb' - - 'ee/app/models/security/training_provider.rb' - - 'ee/app/models/vulnerabilities/finding.rb' - - 'ee/app/models/vulnerabilities/identifier.rb' - - 'ee/app/models/vulnerabilities/remediation.rb' - - 'ee/app/models/vulnerabilities/scanner.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 8f9197c9223..53e376730fd 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -1,6 +1,5 @@ --- Rails/HelperInstanceVariable: - Details: grace period Exclude: - 'app/helpers/admin/user_actions_helper.rb' - 'app/helpers/application_helper.rb' diff --git a/.rubocop_todo/rails/index_with.yml b/.rubocop_todo/rails/index_with.yml index 91a75e198f5..b7bc2a26959 100644 --- a/.rubocop_todo/rails/index_with.yml +++ b/.rubocop_todo/rails/index_with.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Rails/IndexWith: - Details: grace period Exclude: - 'app/helpers/ci/jobs_helper.rb' - 'app/models/ci/build_trace_chunk.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 262804739bd..2ad8d6204c8 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -1,6 +1,5 @@ --- Rails/InverseOf: - Details: grace period Exclude: - 'app/models/alert_management/alert.rb' - 'app/models/alert_management/alert_assignee.rb' diff --git a/.rubocop_todo/rails/lexically_scoped_action_filter.yml b/.rubocop_todo/rails/lexically_scoped_action_filter.yml index 9edc8f7ce58..dde0da13d3c 100644 --- a/.rubocop_todo/rails/lexically_scoped_action_filter.yml +++ b/.rubocop_todo/rails/lexically_scoped_action_filter.yml @@ -1,15 +1,13 @@ --- Rails/LexicallyScopedActionFilter: - # Offense count: 73 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/admin/groups_controller.rb' + - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/clusters/base_controller.rb' - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/integrations/actions.rb' - - 'app/controllers/concerns/multiple_boards_actions.rb' - 'app/controllers/concerns/oauth_applications.rb' - 'app/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support.rb' - 'app/controllers/confirmations_controller.rb' @@ -17,14 +15,17 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/groups/group_members_controller.rb' - 'app/controllers/groups/milestones_controller.rb' - 'app/controllers/groups/runners_controller.rb' + - 'app/controllers/groups/settings/repository_controller.rb' - 'app/controllers/groups/uploads_controller.rb' - 'app/controllers/groups_controller.rb' - 'app/controllers/import/base_controller.rb' - 'app/controllers/oauth/applications_controller.rb' - 'app/controllers/passwords_controller.rb' + - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb' - 'app/controllers/projects/badges_controller.rb' - 'app/controllers/projects/branches_controller.rb' - 'app/controllers/projects/environments_controller.rb' + - 'app/controllers/projects/hooks_controller.rb' - 'app/controllers/projects/incidents_controller.rb' - 'app/controllers/projects/issue_links_controller.rb' - 'app/controllers/projects/issues_controller.rb' @@ -36,6 +37,8 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/projects/project_members_controller.rb' - 'app/controllers/projects/prometheus/alerts_controller.rb' - 'app/controllers/projects/releases_controller.rb' + - 'app/controllers/projects/settings/integration_hook_logs_controller.rb' + - 'app/controllers/projects/settings/merge_requests_controller.rb' - 'app/controllers/projects/snippets_controller.rb' - 'app/controllers/projects/tags_controller.rb' - 'app/controllers/projects/todos_controller.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index 7bf78b82b60..c3f9ac25e7e 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -1,30 +1,28 @@ --- # Cop supports --auto-correct. Rails/NegateInclude: - # Offense count: 65 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/finders/projects_finder.rb' - 'app/helpers/application_settings_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/tree_helper.rb' - - 'app/models/concerns/timebox.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' + - 'app/models/integrations/field.rb' - 'app/models/label.rb' - 'app/models/merge_request.rb' + - 'app/models/milestone.rb' - 'app/services/todo_service.rb' + - 'app/services/work_items/parent_links/create_service.rb' - 'config/application.rb' - 'config/initializers/1_settings.rb' - 'danger/roulette/Dangerfile' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/services/epic_issues/create_service.rb' - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'lib/api/maven_packages.rb' - - 'lib/generators/gitlab/usage_metric_generator.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/ci/build/rules/rule/clause/exists.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' @@ -38,11 +36,10 @@ Rails/NegateInclude: - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab_edition.rb' + - 'qa/qa/page/merge_request/show.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/support/run.rb' - 'qa/qa/tools/delete_test_users.rb' - - 'qa/qa/vendor/jenkins/page/configure_job.rb' - - 'qa/qa/vendor/jenkins/page/last_job_console.rb' - 'rubocop/cop/gitlab/feature_available_usage.rb' - 'rubocop/cop/graphql/id_type.rb' - 'rubocop/cop/migration/add_reference.rb' @@ -56,3 +53,4 @@ Rails/NegateInclude: - 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb' - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' - 'spec/uploaders/object_storage_spec.rb' + - 'tooling/danger/specs.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 22af6131b33..0d23c51caae 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Rails/RedundantForeignKey: - Details: grace period Exclude: - 'app/models/alert_management/metric_image.rb' - 'app/models/ci/build.rb' diff --git a/.rubocop_todo/rails/skips_model_validations.yml b/.rubocop_todo/rails/skips_model_validations.yml deleted file mode 100644 index f5aa7411c89..00000000000 --- a/.rubocop_todo/rails/skips_model_validations.yml +++ /dev/null @@ -1,730 +0,0 @@ ---- -Rails/SkipsModelValidations: - # Offense count: 1424 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/controllers/import/github_controller.rb' - - 'app/controllers/projects/environments_controller.rb' - - 'app/controllers/projects/notes_controller.rb' - - 'app/models/alert_management/alert.rb' - - 'app/models/analytics/cycle_analytics/aggregation.rb' - - 'app/models/chat_name.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/build_trace_chunks/database.rb' - - 'app/models/ci/build_trace_metadata.rb' - - 'app/models/ci/daily_build_group_report_result.rb' - - 'app/models/ci/deleted_object.rb' - - 'app/models/ci/namespace_mirror.rb' - - 'app/models/ci/pending_build.rb' - - 'app/models/ci/pipeline_schedule.rb' - - 'app/models/ci/processable.rb' - - 'app/models/ci/project_mirror.rb' - - 'app/models/ci/resource_group.rb' - - 'app/models/ci/runner.rb' - - 'app/models/ci/running_build.rb' - - 'app/models/ci/unit_test.rb' - - 'app/models/commit_status.rb' - - 'app/models/concerns/batch_nullify_dependent_associations.rb' - - 'app/models/concerns/board_recent_visit.rb' - - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/concerns/can_move_repository_storage.rb' - - 'app/models/concerns/cascading_namespace_setting_attribute.rb' - - 'app/models/concerns/counter_attribute.rb' - - 'app/models/concerns/deprecated_assignee.rb' - - 'app/models/concerns/file_store_mounter.rb' - - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/noteable.rb' - - 'app/models/concerns/packages/debian/distribution.rb' - - 'app/models/concerns/relative_positioning.rb' - - 'app/models/concerns/repository_storage_movable.rb' - - 'app/models/concerns/resolvable_note.rb' - - 'app/models/concerns/schedulable.rb' - - 'app/models/concerns/subscribable.rb' - - 'app/models/container_expiration_policy.rb' - - 'app/models/customer_relations/contact.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/deployment.rb' - - 'app/models/diff_note_position.rb' - - 'app/models/environment.rb' - - 'app/models/gpg_key.rb' - - 'app/models/group.rb' - - 'app/models/group_import_state.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/internal_id.rb' - - 'app/models/issue.rb' - - 'app/models/jira_import_state.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request/diff_commit_user.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/namespace.rb' - - 'app/models/note.rb' - - 'app/models/project.rb' - - 'app/models/project_authorization.rb' - - 'app/models/project_import_state.rb' - - 'app/models/project_statistics.rb' - - 'app/models/project_wiki.rb' - - 'app/models/projects/ci_feature_usage.rb' - - 'app/models/projects/repository_storage_move.rb' - - 'app/models/projects/topic.rb' - - 'app/models/raw_usage_data.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/route.rb' - - 'app/models/todo.rb' - - 'app/models/u2f_registration.rb' - - 'app/models/user.rb' - - 'app/models/user_custom_attribute.rb' - - 'app/models/user_interacted_project.rb' - - 'app/services/boards/lists/base_destroy_service.rb' - - 'app/services/boards/lists/move_service.rb' - - 'app/services/bulk_create_integration_service.rb' - - 'app/services/bulk_update_integration_service.rb' - - 'app/services/ci/abort_pipelines_service.rb' - - 'app/services/ci/disable_user_pipeline_schedules_service.rb' - - 'app/services/ci/expire_pipeline_cache_service.rb' - - 'app/services/ci/job_artifacts/create_service.rb' - - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - - 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb' - - 'app/services/ci/job_artifacts/update_unknown_locked_status_service.rb' - - 'app/services/ci/test_failure_history_service.rb' - - 'app/services/ci/update_build_state_service.rb' - - 'app/services/ci/update_pending_build_service.rb' - - 'app/services/clusters/agent_tokens/track_usage_service.rb' - - 'app/services/clusters/agents/refresh_authorization_service.rb' - - 'app/services/clusters/integrations/prometheus_health_check_service.rb' - - 'app/services/deployments/archive_in_project_service.rb' - - 'app/services/event_create_service.rb' - - 'app/services/groups/transfer_service.rb' - - 'app/services/issuable_base_service.rb' - - 'app/services/issues/move_service.rb' - - 'app/services/issues/set_crm_contacts_service.rb' - - 'app/services/keys/expiry_notification_service.rb' - - 'app/services/keys/last_used_service.rb' - - 'app/services/labels/promote_service.rb' - - 'app/services/labels/transfer_service.rb' - - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - - 'app/services/merge_requests/cleanup_refs_service.rb' - - 'app/services/merge_requests/ff_merge_service.rb' - - 'app/services/merge_requests/merge_service.rb' - - 'app/services/merge_requests/rebase_service.rb' - - 'app/services/merge_requests/reopen_service.rb' - - 'app/services/milestones/promote_service.rb' - - 'app/services/milestones/transfer_service.rb' - - 'app/services/packages/composer/create_package_service.rb' - - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/packages/generic/create_package_file_service.rb' - - 'app/services/packages/mark_package_files_for_destruction_service.rb' - - 'app/services/packages/npm/create_tag_service.rb' - - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/packages/rubygems/create_dependencies_service.rb' - - 'app/services/personal_access_tokens/last_used_service.rb' - - 'app/services/projects/destroy_service.rb' - - 'app/services/projects/detect_repository_languages_service.rb' - - 'app/services/projects/move_deploy_keys_projects_service.rb' - - 'app/services/projects/move_forks_service.rb' - - 'app/services/projects/move_lfs_objects_projects_service.rb' - - 'app/services/projects/move_notification_settings_service.rb' - - 'app/services/projects/move_project_authorizations_service.rb' - - 'app/services/projects/move_project_group_links_service.rb' - - 'app/services/projects/move_project_members_service.rb' - - 'app/services/projects/move_users_star_projects_service.rb' - - 'app/services/projects/repository_languages_service.rb' - - 'app/services/projects/unlink_fork_service.rb' - - 'app/services/reset_project_cache_service.rb' - - 'app/services/spam/akismet_mark_as_spam_service.rb' - - 'app/services/spam/ham_service.rb' - - 'app/services/suggestions/apply_service.rb' - - 'app/services/suggestions/outdate_service.rb' - - 'app/services/users/activity_service.rb' - - 'app/services/users/migrate_to_ghost_user_service.rb' - - 'app/services/users/respond_to_terms_service.rb' - - 'app/services/users/set_status_service.rb' - - 'app/services/users/upsert_credit_card_validation_service.rb' - - 'app/services/x509_certificate_revoke_service.rb' - - 'app/uploaders/file_mover.rb' - - 'app/uploaders/object_storage.rb' - - 'app/workers/analytics/usage_trends/counter_job_worker.rb' - - 'app/workers/concerns/dependency_proxy/expireable.rb' - - 'app/workers/concerns/packages/cleanup_artifact_worker.rb' - - 'app/workers/container_expiration_policy_worker.rb' - - 'app/workers/packages/helm/extraction_worker.rb' - - 'app/workers/packages/nuget/extraction_worker.rb' - - 'app/workers/packages/rubygems/extraction_worker.rb' - - 'app/workers/personal_access_tokens/expired_notification_worker.rb' - - 'app/workers/personal_access_tokens/expiring_worker.rb' - - 'app/workers/pipeline_metrics_worker.rb' - - 'app/workers/process_commit_worker.rb' - - 'app/workers/repository_check/clear_worker.rb' - - 'app/workers/repository_check/single_repository_worker.rb' - - 'app/workers/stuck_merge_jobs_worker.rb' - - 'app/workers/x509_issuer_crl_check_worker.rb' - - 'db/migrate/20210428151144_update_invalid_web_hooks.rb' - - 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb' - - 'db/migrate/20210630224625_generate_customers_dot_jwt_signing_key.rb' - - 'db/migrate/20210729123101_confirm_security_bot.rb' - - 'db/migrate/20220413054910_backfill_delayed_group_deletion.rb' - - 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb' - - 'db/post_migrate/20210303165302_cleanup_cluster_tokens_with_null_name.rb' - - 'db/post_migrate/20210406144743_backfill_total_tuple_count_for_batched_migrations.rb' - - 'db/post_migrate/20210513155546_backfill_nuget_temporary_packages_to_processing_status.rb' - - 'db/post_migrate/20210601073400_fix_total_stage_in_vsa.rb' - - 'db/post_migrate/20210615234935_fix_batched_migrations_old_format_job_arguments.rb' - - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb' - - 'db/post_migrate/20210731132939_backfill_stage_event_hash.rb' - - 'db/post_migrate/20210809123658_orphaned_invite_tokens_cleanup.rb' - - 'db/post_migrate/20210811122206_update_external_project_bots.rb' - - 'db/post_migrate/20210825150212_cleanup_remaining_orphan_invites.rb' - - 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb' - - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' - - 'db/post_migrate/20210908132335_disable_job_token_scope_when_unused.rb' - - 'db/post_migrate/20210914095310_cleanup_orphan_project_access_tokens.rb' - - 'db/post_migrate/20211217174331_mark_recalculate_finding_signatures_as_completed.rb' - - 'db/post_migrate/20211220123956_update_invalid_member_states.rb' - - 'db/post_migrate/20220305223212_add_security_training_providers.rb' - - 'db/post_migrate/20220307203459_rename_user_email_lookup_limit_setting_to_search_settings_cleanup.rb' - - 'db/post_migrate/20220322132242_update_pages_onboarding_state.rb' - - 'ee/app/controllers/ee/clusters/clusters_controller.rb' - - 'ee/app/models/approval_merge_request_rule.rb' - - 'ee/app/models/ci/minutes/namespace_monthly_usage.rb' - - 'ee/app/models/ci/minutes/project_monthly_usage.rb' - - 'ee/app/models/concerns/deprecated_approvals_before_merge.rb' - - 'ee/app/models/concerns/epic_tree_sorting.rb' - - 'ee/app/models/concerns/geo/replicable_registry.rb' - - 'ee/app/models/concerns/geo/verification_state.rb' - - 'ee/app/models/ee/description_version.rb' - - 'ee/app/models/ee/environment.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/event.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/iteration.rb' - - 'ee/app/models/ee/namespace_setting.rb' - - 'ee/app/models/ee/project_wiki.rb' - - 'ee/app/models/geo/container_repository_registry.rb' - - 'ee/app/models/geo/design_registry.rb' - - 'ee/app/models/geo/project_registry.rb' - - 'ee/app/models/geo_node.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/vulnerabilities/feedback.rb' - - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' - - 'ee/app/services/ci/minutes/additional_packs/change_namespace_service.rb' - - 'ee/app/services/ci/minutes/batch_reset_service.rb' - - 'ee/app/services/ci/minutes/refresh_cached_data_service.rb' - - 'ee/app/services/ci/minutes/reset_usage_service.rb' - - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' - - 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb' - - 'ee/app/services/ee/issues/move_service.rb' - - 'ee/app/services/ee/labels/promote_service.rb' - - 'ee/app/services/ee/milestones/promote_service.rb' - - 'ee/app/services/ee/projects/transfer_service.rb' - - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - - 'ee/app/services/epics/strategies/due_date_inherited_strategy.rb' - - 'ee/app/services/epics/strategies/start_date_inherited_strategy.rb' - - 'ee/app/services/geo/repository_verification_reset.rb' - - 'ee/app/services/incident_management/oncall_rotations/edit_service.rb' - - 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb' - - 'ee/app/services/iterations/cadences/create_iterations_in_advance_service.rb' - - 'ee/app/services/iterations/cadences/destroy_service.rb' - - 'ee/app/services/iterations/delete_service.rb' - - 'ee/app/services/iterations/roll_over_issues_service.rb' - - 'ee/app/services/ldap_group_reset_service.rb' - - 'ee/app/services/personal_access_tokens/revoke_invalid_tokens.rb' - - 'ee/app/services/security/findings/cleanup_service.rb' - - 'ee/app/services/security/ingestion/mark_as_resolved_service.rb' - - 'ee/app/services/security/store_findings_metadata_service.rb' - - 'ee/app/services/security/store_scan_service.rb' - - 'ee/app/services/security/update_training_service.rb' - - 'ee/app/services/vulnerabilities/starboard_vulnerability_resolve_service.rb' - - 'ee/app/workers/import_software_licenses_worker.rb' - - 'ee/app/workers/iterations_update_status_worker.rb' - - 'ee/app/workers/sync_seat_link_request_worker.rb' - - 'ee/lib/api/geo_replication.rb' - - 'ee/lib/ee/api/protected_branches.rb' - - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb' - - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'ee/lib/ee/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/gitlab/geo/replicator.rb' - - 'ee/lib/tasks/migrate/ldap.rake' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - - 'ee/spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' - - 'ee/spec/controllers/groups/ldaps_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - - 'ee/spec/factories/import_states.rb' - - 'ee/spec/features/admin/admin_settings_spec.rb' - - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/projects/settings/issues_settings_spec.rb' - - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - - 'ee/spec/features/projects/user_applies_custom_file_template_spec.rb' - - 'ee/spec/features/trials/select_namespace_spec.rb' - - 'ee/spec/finders/geo/repository_verification_finder_spec.rb' - - 'ee/spec/finders/security/findings_finder_spec.rb' - - 'ee/spec/finders/security/training_urls_finder_spec.rb' - - 'ee/spec/finders/template_finder_spec.rb' - - 'ee/spec/graphql/mutations/issues/set_epic_spec.rb' - - 'ee/spec/graphql/mutations/issues/set_escalation_policy_spec.rb' - - 'ee/spec/graphql/mutations/issues/set_iteration_spec.rb' - - 'ee/spec/graphql/resolvers/boards/epic_lists_resolvers_spec.rb' - - 'ee/spec/helpers/ee/blob_helper_spec.rb' - - 'ee/spec/helpers/push_rules_helper_spec.rb' - - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - - 'ee/spec/lib/ee/api/helpers_spec.rb' - - 'ee/spec/lib/ee/audit/group_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_ci_cd_setting_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/project_feature_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - - 'ee/spec/lib/gitlab/git_access_spec.rb' - - 'ee/spec/models/application_setting_spec.rb' - - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - - 'ee/spec/models/concerns/elastic/note_spec.rb' - - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - - 'ee/spec/models/dast/profile_schedule_spec.rb' - - 'ee/spec/models/ee/group_spec.rb' - - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - - 'ee/spec/models/ee/iterations/cadence_spec.rb' - - 'ee/spec/models/ee/vulnerability_spec.rb' - - 'ee/spec/models/geo_node_spec.rb' - - 'ee/spec/models/geo_node_status_spec.rb' - - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/instance_security_dashboard_spec.rb' - - 'ee/spec/models/merge_request/blocking_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - - 'ee/spec/models/packages/package_file_spec.rb' - - 'ee/spec/models/project_feature_spec.rb' - - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/project_spec.rb' - - 'ee/spec/models/project_team_spec.rb' - - 'ee/spec/models/push_rule_spec.rb' - - 'ee/spec/models/requirements_management/requirement_spec.rb' - - 'ee/spec/models/security/scan_spec.rb' - - 'ee/spec/models/snippet_repository_spec.rb' - - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - - 'ee/spec/models/vulnerabilities/stat_diff_spec.rb' - - 'ee/spec/policies/group_policy_spec.rb' - - 'ee/spec/policies/project_policy_spec.rb' - - 'ee/spec/requests/api/epic_issues_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/set_epic_spec.rb' - - 'ee/spec/requests/api/groups_spec.rb' - - 'ee/spec/requests/api/internal/app_sec/dast/site_validations_spec.rb' - - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - - 'ee/spec/requests/api/namespaces_spec.rb' - - 'ee/spec/requests/api/project_approvals_spec.rb' - - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/requests/projects/merge_requests_controller_spec.rb' - - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service_spec.rb' - - 'ee/spec/services/ci/minutes/email_notification_service_spec.rb' - - 'ee/spec/services/ci/register_job_service_spec.rb' - - 'ee/spec/services/ci_cd/setup_project_spec.rb' - - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - - 'ee/spec/services/ee/notification_service_spec.rb' - - 'ee/spec/services/ee/releases/create_evidence_service_spec.rb' - - 'ee/spec/services/epic_issues/update_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/epics/update_service_spec.rb' - - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - - 'ee/spec/services/groups/update_service_spec.rb' - - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/projects/setup_ci_cd_spec.rb' - - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - - 'ee/spec/services/vulnerabilities/starboard_vulnerability_resolve_service_spec.rb' - - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - - 'ee/spec/services/vulnerabilities/statistics/update_service_spec.rb' - - 'ee/spec/support/helpers/ee/geo_helpers.rb' - - 'ee/spec/support/shared_examples/models/requirement_issues_examples.rb' - - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' - - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' - - 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb' - - 'ee/spec/workers/geo/repositories_clean_up_worker_spec.rb' - - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - - 'ee/spec/workers/geo/repository_sync_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/primary/batch_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/secondary/scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb' - - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - - 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb' - - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - - 'lib/api/commit_statuses.rb' - - 'lib/api/usage_data.rb' - - 'lib/gitlab/background_migration/add_primary_email_to_emails_if_user_confirmed.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - - 'lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2.rb' - - 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb' - - 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - - 'lib/gitlab/background_migration/backfill_topics_title.rb' - - 'lib/gitlab/background_migration/backfill_user_namespace.rb' - - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/copy_column_using_background_migration_job.rb' - - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb' - - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'lib/gitlab/bitbucket_import/importer.rb' - - 'lib/gitlab/bitbucket_server_import/importer.rb' - - 'lib/gitlab/ci/tags/bulk_insert.rb' - - 'lib/gitlab/ci/trace.rb' - - 'lib/gitlab/composer/cache.rb' - - 'lib/gitlab/database/background_migration_job.rb' - - 'lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin.rb' - - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base.rb' - - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - - 'lib/gitlab/database/schema_migrations.rb' - - 'lib/gitlab/etag_caching/middleware.rb' - - 'lib/gitlab/fogbugz_import/importer.rb' - - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - - 'lib/gitlab/import/set_async_jid.rb' - - 'lib/gitlab/jira_import/handle_labels_service.rb' - - 'lib/gitlab/job_waiter.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - - 'lib/gitlab/markdown_cache/active_record/extension.rb' - - 'lib/gitlab/otp_key_rotator.rb' - - 'lib/gitlab/seeder.rb' - - 'lib/tasks/ci/cleanup.rake' - - 'lib/tasks/gitlab/external_diffs.rake' - - 'lib/tasks/gitlab/ldap.rake' - - 'lib/tasks/gitlab/user_management.rake' - - 'lib/tasks/migrate/migrate_iids.rake' - - 'spec/controllers/groups/dependency_proxy_for_containers_controller_spec.rb' - - 'spec/controllers/groups_controller_spec.rb' - - 'spec/controllers/import/bitbucket_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/projects/forks_controller_spec.rb' - - 'spec/controllers/projects/graphs_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/content_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - - 'spec/controllers/projects/repositories_controller_spec.rb' - - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/projects/starrers_controller_spec.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/uploads_controller_spec.rb' - - 'spec/factories/alert_management/alerts.rb' - - 'spec/factories/container_expiration_policies.rb' - - 'spec/factories/design_management/versions.rb' - - 'spec/factories/environments.rb' - - 'spec/factories/import_states.rb' - - 'spec/factories/projects.rb' - - 'spec/factories/usage_data.rb' - - 'spec/features/admin/admin_settings_spec.rb' - - 'spec/features/admin/admin_uses_repository_checks_spec.rb' - - 'spec/features/dashboard/projects_spec.rb' - - 'spec/features/groups_spec.rb' - - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' - - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' - - 'spec/features/issues/discussion_lock_spec.rb' - - 'spec/features/merge_request/merge_request_discussion_lock_spec.rb' - - 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb' - - 'spec/features/merge_request/user_locks_discussion_spec.rb' - - 'spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb' - - 'spec/features/merge_request/user_sees_diff_spec.rb' - - 'spec/features/merge_request/user_sees_merge_button_depending_on_unresolved_discussions_spec.rb' - - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - - 'spec/features/merge_request/user_sees_pipelines_spec.rb' - - 'spec/features/merge_request/user_views_merge_request_from_deleted_fork_spec.rb' - - 'spec/features/monitor_sidebar_link_spec.rb' - - 'spec/features/password_reset_spec.rb' - - 'spec/features/profiles/emails_spec.rb' - - 'spec/features/projects/blobs/blob_show_spec.rb' - - 'spec/features/projects/diffs/diff_show_spec.rb' - - 'spec/features/projects/features_visibility_spec.rb' - - 'spec/features/projects/fork_spec.rb' - - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/milestones/milestone_spec.rb' - - 'spec/features/projects/pipeline_schedules_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/settings/service_desk_setting_spec.rb' - - 'spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb' - - 'spec/features/projects/user_sees_sidebar_spec.rb' - - 'spec/features/projects_spec.rb' - - 'spec/features/u2f_spec.rb' - - 'spec/features/users/show_spec.rb' - - 'spec/features/webauthn_spec.rb' - - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/packages/go/package_finder_spec.rb' - - 'spec/finders/packages/maven/package_finder_spec.rb' - - 'spec/finders/packages/npm/package_finder_spec.rb' - - 'spec/finders/packages/nuget/package_finder_spec.rb' - - 'spec/finders/packages/package_finder_spec.rb' - - 'spec/finders/projects_finder_spec.rb' - - 'spec/finders/releases/group_releases_finder_spec.rb' - - 'spec/finders/releases_finder_spec.rb' - - 'spec/finders/user_group_notification_settings_finder_spec.rb' - - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' - - 'spec/graphql/mutations/issues/set_escalation_status_spec.rb' - - 'spec/graphql/mutations/issues/update_spec.rb' - - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - - 'spec/graphql/types/project_type_spec.rb' - - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/import_helper_spec.rb' - - 'spec/helpers/members_helper_spec.rb' - - 'spec/helpers/projects_helper_spec.rb' - - 'spec/initializers/active_record_locking_spec.rb' - - 'spec/lib/api/helpers_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb' - - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb' - - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/project_spec.rb' - - 'spec/lib/gitlab/contributions_calendar_spec.rb' - - 'spec/lib/gitlab/cycle_analytics/permissions_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - - 'spec/lib/gitlab/database/batch_count_spec.rb' - - 'spec/lib/gitlab/database/consistency_checker_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - - 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb' - - 'spec/lib/gitlab/discussions_diff/file_collection_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_on_issuable_handler_spec.rb' - - 'spec/lib/gitlab/etag_caching/store_spec.rb' - - 'spec/lib/gitlab/git_access_spec.rb' - - 'spec/lib/gitlab/git_access_wiki_spec.rb' - - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - - 'spec/lib/gitlab/middleware/go_spec.rb' - - 'spec/lib/gitlab/middleware/query_analyzer_spec.rb' - - 'spec/lib/gitlab/object_hierarchy_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/query_analyzer_spec.rb' - - 'spec/lib/sidebars/projects/menus/project_information_menu_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20211126115449_encrypt_static_objects_external_storage_auth_token_spec.rb' - - 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb' - - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/ci/build_dependencies_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/pipeline_schedule_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/processable_spec.rb' - - 'spec/models/ci/resource_group_spec.rb' - - 'spec/models/ci/runner_spec.rb' - - 'spec/models/ci/stage_spec.rb' - - 'spec/models/commit_signatures/gpg_signature_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/concerns/cache_markdown_field_spec.rb' - - 'spec/models/concerns/deployment_platform_spec.rb' - - 'spec/models/concerns/deprecated_assignee_spec.rb' - - 'spec/models/concerns/each_batch_spec.rb' - - 'spec/models/concerns/pg_full_text_searchable_spec.rb' - - 'spec/models/concerns/project_features_compatibility_spec.rb' - - 'spec/models/concerns/spammable_spec.rb' - - 'spec/models/container_repository_spec.rb' - - 'spec/models/deploy_keys_project_spec.rb' - - 'spec/models/deploy_token_spec.rb' - - 'spec/models/diff_discussion_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/guest_spec.rb' - - 'spec/models/integration_spec.rb' - - 'spec/models/issue_spec.rb' - - 'spec/models/loose_foreign_keys/deleted_record_spec.rb' - - 'spec/models/member_spec.rb' - - 'spec/models/members/group_member_spec.rb' - - 'spec/models/members/project_member_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/namespace/traversal_hierarchy_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/project_authorization_spec.rb' - - 'spec/models/project_feature_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/project_statistics_spec.rb' - - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - - 'spec/models/projects/topic_spec.rb' - - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/route_spec.rb' - - 'spec/models/snippet_repository_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/policies/ci/build_policy_spec.rb' - - 'spec/policies/custom_emoji_policy_spec.rb' - - 'spec/policies/note_policy_spec.rb' - - 'spec/policies/project_policy_spec.rb' - - 'spec/presenters/ci/build_presenter_spec.rb' - - 'spec/presenters/project_presenter_spec.rb' - - 'spec/requests/api/ci/job_artifacts_spec.rb' - - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' - - 'spec/requests/api/container_repositories_spec.rb' - - 'spec/requests/api/graphql/container_repository/container_repository_details_spec.rb' - - 'spec/requests/api/graphql/group/dependency_proxy_blobs_spec.rb' - - 'spec/requests/api/graphql/group/dependency_proxy_group_setting_spec.rb' - - 'spec/requests/api/graphql/group/dependency_proxy_image_ttl_policy_spec.rb' - - 'spec/requests/api/graphql/group/dependency_proxy_manifests_spec.rb' - - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/update_spec.rb' - - 'spec/requests/api/helm_packages_spec.rb' - - 'spec/requests/api/issues/get_group_issues_spec.rb' - - 'spec/requests/api/issues/get_project_issues_spec.rb' - - 'spec/requests/api/issues/issues_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/notes_spec.rb' - - 'spec/requests/api/nuget_group_packages_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/pypi_packages_spec.rb' - - 'spec/requests/api/releases_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/tags_spec.rb' - - 'spec/requests/git_http_spec.rb' - - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - - 'spec/requests/jwt_controller_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/requests/projects/merge_requests_spec.rb' - - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' - - 'spec/services/alert_management/create_alert_issue_service_spec.rb' - - 'spec/services/ci/compare_reports_base_service_spec.rb' - - 'spec/services/ci/compare_test_reports_service_spec.rb' - - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - - 'spec/services/ci/register_job_service_spec.rb' - - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/ci/test_failure_history_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - - 'spec/services/deployments/update_environment_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - - 'spec/services/groups/transfer_service_spec.rb' - - 'spec/services/groups/update_service_spec.rb' - - 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb' - - 'spec/services/issuable/common_system_notes_service_spec.rb' - - 'spec/services/issues/clone_service_spec.rb' - - 'spec/services/issues/close_service_spec.rb' - - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/members/destroy_service_spec.rb' - - 'spec/services/merge_requests/get_urls_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/reopen_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - - 'spec/services/notes/update_service_spec.rb' - - 'spec/services/notification_service_spec.rb' - - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - - 'spec/services/packages/nuget/search_service_spec.rb' - - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' - - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - - 'spec/services/projects/fork_service_spec.rb' - - 'spec/services/projects/refresh_build_artifacts_size_statistics_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - - 'spec/services/spam/ham_service_spec.rb' - - 'spec/services/system_notes/design_management_service_spec.rb' - - 'spec/services/system_notes/issuables_service_spec.rb' - - 'spec/services/system_notes/time_tracking_service_spec.rb' - - 'spec/services/users/repair_ldap_blocked_service_spec.rb' - - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - - 'spec/support/helpers/access_matchers_helpers.rb' - - 'spec/support/matchers/access_matchers_for_controller.rb' - - 'spec/support/shared_contexts/email_shared_context.rb' - - 'spec/support/shared_contexts/finders/packages/npm/package_finder_shared_context.rb' - - 'spec/support/shared_contexts/mailers/notify_shared_context.rb' - - 'spec/support/shared_contexts/requests/api/npm_packages_shared_context.rb' - - 'spec/support/shared_examples/ci/stuck_builds_shared_examples.rb' - - 'spec/support/shared_examples/controllers/create_notes_rate_limit_shared_examples.rb' - - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - - 'spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb' - - 'spec/support/shared_examples/features/2fa_shared_examples.rb' - - 'spec/support/shared_examples/features/access_tokens_shared_examples.rb' - - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' - - 'spec/support/shared_examples/lib/banzai/reference_parser_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/featurable_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/ttl_expirable_shared_examples.rb' - - 'spec/support/shared_examples/models/members_notifications_shared_example.rb' - - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' - - 'spec/support/shared_examples/models/throttled_touch_shared_examples.rb' - - 'spec/support/shared_examples/policies/resource_access_token_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/members_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/user_activity_shared_examples.rb' - - 'spec/support/shared_examples/services/boards/lists_list_service_shared_examples.rb' - - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' - - 'spec/support/shared_examples/services/notification_service_shared_examples.rb' - - 'spec/support/shared_examples/views/pipeline_status_changes_email.rb' - - 'spec/support/trace/trace_helpers.rb' - - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - - 'spec/tasks/gitlab/artifacts/check_rake_spec.rb' - - 'spec/tasks/gitlab/external_diffs_rake_spec.rb' - - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - - 'spec/uploaders/job_artifact_uploader_spec.rb' - - 'spec/views/groups/edit.html.haml_spec.rb' - - 'spec/views/projects/environments/terminal.html.haml_spec.rb' - - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/build_finished_worker_spec.rb' - - 'spec/workers/ci/merge_requests/add_todo_when_build_fails_worker_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb' - - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/container_expiration_policy_worker_spec.rb' - - 'spec/workers/container_registry/migration/guard_worker_spec.rb' - - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' - - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' - - 'spec/workers/packages/cleanup_package_registry_worker_spec.rb' - - 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb' - - 'spec/workers/pipeline_schedule_worker_spec.rb' - - 'spec/workers/remote_mirror_notification_worker_spec.rb' - - 'spec/workers/repository_check/batch_worker_spec.rb' - - 'spec/workers/repository_check/clear_worker_spec.rb' diff --git a/.rubocop_todo/rails/squished_sql_heredocs.yml b/.rubocop_todo/rails/squished_sql_heredocs.yml deleted file mode 100644 index 9dcb989f571..00000000000 --- a/.rubocop_todo/rails/squished_sql_heredocs.yml +++ /dev/null @@ -1,215 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/SquishedSQLHeredocs: - # Offense count: 356 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/finders/members_finder.rb' - - 'app/models/analytics/cycle_analytics/stage_event_hash.rb' - - 'app/models/ci/resource_group.rb' - - 'app/models/clusters/clusters_hierarchy.rb' - - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' - - 'app/models/concerns/has_environment_scope.rb' - - 'app/models/customer_relations/contact.rb' - - 'app/models/customer_relations/organization.rb' - - 'app/models/deployment.rb' - - 'app/models/issue/metrics.rb' - - 'app/models/merge_request/metrics.rb' - - 'app/models/namespace/traversal_hierarchy.rb' - - 'app/models/namespaces/traversal/linear.rb' - - 'app/models/project.rb' - - 'app/models/user.rb' - - 'app/services/issuable/destroy_label_links_service.rb' - - 'app/services/issues/relative_position_rebalancing_service.rb' - - 'app/services/projects/fetch_statistics_increment_service.rb' - - 'app/services/todos/destroy/destroyed_issuable_service.rb' - - 'app/workers/users/deactivate_dormant_users_worker.rb' - - 'db/migrate/20210323155010_populate_dismissal_information_for_vulnerabilities.rb' - - 'db/migrate/20210601080039_group_protected_environments_add_index_and_constraint.rb' - - 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb' - - 'db/migrate/20210617022324_create_incident_management_pending_alert_escalations.rb' - - 'db/migrate/20210621043337_rename_services_to_integrations.rb' - - 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb' - - 'db/migrate/20210706152139_add_index_type_to_postgres_indexes_view.rb' - - 'db/migrate/20210719145532_add_foreign_keys_view.rb' - - 'db/migrate/20210721135638_add_triggers_to_integrations_type_new.rb' - - 'db/migrate/20210721174453_remove_schedule_and_status_null_constraints_from_pending_escalations_alert.rb' - - 'db/migrate/20210722150102_operations_feature_flags_correct_flexible_rollout_values.rb' - - 'db/migrate/20210730194555_create_incident_management_pending_issue_escalations.rb' - - 'db/migrate/20210818175949_update_integrations_trigger_type_new_on_insert.rb' - - 'db/migrate/20210825104656_create_analytics_cycle_analytics_merge_request_stage_events.rb' - - 'db/migrate/20210825110016_create_analytics_cycle_analytics_issue_stage_events.rb' - - 'db/migrate/20210826122748_create_loose_foreign_keys_deleted_records.rb' - - 'db/migrate/20210826145509_add_function_for_inserting_deleted_records.rb' - - 'db/migrate/20210903054158_recreate_stage_issue_events_table_with_bigints.rb' - - 'db/migrate/20210906100021_delete_project_namespace_trigger.rb' - - 'db/migrate/20210929032555_create_verification_codes.rb' - - 'db/migrate/20211005092428_drop_time_range_partitioned_loose_fk.rb' - - 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb' - - 'db/migrate/20211005100112_recreate_loose_fk_insert_function.rb' - - 'db/migrate/20211007090229_create_issue_search_table.rb' - - 'db/migrate/20211011141242_create_namespaces_sync_trigger.rb' - - 'db/migrate/20211011141243_create_projects_sync_trigger.rb' - - 'db/migrate/20211012015903_next_traversal_ids_sibling_function.rb' - - 'db/migrate/20211018161447_fix_double_entries_in_postgres_index_view.rb' - - 'db/migrate/20211112155416_populate_default_value_for_personal_access_tokens_prefix.rb' - - 'db/migrate/20211118103439_remove_hardcoded_partition_from_loose_fk_trigger_function.rb' - - 'db/migrate/20211123135255_create_batched_background_migration_job_transition_logs.rb' - - 'db/migrate/20220106111958_add_insert_or_update_vulnerability_reads_trigger.rb' - - 'db/migrate/20220106112043_add_update_vulnerability_reads_trigger.rb' - - 'db/migrate/20220106112085_add_update_vulnerability_reads_location_trigger.rb' - - 'db/migrate/20220106163326_add_has_issues_on_vulnerability_reads_trigger.rb' - - 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb' - - 'db/migrate/20220211214605_update_integrations_trigger_type_new_on_insert_null_safe.rb' - - 'db/migrate/20220213100000_remove_integration_type_triggers.rb' - - 'db/migrate/20220304052335_remove_not_null_contraint_on_title_from_sprints.rb' - - 'db/migrate/20220321234317_remove_all_issuable_escalation_statuses.rb' - - 'db/migrate/20220329110630_add_ci_namespace_mirrors_unnest_index_on_traversal_ids.rb' - - 'db/migrate/20220412060931_add_nullify_build_data_trigger_on_merge_request_metrics.rb' - - 'db/migrate/20220413124200_add_view_for_per_table_autovacuum_status.rb' - - 'db/migrate/20220415015143_replace_iterations_cadence_date_range_constraint.rb' - - 'db/migrate/20220422200633_fix_view_for_per_table_autovacuum_status.rb' - - 'db/migrate/20220422220507_remove_tmp_index_supporting_leaky_regex_cleanup.rb' - - 'db/post_migrate/20210302074524_backfill_namespace_statistics_with_wiki_size.rb' - - 'db/post_migrate/20210311045138_set_traversal_ids_for_gitlab_org_group_staging.rb' - - 'db/post_migrate/20210311045139_set_traversal_ids_for_gitlab_org_group_com.rb' - - 'db/post_migrate/20210311093723_add_partial_index_on_ci_pipelines_by_cancelable_status_and_users.rb' - - 'db/post_migrate/20210317104032_set_iteration_cadence_automatic_to_false.rb' - - 'db/post_migrate/20210331105335_drop_non_partitioned_audit_events.rb' - - 'db/post_migrate/20210430134202_copy_adoption_snapshot_namespace.rb' - - 'db/post_migrate/20210430135954_copy_adoption_segments_namespace.rb' - - 'db/post_migrate/20210525075724_clean_up_pending_builds_table.rb' - - 'db/post_migrate/20210609125005_drop_non_partitioned_web_hook_logs.rb' - - 'db/post_migrate/20210610102413_migrate_protected_attribute_to_pending_builds.rb' - - 'db/post_migrate/20210610141711_disable_expiration_policies_linked_to_no_container_images.rb' - - 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb' - - 'db/post_migrate/20210721174521_add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations.rb' - - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - - 'db/post_migrate/20210910194952_update_report_type_for_existing_approval_project_rules.rb' - - 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb' - - 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb' - - 'db/post_migrate/20211130165043_backfill_sequence_column_for_sprints_table.rb' - - 'db/post_migrate/20211206161271_add_indexes_for_primary_email_cleanup_migration.rb' - - 'db/post_migrate/20211220064757_drop_temporary_indexes_for_primary_email_migration.rb' - - 'db/post_migrate/20220128155251_remove_dangling_running_builds.rb' - - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - - 'db/post_migrate/20220204110725_backfill_cycle_analytics_aggregations.rb' - - 'db/post_migrate/20220213103859_remove_integrations_type.rb' - - 'db/post_migrate/20220309084954_remove_leftover_external_pull_request_deletions.rb' - - 'db/post_migrate/20220318111040_add_indexes_for_primary_email_second_cleanup_migration.rb' - - 'db/post_migrate/20220318111949_drop_temporary_indexes_for_primary_email_migration_second_cleanup.rb' - - 'db/post_migrate/20220329175119_remove_leftover_ci_job_artifact_deletions.rb' - - 'db/post_migrate/20220420135946_update_batched_background_migration_arguments.rb' - - 'ee/app/models/dora/daily_metrics.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/vulnerabilities/statistic.rb' - - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - - 'ee/app/services/vulnerabilities/statistics/update_service.rb' - - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb' - - 'ee/db/geo/migrate/20180510223634_set_resync_flag_for_retried_projects.rb' - - 'ee/db/geo/post_migrate/20210217020154_add_unique_index_on_container_repository_registry.rb' - - 'ee/db/geo/post_migrate/20210217020156_add_unique_index_on_terraform_state_version_registry.rb' - - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/gitlab/geo/base_batcher.rb' - - 'ee/spec/models/ee/user_spec.rb' - - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_group_features.rb' - - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - - 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_project_settings.rb' - - 'lib/gitlab/background_migration/backfill_projects_with_coverage.rb' - - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - - 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - - 'lib/gitlab/background_migration/update_timelogs_project_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - - 'lib/gitlab/database/bulk_update.rb' - - 'lib/gitlab/database/count/tablesample_count_strategy.rb' - - 'lib/gitlab/database/load_balancing/load_balancer.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/migration_helpers/loose_foreign_key_helpers.rb' - - 'lib/gitlab/database/migration_helpers/v2.rb' - - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' - - 'lib/gitlab/database/migrations/observers/query_statistics.rb' - - 'lib/gitlab/database/partitioning/replace_table.rb' - - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - - 'lib/gitlab/database/partitioning/time_partition.rb' - - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' - - 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb' - - 'lib/gitlab/database/schema_helpers.rb' - - 'lib/gitlab/database/schema_migrations/migrations.rb' - - 'lib/gitlab/database/unidirectional_copy_trigger.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition.rb' - - 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb' - - 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb' - - 'lib/gitlab/sql/glob.rb' - - 'lib/tasks/dev.rake' - - 'qa/qa/service/praefect_manager.rb' - - 'spec/db/schema_spec.rb' - - 'spec/initializers/00_rails_disable_joins_spec.rb' - - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb' - - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - - 'spec/lib/gitlab/database/partitioning/replace_table_spec.rb' - - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - - 'spec/lib/gitlab/database/postgres_foreign_key_spec.rb' - - 'spec/lib/gitlab/database/postgres_index_bloat_estimate_spec.rb' - - 'spec/lib/gitlab/database/postgres_index_spec.rb' - - 'spec/lib/gitlab/database/postgres_partition_spec.rb' - - 'spec/lib/gitlab/database/postgres_partitioned_table_spec.rb' - - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' - - 'spec/lib/gitlab/database/reindexing_spec.rb' - - 'spec/lib/gitlab/database/schema_migrations/migrations_spec.rb' - - 'spec/lib/gitlab/database/similarity_score_spec.rb' - - 'spec/lib/gitlab/database/unidirectional_copy_trigger_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy_spec.rb' - - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - - 'spec/models/application_record_spec.rb' - - 'spec/models/concerns/after_commit_queue_spec.rb' - - 'spec/support/db_cleaner.rb' - - 'spec/support/helpers/database/partitioning_helpers.rb' - - 'spec/support/helpers/database/table_schema_helpers.rb' - - 'spec/support/helpers/database/trigger_helpers.rb' - - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' diff --git a/.rubocop_todo/rails/where_exists.yml b/.rubocop_todo/rails/where_exists.yml deleted file mode 100644 index 77722549722..00000000000 --- a/.rubocop_todo/rails/where_exists.yml +++ /dev/null @@ -1,44 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/WhereExists: - # Offense count: 48 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'app/models/application_setting/term.rb' - - 'app/models/ci/pipeline_artifact.rb' - - 'app/models/ci/ref.rb' - - 'app/models/clusters/agent.rb' - - 'app/models/concerns/has_wiki.rb' - - 'app/models/concerns/noteable.rb' - - 'app/models/container_repository.rb' - - 'app/models/design_management/design.rb' - - 'app/models/group.rb' - - 'app/models/group_deploy_token.rb' - - 'app/models/label.rb' - - 'app/models/lfs_object.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/namespace.rb' - - 'app/models/project.rb' - - 'app/models/protected_branch/push_access_level.rb' - - 'app/services/projects/transfer_service.rb' - - 'app/services/todos/destroy/unauthorized_features_service.rb' - - 'db/migrate/20210422195929_create_elastic_reindexing_slices.rb' - - 'ee/app/models/approval_merge_request_rule_source.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/group_member.rb' - - 'ee/app/models/ee/milestone_release.rb' - - 'ee/app/models/geo_node.rb' - - 'ee/app/models/merge_requests/external_status_check.rb' - - 'ee/app/models/merge_train.rb' - - 'ee/app/workers/concerns/elastic/indexing_control.rb' - - 'lib/gitlab/auth.rb' - - 'lib/gitlab/checks/matching_merge_request.rb' - - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/services/clusters/cleanup/service_account_service_spec.rb' - - 'spec/services/clusters/destroy_service_spec.rb' diff --git a/.rubocop_todo/rake/require.yml b/.rubocop_todo/rake/require.yml new file mode 100644 index 00000000000..5042f0d504e --- /dev/null +++ b/.rubocop_todo/rake/require.yml @@ -0,0 +1,26 @@ +--- +Rake/Require: + Details: grace period + Exclude: + - 'ee/lib/tasks/gitlab/spdx.rake' + - 'lib/tasks/gitlab/artifacts/migrate.rake' + - 'lib/tasks/gitlab/assets.rake' + - 'lib/tasks/gitlab/backup.rake' + - 'lib/tasks/gitlab/cleanup.rake' + - 'lib/tasks/gitlab/dependency_proxy/migrate.rake' + - 'lib/tasks/gitlab/docs/redirect.rake' + - 'lib/tasks/gitlab/graphql.rake' + - 'lib/tasks/gitlab/lfs/migrate.rake' + - 'lib/tasks/gitlab/metrics_exporter.rake' + - 'lib/tasks/gitlab/openapi.rake' + - 'lib/tasks/gitlab/packages/events.rake' + - 'lib/tasks/gitlab/packages/migrate.rake' + - 'lib/tasks/gitlab/pages.rake' + - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' + - 'lib/tasks/gitlab/terraform/migrate.rake' + - 'lib/tasks/gitlab/tw/codeowners.rake' + - 'lib/tasks/gitlab/x509/update.rake' + - 'lib/tasks/import.rake' + - 'lib/tasks/tokens.rake' + - 'qa/tasks/ci.rake' + - 'qa/tasks/webdrivers.rake' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 79dfd85281c..5e9e80402b4 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -123,10 +123,8 @@ RSpec/ContextWording: - 'ee/spec/features/groups/push_rules_spec.rb' - 'ee/spec/features/groups/saml_enforcement_spec.rb' - 'ee/spec/features/groups/saml_providers_spec.rb' - - 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/groups_spec.rb' - 'ee/spec/features/ide/user_commits_changes_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' @@ -498,7 +496,6 @@ RSpec/ContextWording: - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/award_emoji_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/event_collection_spec.rb' - 'ee/spec/models/ee/event_spec.rb' - 'ee/spec/models/ee/group_group_link_spec.rb' - 'ee/spec/models/ee/group_spec.rb' @@ -1361,7 +1358,6 @@ RSpec/ContextWording: - 'spec/features/projects/blobs/blob_show_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - 'spec/features/projects/branches/user_views_branches_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/ci/lint_spec.rb' - 'spec/features/projects/clusters_spec.rb' - 'spec/features/projects/commit/comments/user_adds_comment_spec.rb' @@ -1571,7 +1567,6 @@ RSpec/ContextWording: - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' - 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb' - - 'spec/graphql/resolvers/issues_resolver_spec.rb' - 'spec/graphql/resolvers/kas/agent_configurations_resolver_spec.rb' - 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb' - 'spec/graphql/resolvers/last_commit_resolver_spec.rb' @@ -2401,7 +2396,6 @@ RSpec/ContextWording: - 'spec/models/environment_spec.rb' - 'spec/models/environment_status_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - - 'spec/models/event_collection_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/experiment_spec.rb' - 'spec/models/external_pull_request_spec.rb' @@ -2777,7 +2771,6 @@ RSpec/ContextWording: - 'spec/routing/project_routing_spec.rb' - 'spec/rubocop/cop/gitlab/change_timezone_spec.rb' - 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb' - - 'spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb' - 'spec/rubocop/cop/gitlab/event_store_subscriber_spec.rb' - 'spec/rubocop/cop/gitlab/feature_available_usage_spec.rb' - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' @@ -2976,7 +2969,6 @@ RSpec/ContextWording: - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/members/groups/creator_service_spec.rb' - 'spec/services/members/projects/creator_service_spec.rb' - - 'spec/services/members/update_service_spec.rb' - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - 'spec/services/merge_requests/after_create_service_spec.rb' - 'spec/services/merge_requests/approval_service_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml index 4b1c4299b20..125055044de 100644 --- a/.rubocop_todo/rspec/empty_line_after_hook.yml +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -4,7 +4,6 @@ RSpec/EmptyLineAfterHook: Exclude: - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 626ed1390ce..83892031a6c 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -293,7 +293,6 @@ RSpec/ExpectChange: - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' @@ -712,6 +711,7 @@ RSpec/ExpectChange: - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/emails/create_service_spec.rb' + - 'spec/services/environments/create_for_build_service_spec.rb' - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/event_create_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 2da0040f8ed..b41233d83af 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -1,7 +1,27 @@ --- RSpec/FactoryBot/AvoidCreate: - Details: grace period Exclude: + - 'ee/spec/presenters/approval_rule_presenter_spec.rb' + - 'ee/spec/presenters/audit_event_presenter_spec.rb' + - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' + - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' + - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' + - 'ee/spec/presenters/dast/site_profile_presenter_spec.rb' + - 'ee/spec/presenters/ee/blob_presenter_spec.rb' + - 'ee/spec/presenters/ee/clusters/cluster_presenter_spec.rb' + - 'ee/spec/presenters/ee/instance_clusterable_presenter_spec.rb' + - 'ee/spec/presenters/ee/issue_presenter_spec.rb' + - 'ee/spec/presenters/ee/projects/security/configuration_presenter_spec.rb' + - 'ee/spec/presenters/epic_issue_presenter_spec.rb' + - 'ee/spec/presenters/epic_presenter_spec.rb' + - 'ee/spec/presenters/group_clusterable_presenter_spec.rb' + - 'ee/spec/presenters/label_presenter_spec.rb' + - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' + - 'ee/spec/presenters/merge_request_presenter_spec.rb' + - 'ee/spec/presenters/project_clusterable_presenter_spec.rb' + - 'ee/spec/presenters/subscription_presenter_spec.rb' + - 'ee/spec/presenters/vulnerability_presenter_spec.rb' + - 'ee/spec/presenters/web_hooks/group/hook_presenter_spec.rb' - 'ee/spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb' - 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb' - 'ee/spec/serializers/audit_event_entity_spec.rb' @@ -11,7 +31,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/clusters/environment_entity_spec.rb' - 'ee/spec/serializers/clusters/environment_serializer_spec.rb' - 'ee/spec/serializers/dashboard_environment_entity_spec.rb' - - 'ee/spec/serializers/dashboard_environments_project_entity_spec.rb' - 'ee/spec/serializers/dashboard_environments_serializer_spec.rb' - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' - 'ee/spec/serializers/dependency_entity_spec.rb' @@ -73,6 +92,62 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb' - 'ee/spec/serializers/vulnerability_entity_spec.rb' - 'ee/spec/serializers/vulnerability_note_entity_spec.rb' + - 'spec/presenters/alert_management/alert_presenter_spec.rb' + - 'spec/presenters/blob_presenter_spec.rb' + - 'spec/presenters/blobs/notebook_presenter_spec.rb' + - 'spec/presenters/ci/bridge_presenter_spec.rb' + - 'spec/presenters/ci/build_presenter_spec.rb' + - 'spec/presenters/ci/build_runner_presenter_spec.rb' + - 'spec/presenters/ci/group_variable_presenter_spec.rb' + - 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb' + - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' + - 'spec/presenters/ci/pipeline_presenter_spec.rb' + - 'spec/presenters/ci/stage_presenter_spec.rb' + - 'spec/presenters/ci/trigger_presenter_spec.rb' + - 'spec/presenters/ci/variable_presenter_spec.rb' + - 'spec/presenters/clusterable_presenter_spec.rb' + - 'spec/presenters/clusters/cluster_presenter_spec.rb' + - 'spec/presenters/commit_presenter_spec.rb' + - 'spec/presenters/commit_status_presenter_spec.rb' + - 'spec/presenters/deployments/deployment_presenter_spec.rb' + - 'spec/presenters/event_presenter_spec.rb' + - 'spec/presenters/gitlab/blame_presenter_spec.rb' + - 'spec/presenters/group_clusterable_presenter_spec.rb' + - 'spec/presenters/instance_clusterable_presenter_spec.rb' + - 'spec/presenters/issue_presenter_spec.rb' + - 'spec/presenters/label_presenter_spec.rb' + - 'spec/presenters/merge_request_presenter_spec.rb' + - 'spec/presenters/milestone_presenter_spec.rb' + - 'spec/presenters/packages/composer/packages_presenter_spec.rb' + - 'spec/presenters/packages/conan/package_presenter_spec.rb' + - 'spec/presenters/packages/detail/package_presenter_spec.rb' + - 'spec/presenters/packages/helm/index_presenter_spec.rb' + - 'spec/presenters/packages/npm/package_presenter_spec.rb' + - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' + - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' + - 'spec/presenters/packages/nuget/packages_versions_presenter_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/presenters/packages/nuget/service_index_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' + - 'spec/presenters/pages_domain_presenter_spec.rb' + - 'spec/presenters/project_clusterable_presenter_spec.rb' + - 'spec/presenters/project_hook_presenter_spec.rb' + - 'spec/presenters/project_presenter_spec.rb' + - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' + - 'spec/presenters/projects/security/configuration_presenter_spec.rb' + - 'spec/presenters/projects/settings/deploy_keys_presenter_spec.rb' + - 'spec/presenters/prometheus_alert_presenter_spec.rb' + - 'spec/presenters/release_presenter_spec.rb' + - 'spec/presenters/releases/link_presenter_spec.rb' + - 'spec/presenters/search_service_presenter_spec.rb' + - 'spec/presenters/service_hook_presenter_spec.rb' + - 'spec/presenters/snippet_blob_presenter_spec.rb' + - 'spec/presenters/snippet_presenter_spec.rb' + - 'spec/presenters/terraform/modules_presenter_spec.rb' + - 'spec/presenters/tree_entry_presenter_spec.rb' + - 'spec/presenters/user_presenter_spec.rb' + - 'spec/presenters/web_hook_log_presenter_spec.rb' - 'spec/serializers/access_token_entity_base_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/analytics_build_serializer_spec.rb' @@ -192,7 +267,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/project_serializer_spec.rb' - 'spec/serializers/prometheus_alert_entity_spec.rb' - 'spec/serializers/release_serializer_spec.rb' - - 'spec/serializers/remote_mirror_entity_spec.rb' - 'spec/serializers/review_app_setup_entity_spec.rb' - 'spec/serializers/runner_entity_spec.rb' - 'spec/serializers/serverless/domain_entity_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml new file mode 100644 index 00000000000..456eca57804 --- /dev/null +++ b/.rubocop_todo/rspec/factory_bot/strategy_in_callback.yml @@ -0,0 +1,54 @@ +--- +RSpec/FactoryBot/StrategyInCallback: + Details: grace period + Exclude: + - 'ee/spec/factories/ci/builds.rb' + - 'ee/spec/factories/ci/pipelines.rb' + - 'ee/spec/factories/dast_scanner_profiles.rb' + - 'ee/spec/factories/description_version.rb' + - 'ee/spec/factories/elastic/reindexing_tasks.rb' + - 'ee/spec/factories/epic_issues.rb' + - 'ee/spec/factories/geo/design_registry.rb' + - 'ee/spec/factories/geo_nodes.rb' + - 'ee/spec/factories/groups.rb' + - 'ee/spec/factories/merge_requests.rb' + - 'ee/spec/factories/namespaces.rb' + - 'ee/spec/factories/projects.rb' + - 'ee/spec/factories/protected_environments.rb' + - 'ee/spec/factories/users.rb' + - 'ee/spec/factories/vulnerabilities.rb' + - 'ee/spec/factories/vulnerabilities/external_issue_links.rb' + - 'ee/spec/factories/vulnerabilities/findings.rb' + - 'ee/spec/factories/vulnerabilities/issue_links.rb' + - 'ee/spec/factories/work_items.rb' + - 'spec/factories/alert_management/alerts.rb' + - 'spec/factories/ci/builds.rb' + - 'spec/factories/ci/pipelines.rb' + - 'spec/factories/ci/processable.rb' + - 'spec/factories/ci/runner_namespaces.rb' + - 'spec/factories/ci/runner_projects.rb' + - 'spec/factories/ci/runners.rb' + - 'spec/factories/clusters/clusters.rb' + - 'spec/factories/commits.rb' + - 'spec/factories/container_expiration_policies.rb' + - 'spec/factories/design_management/designs.rb' + - 'spec/factories/design_management/versions.rb' + - 'spec/factories/environments.rb' + - 'spec/factories/group_members.rb' + - 'spec/factories/groups.rb' + - 'spec/factories/integrations.rb' + - 'spec/factories/issues.rb' + - 'spec/factories/merge_requests.rb' + - 'spec/factories/ml/candidates.rb' + - 'spec/factories/namespaces.rb' + - 'spec/factories/packages/dependency_links.rb' + - 'spec/factories/packages/package_files.rb' + - 'spec/factories/packages/packages.rb' + - 'spec/factories/pool_repositories.rb' + - 'spec/factories/project_members.rb' + - 'spec/factories/projects.rb' + - 'spec/factories/releases.rb' + - 'spec/factories/resource_label_events.rb' + - 'spec/factories/terraform/state.rb' + - 'spec/factories/users.rb' + - 'spec/factories/work_items/parent_links.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index 3cf0e969c34..8930b709bfd 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -1,6 +1,5 @@ --- RSpec/FilePath: - Details: grace period Exclude: - 'ee/spec/frontend/fixtures/analytics/charts.rb' - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' @@ -65,3 +64,4 @@ RSpec/FilePath: - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/create_pipeline_service/tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/variables_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 218ec3bb478..e939abd2886 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -1,6 +1,5 @@ --- RSpec/MultipleMemoizedHelpers: - Details: grace period Exclude: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 61f1a09589f..9a272ec31cc 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. RSpec/ScatteredLet: - Details: grace period Exclude: - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' diff --git a/.rubocop_todo/rspec/timecop_travel.yml b/.rubocop_todo/rspec/timecop_travel.yml index a8ca3a5fad5..3a9ebc443fd 100644 --- a/.rubocop_todo/rspec/timecop_travel.yml +++ b/.rubocop_todo/rspec/timecop_travel.yml @@ -1,5 +1,4 @@ --- RSpec/TimecopTravel: Exclude: - - spec/workers/concerns/reenqueuer_spec.rb - qa/spec/support/repeater_spec.rb diff --git a/.rubocop_todo/style/accessor_grouping.yml b/.rubocop_todo/style/accessor_grouping.yml index a2ba217dbcc..a4fae856953 100644 --- a/.rubocop_todo/style/accessor_grouping.yml +++ b/.rubocop_todo/style/accessor_grouping.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/AccessorGrouping: - Details: grace period Exclude: - 'app/finders/template_finder.rb' - 'app/models/commit.rb' diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml index 1a155e3cca0..cb40669ca02 100644 --- a/.rubocop_todo/style/bare_percent_literals.yml +++ b/.rubocop_todo/style/bare_percent_literals.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/BarePercentLiterals: - Details: grace period Exclude: - 'app/models/commit.rb' - 'app/models/concerns/storage/legacy_namespace.rb' diff --git a/.rubocop_todo/style/case_like_if.yml b/.rubocop_todo/style/case_like_if.yml deleted file mode 100644 index 61f2e6bc238..00000000000 --- a/.rubocop_todo/style/case_like_if.yml +++ /dev/null @@ -1,63 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/CaseLikeIf: - Details: grace period - Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/groups/dependency_proxy/application_controller.rb' - - 'app/controllers/projects/labels_controller.rb' - - 'app/graphql/types/ci/job_need_union.rb' - - 'app/helpers/avatars_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' - - 'app/helpers/issues_helper.rb' - - 'app/helpers/routing/pseudonymization_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/models/integrations/jira.rb' - - 'app/models/members/member_task.rb' - - 'app/models/namespace.rb' - - 'app/models/packages/go/module_version.rb' - - 'app/serializers/group_child_serializer.rb' - - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/todo_service.rb' - - 'app/services/user_project_access_changed_service.rb' - - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - - 'ee/app/finders/ee/notes_finder.rb' - - 'ee/app/finders/security/scan_execution_policies_finder.rb' - - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - - 'ee/app/helpers/ee/branches_helper.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - - 'ee/app/services/merge_request_approval_settings/update_service.rb' - - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - - 'ee/spec/features/boards/user_adds_lists_to_board_spec.rb' - - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - - 'ee/spec/features/projects/custom_projects_template_spec.rb' - - 'ee/spec/support/matchers/ee/epic_aggregate_matchers.rb' - - 'lib/api/helpers/label_helpers.rb' - - 'lib/gitlab/ci/ansi2html.rb' - - 'lib/gitlab/ci/ansi2json/converter.rb' - - 'lib/gitlab/ci/build/image.rb' - - 'lib/gitlab/identifier.rb' - - 'lib/gitlab/issues/rebalancing/state.rb' - - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' - - 'lib/gitlab/utils.rb' - - 'lib/gitlab/utils/strong_memoize.rb' - - 'qa/qa/git/repository.rb' - - 'qa/qa/scenario/bootable.rb' - - 'spec/features/boards/user_adds_lists_to_board_spec.rb' - - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - - 'spec/models/concerns/sha_attribute_spec.rb' - - 'spec/models/preloaders/labels_preloader_spec.rb' - - 'spec/requests/api/personal_access_tokens_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/resource_events/change_state_service_spec.rb' - - 'spec/support/helpers/filter_spec_helper.rb' - - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' - - 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 7fbec98ead5..300d8678719 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/EmptyMethod: - Details: grace period Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 346be201322..20e8c976fb7 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/ExplicitBlockArgument: - Details: grace period Exclude: - 'app/controllers/admin/background_migrations_controller.rb' - 'app/controllers/admin/batched_jobs_controller.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index a4ae491b902..f46f8c8f4f6 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -693,7 +693,6 @@ Style/GuardClause: - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' - 'rubocop/cop/api/grape_array_missing_coerce.rb' - - 'rubocop/cop/gitlab/duplicate_spec_location.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - 'rubocop/cop/gitlab/finder_with_find_by.rb' - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' @@ -717,7 +716,6 @@ Style/GuardClause: - 'spec/support/capybara.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/helpers/access_matchers_helpers.rb' - - 'spec/support/helpers/bare_repo_operations.rb' - 'spec/support/helpers/capybara_helpers.rb' - 'spec/support/helpers/dropzone_helper.rb' - 'spec/support/helpers/fake_blob_helpers.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 8e295c68623..fc05a8bc163 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -309,7 +309,6 @@ Style/IfUnlessModifier: - 'app/services/issues/update_service.rb' - 'app/services/lfs/lock_file_service.rb' - 'app/services/members/destroy_service.rb' - - 'app/services/members/update_service.rb' - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' @@ -743,7 +742,6 @@ Style/IfUnlessModifier: - 'ee/spec/support/http_io/http_io_helpers.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - - 'ee/spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'lib/api/api_guard.rb' - 'lib/api/boards_responses.rb' @@ -1202,7 +1200,6 @@ Style/IfUnlessModifier: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - 'spec/views/projects/edit.html.haml_spec.rb' - - 'spec/views/shared/access_tokens/_table.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 3521f295cc1..ca6cb416b93 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/KeywordParametersOrder: - Details: grace period Exclude: - 'app/controllers/concerns/product_analytics_tracking.rb' - 'app/finders/group_descendants_finder.rb' @@ -50,7 +49,6 @@ Style/KeywordParametersOrder: - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - 'qa/spec/runtime/env_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' diff --git a/.rubocop_todo/style/lambda.yml b/.rubocop_todo/style/lambda.yml index f733af601ec..f37c2c4967e 100644 --- a/.rubocop_todo/style/lambda.yml +++ b/.rubocop_todo/style/lambda.yml @@ -1,273 +1,82 @@ --- -# Cop supports --auto-correct. +# Cop supports --autocorrect. Style/Lambda: - # Offense count: 653 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/spammable_actions/captcha_check/rest_api_actions_support.rb' - - 'app/controllers/projects/issues_controller.rb' - - 'app/controllers/search_controller.rb' - - 'app/graphql/mutations/container_repositories/destroy_tags.rb' - - 'app/graphql/mutations/design_management/delete.rb' - - 'app/graphql/types/permission_types/base_permission_type.rb' - - 'app/models/analytics/cycle_analytics/issue_stage_event.rb' - - 'app/models/analytics/cycle_analytics/merge_request_stage_event.rb' - - 'app/models/bulk_imports/tracker.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/deleted_object.rb' - - 'app/models/ci/instance_variable.rb' - - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/namespace_mirror.rb' - - 'app/models/ci/pending_build.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/processable.rb' - - 'app/models/ci/runner.rb' - - 'app/models/clusters/cluster.rb' - - 'app/models/clusters/concerns/application_status.rb' - - 'app/models/commit_status.rb' - - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' - - 'app/models/concerns/approvable_base.rb' - - 'app/models/concerns/atomic_internal_id.rb' - - 'app/models/concerns/ci/has_status.rb' - - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' - - 'app/models/concerns/has_environment_scope.rb' - - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/id_in_ordered.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/issue_resource_event.rb' - - 'app/models/concerns/milestoneable.rb' - - 'app/models/concerns/mirror_authentication.rb' - - 'app/models/concerns/packages/debian/component_file.rb' - - 'app/models/concerns/reactive_caching.rb' - - 'app/models/concerns/timebox.rb' - - 'app/models/container_repository.rb' - - 'app/models/custom_emoji.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/action.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/version.rb' - - 'app/models/environment.rb' - - 'app/models/event.rb' - - 'app/models/group.rb' - - 'app/models/group_deploy_key.rb' - - 'app/models/group_group_link.rb' - - 'app/models/hooks/web_hook.rb' - - 'app/models/identity.rb' - - 'app/models/import_failure.rb' - - 'app/models/integrations/zentao_tracker_data.rb' - - 'app/models/internal_id.rb' - - 'app/models/issue.rb' - - 'app/models/issue/metrics.rb' - - 'app/models/jira_connect_installation.rb' - - 'app/models/label.rb' - - 'app/models/label_link.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/member.rb' - - 'app/models/members/project_member.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request/cleanup_schedule.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/merge_request_diff_file.rb' - - 'app/models/merge_requests_closing_issues.rb' - - 'app/models/milestone.rb' - - 'app/models/namespace.rb' - - 'app/models/note.rb' - - 'app/models/note_diff_file.rb' - - 'app/models/notification_setting.rb' - - 'app/models/onboarding/progress.rb' - - 'app/models/operations/feature_flags/user_list.rb' - - 'app/models/packages/package.rb' - - 'app/models/packages/package_file.rb' - - 'app/models/pages_domain.rb' - - 'app/models/product_analytics_event.rb' - - 'app/models/programming_language.rb' - - 'app/models/project.rb' + - 'app/controllers/concerns/project_unauthorized.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' + - 'app/models/concerns/featurable.rb' - 'app/models/project_feature.rb' - - 'app/models/project_feature_usage.rb' - - 'app/models/projects/topic.rb' - - 'app/models/prometheus_alert_event.rb' - - 'app/models/raw_usage_data.rb' - - 'app/models/redirect_route.rb' - - 'app/models/release.rb' - - 'app/models/remote_mirror.rb' - - 'app/models/repository_language.rb' - - 'app/models/snippet.rb' - - 'app/models/timelog.rb' - - 'app/models/todo.rb' - - 'app/models/user.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/serializers/ci/daily_build_group_report_result_entity.rb' - 'app/serializers/group_child_entity.rb' - 'app/serializers/issuable_sidebar_basic_entity.rb' - 'app/serializers/merge_request_sidebar_basic_entity.rb' - - 'app/services/issues/referenced_merge_requests_service.rb' - - 'config/initializers/deprecations.rb' - - 'config/initializers/rspec_profiling.rb' + - 'config/application.rb' + - 'config/initializers/0_license.rb' + - 'config/initializers/0_log_deprecations.rb' + - 'config/initializers/action_cable.rb' + - 'config/initializers/gitlab_experiment.rb' + - 'config/initializers/lograge.rb' + - 'config/routes.rb' - 'config/routes/dashboard.rb' - 'config/routes/group.rb' - 'config/routes/issues.rb' - - 'db/post_migrate/20210303121224_update_gitlab_subscriptions_start_at_post_eoa.rb' - - 'db/post_migrate/20210513155546_backfill_nuget_temporary_packages_to_processing_status.rb' - - 'db/post_migrate/20210823132600_remove_duplicate_dast_site_tokens.rb' - - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' - - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - - 'ee/app/models/analytics/devops_adoption/snapshot.rb' - - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - - 'ee/app/models/approval_merge_request_rule.rb' - - 'ee/app/models/boards/epic_board_position.rb' - - 'ee/app/models/boards/epic_user_preference.rb' - - 'ee/app/models/ci/minutes/project_monthly_usage.rb' - - 'ee/app/models/concerns/ee/protected_ref.rb' - - 'ee/app/models/concerns/geo/replicable_model.rb' - - 'ee/app/models/concerns/issue_widgets/acts_like_requirement.rb' - - 'ee/app/models/dast/profile.rb' - - 'ee/app/models/dast_site_validation.rb' - - 'ee/app/models/dora/daily_metrics.rb' - - 'ee/app/models/ee/ci/build.rb' - - 'ee/app/models/ee/ci/daily_build_group_report_result.rb' - - 'ee/app/models/ee/ci/job_artifact.rb' - - 'ee/app/models/ee/ci/pipeline.rb' - - 'ee/app/models/ee/environment.rb' - - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/group_member.rb' - - 'ee/app/models/ee/identity.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - - 'ee/app/models/ee/label.rb' - - 'ee/app/models/ee/member.rb' - - 'ee/app/models/ee/merge_request.rb' - - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace_ci_cd_setting.rb' - - 'ee/app/models/ee/note.rb' - - 'ee/app/models/ee/project.rb' - - 'ee/app/models/ee/user.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/gitlab_subscription.rb' - - 'ee/app/models/incident_management/oncall_rotation.rb' - - 'ee/app/models/incident_management/oncall_shift.rb' - - 'ee/app/models/iterations/cadence.rb' - - 'ee/app/models/merge_request_block.rb' - - 'ee/app/models/merge_requests/external_status_check.rb' - - 'ee/app/models/merge_train.rb' - - 'ee/app/models/protected_environment.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/security/finding.rb' - - 'ee/app/models/security/orchestration_policy_configuration.rb' - - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/security/scan.rb' - - 'ee/app/models/security/training_provider.rb' - - 'ee/app/models/software_license_policy.rb' - - 'ee/app/models/vulnerabilities/feedback.rb' - - 'ee/app/models/vulnerabilities/finding.rb' - - 'ee/app/models/vulnerabilities/historical_statistic.rb' - - 'ee/app/models/vulnerabilities/read.rb' - - 'ee/app/models/vulnerabilities/scanner.rb' + - 'ee/app/controllers/concerns/ee/routable_actions/sso_enforcement_redirect.rb' - 'ee/app/serializers/ee/group_child_entity.rb' - - 'ee/lib/ee/api/entities/application_setting.rb' - - 'ee/lib/ee/api/entities/geo_node_status.rb' - - 'ee/lib/ee/api/entities/group.rb' + - 'ee/app/services/ee/issues/export_csv_service.rb' + - 'ee/lib/ee/api/entities/group_detail.rb' - 'ee/lib/ee/api/entities/group_push_rule.rb' - - 'ee/lib/ee/api/entities/project.rb' - - 'ee/lib/ee/api/entities/vulnerability_issue_link.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'ee/lib/ee/banzai/filter/sanitization_filter.rb' + - 'ee/lib/ee/gitlab/checks/diff_check.rb' + - 'ee/lib/elastic/latest/application_class_proxy.rb' - 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb' - - 'ee/spec/migrations/backfill_delayed_group_deletion_spec.rb' - - 'ee/spec/migrations/remove_schedule_and_status_null_constraints_from_pending_escalations_alert_spec.rb' + - 'ee/spec/elastic_integration/global_search_spec.rb' + - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/notes/create_service_spec.rb' + - 'ee/spec/support/helpers/elasticsearch_helpers.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_ee_instance_shared_examples.rb' - - 'lib/api/ci/jobs.rb' - - 'lib/api/ci/pipelines.rb' - - 'lib/api/entities/group_detail.rb' - - 'lib/api/entities/issue.rb' - 'lib/api/entities/label.rb' - - 'lib/api/entities/merge_request.rb' - 'lib/api/entities/project.rb' - 'lib/api/entities/project_export_status.rb' - - 'lib/api/feature_flags_user_lists.rb' - - 'lib/container_registry/base_client.rb' - - 'lib/container_registry/client.rb' - - 'lib/csv_builder.rb' - - 'lib/event_filter.rb' - - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/ci/config/entry/includes.rb' - - 'lib/gitlab/ci/config/entry/trigger.rb' - - 'lib/gitlab/config/entry/validatable.rb' - - 'lib/gitlab/database/background_migration/batched_migration.rb' - - 'lib/gitlab/database/background_migration_job.rb' - - 'lib/gitlab/database/postgres_foreign_key.rb' - - 'lib/gitlab/database/postgres_index.rb' - - 'lib/gitlab/database/postgres_partition.rb' - - 'lib/gitlab/database/postgres_partitioned_table.rb' - - 'lib/gitlab/gl_repository.rb' - - 'lib/gitlab/import_export/import_failure_service.rb' - - 'lib/gitlab/merge_requests/commit_message_generator.rb' - - 'lib/gitlab/seeder.rb' + - 'lib/api/validations/types/comma_separated_to_array.rb' + - 'lib/api/validations/types/comma_separated_to_integer_array.rb' + - 'lib/api/validations/types/hash_of_integer_values.rb' + - 'lib/api/validations/validators/check_assignees_count.rb' + - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' + - 'lib/banzai/filter/base_sanitization_filter.rb' + - 'lib/banzai/filter/sanitization_filter.rb' + - 'lib/gitlab/action_cable/request_store_callbacks.rb' + - 'lib/gitlab/checks/diff_check.rb' + - 'lib/gitlab/database/load_balancing/action_cable_callbacks.rb' + - 'lib/gitlab/memory/watchdog/configurator.rb' + - 'lib/gitlab/middleware/rack_multipart_tempfile_factory.rb' + - 'lib/gitlab/omniauth_initializer.rb' + - 'lib/gitlab/prometheus/queries/query_additional_metrics.rb' + - 'lib/gitlab/rack_attack.rb' - 'lib/gitlab/sidekiq_config/worker_matcher.rb' - - 'lib/gitlab/sidekiq_signals.rb' - - 'lib/gitlab/utils/measuring.rb' - - 'lib/gitlab/visibility_level.rb' - - 'rubocop/cop/rspec/modify_sidekiq_middleware.rb' - - 'rubocop/cop/rspec/timecop_freeze.rb' - - 'rubocop/cop/rspec/timecop_travel.rb' + - 'lib/gitlab/sidekiq_middleware.rb' + - 'lib/gitlab/utils/usage_data.rb' + - 'qa/qa/page/base.rb' + - 'qa/qa/runtime/allure_report.rb' + - 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb' + - 'qa/qa/support/api.rb' + - 'rubocop/cop/inject_enterprise_edition_module.rb' + - 'rubocop/cop/rspec/have_gitlab_http_status.rb' - 'spec/controllers/concerns/routable_actions_spec.rb' - - 'spec/deprecation_toolkit_env.rb' - - 'spec/factories/design_management/designs.rb' - - 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb' - - 'spec/graphql/resolvers/concerns/resolves_groups_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' + - 'spec/lib/gitlab/action_cable/request_store_callbacks_spec.rb' - 'spec/lib/gitlab/cross_project_access/class_methods_spec.rb' - - 'spec/lib/gitlab/database/consistency_spec.rb' - - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb' - - 'spec/lib/gitlab/database/load_balancing_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - - 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_metrics_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' - - 'spec/migrations/20210722150102_operations_feature_flags_correct_flexible_rollout_values_spec.rb' - - 'spec/migrations/20210804150320_create_base_work_item_types_spec.rb' - - 'spec/migrations/20210819145000_drop_temporary_columns_and_triggers_for_ci_builds_runner_session_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20210902144144_drop_temporary_columns_and_triggers_for_ci_build_needs_spec.rb' - - 'spec/migrations/20210906100316_drop_temporary_columns_and_triggers_for_ci_build_trace_chunks_spec.rb' - - 'spec/migrations/20210906130643_drop_temporary_columns_and_triggers_for_taggings_spec.rb' - - 'spec/migrations/20210907013944_cleanup_bigint_conversion_for_ci_builds_metadata_spec.rb' - - 'spec/migrations/20210915022415_cleanup_bigint_conversion_for_ci_builds_spec.rb' - - 'spec/migrations/20210922021816_drop_int4_columns_for_ci_job_artifacts_spec.rb' - - 'spec/migrations/20210922025631_drop_int4_column_for_ci_sources_pipelines_spec.rb' - - 'spec/migrations/20210922082019_drop_int4_column_for_events_spec.rb' - - 'spec/migrations/20210922091402_drop_int4_column_for_push_event_payloads_spec.rb' - - 'spec/migrations/20211126115449_encrypt_static_objects_external_storage_auth_token_spec.rb' - - 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb' - - 'spec/migrations/20220120094340_drop_position_from_security_findings_spec.rb' - - 'spec/migrations/20220128155814_fix_approval_rules_code_owners_rule_type_index_spec.rb' - - 'spec/migrations/20220305223212_add_security_training_providers_spec.rb' - - 'spec/migrations/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints_spec.rb' - - 'spec/migrations/generate_customers_dot_jwt_signing_key_spec.rb' - - 'spec/migrations/insert_ci_daily_pipeline_schedule_triggers_plan_limits_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/migrations/remove_schedule_and_status_from_pending_alert_escalations_spec.rb' - - 'spec/models/ability_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - - 'spec/models/concerns/participable_spec.rb' + - 'spec/lib/gitlab/middleware/rack_multipart_tempfile_factory_spec.rb' + - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/services/groups/autocomplete_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' + - 'spec/services/issues/referenced_merge_requests_service_spec.rb' - 'spec/services/projects/autocomplete_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/support/helpers/email_helpers.rb' + - 'spec/support/helpers/reference_parser_helpers.rb' - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' - - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' - - 'spec/workers/process_commit_worker_spec.rb' diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml index 9570bd7b036..295aa2f6878 100644 --- a/.rubocop_todo/style/next.yml +++ b/.rubocop_todo/style/next.yml @@ -2,32 +2,4 @@ # Cop supports --auto-correct. Style/Next: Exclude: - - 'app/models/concerns/integrations/slack_mattermost_notifier.rb' - - 'app/validators/nested_attributes_duplicates_validator.rb' - - 'ee/app/services/security/ingestion/tasks/update_vulnerability_uuids.rb' - - 'ee/db/fixtures/development/20_vulnerabilities.rb' - - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - - 'ee/lib/gitlab/elastic/search_results.rb' - - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'lib/backup/manager.rb' - - 'lib/banzai/filter/external_link_filter.rb' - - 'lib/banzai/filter/footnote_filter.rb' - - 'lib/banzai/filter/kroki_filter.rb' - - 'lib/banzai/filter/math_filter.rb' - - 'lib/banzai/filter/plantuml_filter.rb' - - 'lib/banzai/filter/table_of_contents_filter.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/database.rb' - 'lib/gitlab/fogbugz_import/importer.rb' - - 'lib/gitlab/gitaly_client/repository_service.rb' - - 'lib/gitlab/import_export/attributes_permitter.rb' - - 'lib/gitlab/import_export/base/relation_object_saver.rb' - - 'lib/gitlab/metrics/samplers/base_sampler.rb' - - 'lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy.rb' - - 'lib/gitlab/reference_extractor.rb' - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/gitlab/db/validate_config.rake' - - 'scripts/perf/query_limiting_report.rb' - - 'scripts/qa/quarantine-types-check' - - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 5de15180438..4e8b608e424 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/NumericLiteralPrefix: - Details: grace period Exclude: - 'app/models/container_repository.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 472a722ed22..bac2e807053 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -696,7 +696,6 @@ Style/PercentLiteralDelimiters: - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/projects/active_tabs_spec.rb' - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - - 'spec/features/projects/branches_spec.rb' - 'spec/features/projects/environments/environment_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/jobs_spec.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml index e96cdb26b08..d2851de201b 100644 --- a/.rubocop_todo/style/redundant_begin.yml +++ b/.rubocop_todo/style/redundant_begin.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/RedundantBegin: - Details: grace period Exclude: - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index 3747312f2c4..ca7e01ffa61 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -94,83 +94,4 @@ Style/RedundantInterpolation: - 'qa/qa/tools/generate_perf_testdata.rb' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/qa/testcases-check' - - 'spec/controllers/admin/integrations_controller_spec.rb' - - 'spec/features/commits_spec.rb' - - 'spec/features/issues/user_edits_issue_spec.rb' - - 'spec/features/merge_request/user_scrolls_to_note_on_load_spec.rb' - - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' - - 'spec/features/one_trust_spec.rb' - - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/projects/jobs/user_browses_jobs_spec.rb' - - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' - - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/snippets_helper_spec.rb' - - 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb' - - 'spec/lib/api/validations/validators/git_ref_spec.rb' - - 'spec/lib/api/validations/validators/limit_spec.rb' - - 'spec/lib/backup/database_backup_error_spec.rb' - - 'spec/lib/backup/file_backup_error_spec.rb' - - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/feature_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' - - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - - 'spec/lib/gitlab/database/batch_count_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb' - - 'spec/lib/gitlab/redis/multi_store_spec.rb' - - 'spec/lib/grafana/client_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/models/active_session_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/diff_discussion_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/presenters/project_presenter_spec.rb' - - 'spec/rack_servers/configs/config.ru' - - 'spec/requests/api/alert_management_alerts_spec.rb' - - 'spec/requests/api/markdown_spec.rb' - - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/metrics/dashboard/annotations_spec.rb' - - 'spec/requests/api/tags_spec.rb' - - 'spec/requests/api/terraform/state_spec.rb' - - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' - - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb' - - 'spec/routing/project_routing_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/groups/transfer_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - - 'spec/services/users/approve_service_spec.rb' - - 'spec/services/users/ban_service_spec.rb' - - 'spec/services/users/reject_service_spec.rb' - - 'spec/services/users/unban_service_spec.rb' - - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'spec/support/helpers/features/releases_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/kubernetes_helpers.rb' - - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - - 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb' - - 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb' - - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/issues_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/services/users/dismiss_user_callout_service_shared_examples.rb' - - 'spec/support_specs/graphql/arguments_spec.rb' - - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb' - 'tooling/rspec_flaky/flaky_example.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 3ffd27d26ae..a85039a45f5 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/SingleArgumentDig: - Details: grace period Exclude: - 'app/graphql/resolvers/namespace_projects_resolver.rb' - 'app/models/ci/build.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 535b8d20765..3c663b5f89a 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/SoleNestedConditional: - Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - 'app/controllers/ldap/omniauth_callbacks_controller.rb' diff --git a/.rubocop_todo/style/special_global_vars.yml b/.rubocop_todo/style/special_global_vars.yml deleted file mode 100644 index df688872d71..00000000000 --- a/.rubocop_todo/style/special_global_vars.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -# Cop supports --auto-correct. -Style/SpecialGlobalVars: - Details: grace period diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index ec15edbc206..65389d798d3 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -100,7 +100,6 @@ Style/StringConcatenation: - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - 'lib/api/entities/tree_object.rb' - - 'lib/api/go_proxy.rb' - 'lib/api/internal/kubernetes.rb' - 'lib/backup/files.rb' - 'lib/backup/manager.rb' @@ -316,7 +315,6 @@ Style/StringConcatenation: - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - - 'spec/support/helpers/git_helpers.rb' - 'spec/support/helpers/gitaly_setup.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - 'spec/support/helpers/kubernetes_helpers.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index fc90e1ce6a6..29e94e77345 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -1,7 +1,6 @@ --- # Cop supports --auto-correct. Style/StringLiteralsInInterpolation: - Details: grace period Exclude: - 'app/graphql/mutations/base_mutation.rb' - 'app/helpers/colors_helper.rb' |